Unexpected output: Affected paths: relative - resubmit patch.
⚙ D35 INP-1399 - Use relative paths during hash calculations
Page MenuHomeIn-Portal Phabricator

INP-1399 - Use relative paths during hash calculations
ClosedPublic

Authored by alex on Jan 14 2015, 5:51 AM.

Details

Test Plan
NOTE: Perform all steps below on new/existing template
  1. ensure that all of the following works (write down generated filename in each case)
    1. test watermark image ("Field" tag with "format" parameter, that will make use of "wm" option, e.g. <inp2:u.current_Field name="PrimaryImage" format="resize:200x100;wm:img/watermark_1_small.png|-5|-5"/>)
    2. test default image ("Field" tag with "format" parameter, that will make use of "default" option, e.g. <inp2:u.current_Field name="PrimaryImage" format="resize:200x100;default:img/watermark_1_small.png"/>)
    3. test compressed js/css file ("m_Compress" tag with "files" parameter, e.g. <inp2:m_Compress files="platform/inc/script.js"/>)
  2. rename folder with In-Portal (make sure you have closed PhpStorm before)
  3. reload test page (make sure to update In-Portal folder name in the browser too)
  4. confirm that names of all 3 generated files are still the same (without this patch names will differ)

P.S.
Use only existing watermark/default/script files in tests. Create ones if needed.

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

alex updated this revision to Diff 90.Jan 14 2015, 5:51 AM
alex retitled this revision from to INP-1399 - Use relative paths during hash calculations.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1399.
alex edited the test plan for this revision. (Show Details)Jan 14 2015, 5:52 AM
alex edited edge metadata.
glebs accepted this revision.Jan 26 2015, 2:56 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Jan 26 2015, 2:56 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 6:43 AM
alex added a project: Restricted Project.