Page MenuHomeIn-Portal Phabricator

INP-1767 - Purge expired database cache entries
ClosedPublic

Authored by alex on May 17 2019, 8:36 AM.

Details

Test Plan

Preparations

Create entries in SystemCache table (values in VarName and Data columns doesn't matter), where:

  • LifeTime = -1 + Timestamp is any number of seconds ago
  • LifeTime = -1 + Timestamp is in the future
  • LifeTime = 15 + Timestamp is more than 15 seconds ago
  • LifeTime = 15 + Timestamp is more than 15 seconds from now

Test Plan

  1. login to Admin Console
  2. rebuild unit config cache to add new scheduled task
  3. run added scheduled task
  4. confirm, that:
    • records with LifeTime = -1 are not removed no matter the Timestamp column value
    • records where Timestamp + Cached is in the past were removed

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Such issues will be fixed in 5.3.x
SeverityLocationCodeMessage
Errorcore/units/admin/admin_config.php:32PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/admin/admin_config.php:32PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/admin/admin_config.php:33PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/admin/admin_config.php:33PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/admin/admin_events_handler.php:1230PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
Errorcore/units/admin/admin_events_handler.php:1237PHPCS.E.CodingStandard.Classes.ClassDeclaration.NewlinesAfterCloseBraceCodingStandard.Classes.ClassDeclaration.NewlinesAfterCloseBrace
Unit
No Unit Test Coverage
Build Status
Buildable 927
Build 927: arc lint + arc unit

Event Timeline

alex created this revision.May 17 2019, 8:36 AM
alex requested review of this revision.May 17 2019, 8:36 AM
alex added a project: Restricted Project.May 17 2019, 8:37 AM
erik accepted this revision.May 21 2019, 5:57 AM
This revision is now accepted and ready to land.May 21 2019, 5:57 AM
This revision was landed with ongoing or failed builds.Jan 4 2021, 2:55 AM
This revision was automatically updated to reflect the committed changes.