optimized default persistent settings usage
Details
Details
- Set DBG_REDIRECT debugger setting to 1
- Login as root to the adm.console
- Go to Catalog & Website → Labels & Phrases section
- Truncate UserPersistentSessionData table
- Change grid sorting to "Modified On"
- Confirm, that in debugger shown only 3 select-SQL from UserPersistentSessionData table
- Change grid sorting to "Phrase"
- Confirm, that in debugger shown only 3 select-SQL from UserPersistentSessionData table
- Login as non-root to the adm.console
- Go to Catalog & Website → Labels & Phrases section
- Confirm, that Grid is sorted by "Phrase" column (same as was with root user)
- Change grid sorting to "Modified On"
- Confirm, that in debugger shown only 3 select-SQL from UserPersistentSessionData table
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.2.x
- Lint
Lint Errors Excuse: Full file re-formatting is not part of this task. Severity Location Code Message Error core/kernel/session/session_storage.php:47 PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeyword CodingStandard.Arrays.Array.SpaceAfterKeyword Error core/kernel/session/session_storage.php:47 PHPCS.E.CodingStandard.Classes.PropertyDeclaration.ScopeMissing CodingStandard.Classes.PropertyDeclaration.ScopeMissing Error core/kernel/session/session_storage.php:47 PHPCS.E.CodingStandard.Classes.PropertyDeclaration.VarUsed CodingStandard.Classes.PropertyDeclaration.VarUsed Error core/kernel/session/session_storage.php:47 PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.MemberNotCamelCaps CodingStandard.NamingConventions.ValidVariableName.MemberNotCamelCaps Error core/kernel/session/session_storage.php:47 PHPCS.E.Generic.PHP.LowerCaseKeyword.Found Generic.PHP.LowerCaseKeyword.Found Error core/kernel/session/session_storage.php:47 PHPCS.E.Squiz.Commenting.VariableComment.Missing Squiz.Commenting.VariableComment.Missing - Unit
No Unit Test Coverage - Build Status
Buildable 931 Build 931: arc lint + arc unit
Event Timeline
Comment Actions
Also since task does optimization only, then here we should be checking that persistent setting retrieval with/without fallback code works as before (not covered) + verify performed SQL count (covered).
| core/kernel/session/session_storage.php | ||
|---|---|---|
| 363 | according to implementation plan here you should be loading persistent settings of $default_user_id user | |
| core/kernel/session/session_storage.php | ||
|---|---|---|
| 380 | please remove (array) The kDBConnection::GetCol method only returns array (when no results found the array is empty). | |