Differential D36

INP-1400 - Store resized images from theme under /system folder
ClosedPublic
Actions

Authored by alex on Jan 14 2015, 7:35 AM.

Details

Reviewers

glebs

Commits

rINP16247: Fixes INP-1400 - Store resized images from theme under /system folder

Test Plan

create a Products → sub products category
in that category create:
- a tangible product without image
- a tangible product with an image
in the /themes/advanced/in-commerce/elements/products.elm.tpl template change the MaxWidth="thumbnail" to MaxWidth="50" in the product_element block
open created category on Front-End
confirm that both images (default one and uploaded one) were created under /system/thumbs/themes/advanced/platform/img/ folder
go to E-commerce → Manufacturers section in Admin Console
create/update manufacturer and upload a logo
open that manufacturer for editing
confirm that resized image was created under /system/thumbs/system/images/manufacturers/ folder
confirm that clean_resized_catalog_images scheduled task and it's img:OnCleanResizedImages event no longer exists
confirm, that when new file is uploaded the other files older then 1 day are removed from /system/thumbs/system/tmp folder
upgrade In-Portal from any previous version and confirm that any resized sub-folder in any folder under /system were deleted

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

alex updated this revision to Diff 91.Jan 14 2015, 7:35 AM

alex retitled this revision from to INP-1400 - Store resized images from theme under /system folder.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1400.

Herald added a reviewer: glebs. · View Herald TranscriptJan 14 2015, 7:35 AM

Default image, that was specified using relative path (containing ../) wasn't detected

glebs accepted this revision.Feb 24 2015, 2:07 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Feb 24 2015, 2:07 AM

Need to cover all resized images as well (see associated discussion in Confluence).

alex edited the test plan for this revision. (Show Details)Mar 21 2015, 2:33 PM

alex edited edge metadata.

alex edited the test plan for this revision. (Show Details)Mar 21 2015, 2:51 PM

alex edited the test plan for this revision. (Show Details)Mar 21 2015, 3:20 PM

Store all thumbnails under /system/thumbs/ folder

glebs accepted this revision.Mar 24 2015, 1:18 PM

glebs edited edge metadata.

This revision is now accepted and ready to land.Mar 24 2015, 1:18 PM

Closed by commit rINP16247: Fixes INP-1400 - Store resized images from theme under /system folder (authored by alex). · Explain WhySep 2 2015, 3:48 PM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 6:43 AM

alex added a project: Restricted Project.

Revision Contents
Changeset List

			Path	Packages
M			core/units/helpers/image_helper.php (18 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	91	16128		Jan 14 2015, 7:35 AM	★	★
Diff 2	92	16128	Default image, that was specified using relative path (containing `../`) wasn't detected	Jan 14 2015, 10:26 AM	★	★
Diff 3	144	16155	Store all thumbnails under /system/thumbs/ folder	Mar 21 2015, 3:23 PM	★	★
Diff 4	293	16246	Commit rINP16247	Sep 2 2015, 3:48 PM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 92

View Options

core/units/helpers/image_helper.php

INP-1400 - Store resized images from theme under /system folderClosedPublicActions