Unexpected output: Affected paths: relative - resubmit patch.
⚙ D389 INP-1791 - Add "picker" control type for configuration settings Added missing option/phrase for configuration editor screen.
Page MenuHomeIn-Portal Phabricator
Differential D389

INP-1791 - Add "picker" control type for configuration settings Added missing option/phrase for configuration editor screen.
AbandonedPublic
Actions

Authored by alex on Dec 9 2020, 7:55 AM.

Details

Reviewers
erik
Test Plan

TODO

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint ErrorsExcuse: Not fixing code, that wasn't added in this task.
SeverityLocationCodeMessage
Errorcore/kernel/db/db_tag_processor.php:2185PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/kernel/db/db_tag_processor.php:2185PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/units/configuration/configuration_config.php:104PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/configuration/configuration_config.php:104PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Warningcore/units/configuration/configuration_config.php:105PHPCS.W.CodingStandard.Arrays.Array.NoLastCommaCodingStandard.Arrays.Array.NoLastComma
Unit
No Unit Test Coverage
Build Status
Buildable 962
Build 962: arc lint + arc unit

Event Timeline

alex created this revision.Dec 9 2020, 7:55 AM
alex requested review of this revision.Dec 9 2020, 7:55 AM
alex abandoned this revision.Dec 9 2020, 8:01 AM

Duplicate of D388.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 193916600Dec 9 2020, 7:55 AM
★
★

Diff 939

View Options

core/admin_templates/incs/config_blocks.tpl

Loading...
View Options

core/install/english.lang

Loading...
View Options

core/kernel/db/db_tag_processor.php

Loading...
View Options

core/units/configuration/configuration_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server