Unexpected output: Affected paths: no mapping - resubmit patch.
⚙ D395 MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields
Page MenuHomeIn-Portal Phabricator
Differential D395

MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields
ClosedPublic
Actions

Authored by alex on Feb 23 2021, 3:19 AM.

Details

Reviewers
erik
Commits
rMINC16697: Fixes MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear"…
Test Plan
  1. login to Admin Console (the free In-Commerce module must be installed)
  2. go to Configuration → E-commerce → Payment Types section
  3. ensure, that Credit Card (manual) payment type is enabled
  4. go to E-commerce → Orders section
  5. create new sales order with Credit Card payment type
  6. confirm, that:
    • no notices were stored in System Log while moving between sale order tabs
    • the credit card expiration was stored to the database

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing non-changed code.
SeverityLocationCodeMessage
Errormodules/in-commerce/units/orders/orders_item.php:35PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Unit
No Unit Test Coverage
Build Status
Buildable 1005
Build 1005: arc lint + arc unit

Event Timeline

alex created this revision.Feb 23 2021, 3:19 AM
alex requested review of this revision.Feb 23 2021, 3:19 AM
alex added a project: Restricted Project.Feb 23 2021, 3:19 AM
alex updated this revision to Diff 983.Feb 23 2021, 3:28 AM

Previous fix changed logic of the code to allow empty field values, but that wasn't on purpose.

erik accepted this revision.Feb 23 2021, 4:56 AM
This revision is now accepted and ready to land.Feb 23 2021, 4:56 AM
This revision was landed with ongoing or failed builds.Jul 8 2022, 3:20 AM
Closed by commit rMINC16697: Fixes MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear"… (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 198216637Feb 23 2021, 3:18 AM
★
★
Diff 298316637Previous fix changed logic of the code to allow empty field values, but that…Feb 23 2021, 3:28 AM
★
★
Diff 3104516696rMINC16697Jul 8 2022, 3:20 AM
★
★

Diff 982

View Options

modules/in-commerce/units/orders/orders_item.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server