Page MenuHomeIn-Portal Phabricator
Feed All Stories

Oct 18 2014

alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Oct 18 2014, 2:27 AM · Restricted Project
alex reopened D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Oct 18 2014, 2:27 AM · Restricted Project

Oct 14 2014

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Oct 14 2014, 11:00 AM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Oct 14 2014, 9:22 AM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Oct 14 2014, 9:19 AM · Restricted Project

Oct 13 2014

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Oct 13 2014, 4:36 AM · Restricted Project

Oct 3 2014

alex requested changes to D3: INP-1381 - Create special template for fatal error page.

After using it a bit I've one edge case, that wasn't covered:

Oct 3 2014, 6:38 AM · Restricted Project

Oct 1 2014

alex accepted D14: INP-1385 - Redirect to last page of list after switching PerPage value.
Oct 1 2014, 4:38 AM · Restricted Project
glebs retitled D14: INP-1385 - Redirect to last page of list after switching PerPage value from to INP-1385 Redirect to last page of list after switching PerPage value.
Oct 1 2014, 4:22 AM · Restricted Project

Sep 26 2014

alex accepted D3: INP-1381 - Create special template for fatal error page.
Sep 26 2014, 3:01 AM · Restricted Project

Sep 25 2014

glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.

fixes by Alex's review

Sep 25 2014, 2:20 PM · Restricted Project
erik retitled D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice from to Duplicate empty_label translation.
Sep 25 2014, 11:33 AM
alex requested changes to D11: INP-1313 - Add support for copying content blocks between themes.
Sep 25 2014, 11:02 AM
alex requested changes to D12: INP-1312 - Mark themes as deleted instead of actually deleting them.
  1. please use only TABs for indentation (via TeamViewer discovered, that incorrect PhpStorm settings lead to this)
  2. populate (in upgrade.sql) the value of AddedOn column with UNIX_TIMESTAMP()
Sep 25 2014, 10:50 AM
alex requested changes to D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username.
Sep 25 2014, 10:40 AM
erik retitled D12: INP-1312 - Mark themes as deleted instead of actually deleting them from to Improving theme deleting alghoritm.
Sep 25 2014, 10:35 AM
alex requested changes to D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Sep 25 2014, 10:32 AM
erik retitled D11: INP-1313 - Add support for copying content blocks between themes from to Copy content blocks between themes.
Sep 25 2014, 10:31 AM
erik retitled D10: INP-1315 - Reset cached sorting on sorting configuration change from to Reset cached sorting on sorting configuration change.
Sep 25 2014, 10:28 AM
erik retitled D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username from to Admins are receiving e-mails with empty quotes.
Sep 25 2014, 10:09 AM
erik retitled D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages from to Keywords absent in the url of the search results page.
Sep 25 2014, 10:05 AM
alex requested changes to D7: INP-1379 - Don't query related items, when main item isn't found.
Sep 25 2014, 10:02 AM
alex accepted D6: MINB-22 - Fix notice during Poll voating.
Sep 25 2014, 9:52 AM
erik retitled D7: INP-1379 - Don't query related items, when main item isn't found from to SQL error, when printing related pages.
Sep 25 2014, 9:51 AM
erik retitled D6: MINB-22 - Fix notice during Poll voating from to Notice, when making a vote on Poll.
Sep 25 2014, 9:48 AM
erik retitled D5: TADV-34 - Incorrect usage of "block_no_data" attribute from to Incorrect usage of "block_no_data" attribute.
Sep 25 2014, 9:45 AM
alex accepted D4: INP-1382 - Rename "CategoryItemsEventHander" class into "CategoryItemsEventHandler" class.
Sep 25 2014, 9:39 AM
erik retitled D4: INP-1382 - Rename "CategoryItemsEventHander" class into "CategoryItemsEventHandler" class from to Typo in "CategoryItemsEventHander" class name.
Sep 25 2014, 9:33 AM

Sep 24 2014

alex requested changes to D3: INP-1381 - Create special template for fatal error page.

The patch needs to be created against 5.3.x branch.

Sep 24 2014, 8:50 AM · Restricted Project
glebs closed D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 24 2014, 6:08 AM · Restricted Project
alex removed rINP In-Portal as the repository for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 24 2014, 3:40 AM · Restricted Project
alex added a reviewer for D3: INP-1381 - Create special template for fatal error page: alex.
Sep 24 2014, 3:39 AM · Restricted Project

Sep 23 2014

glebs retitled D3: INP-1381 - Create special template for fatal error page from to INP-1381 Create special template for fatal error page.
Sep 23 2014, 12:25 PM · Restricted Project

Sep 19 2014

alex changed the visibility for D1: INP-1351 - Don't change user sorting on search result page.
Sep 19 2014, 10:19 AM
alex changed the visibility for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 10:18 AM · Restricted Project
alex accepted D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 10:07 AM · Restricted Project
alex set the repository for D2: INP-1380 - Use named parameters in error messages and add new parameter {field} to rINP In-Portal.
Sep 19 2014, 10:03 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

remove unused code to detect replaces count

Sep 19 2014, 9:56 AM · Restricted Project
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 9:51 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

Fix Alex's notes

Sep 19 2014, 9:21 AM · Restricted Project
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 5:48 AM · Restricted Project
alex set the repository for D2: INP-1380 - Use named parameters in error messages and add new parameter {field} to rINP In-Portal.
Sep 19 2014, 5:44 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

fix by Alex's comments

Sep 19 2014, 5:07 AM · Restricted Project
alex updated the test plan for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 4:09 AM · Restricted Project
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

Also please replace %s in all error messages that are affected by named error parameter introduction to corresponding named parameters in /core/install/upgrades.sql for 5.2.2-B1 version. Don't forget to update /core/install/english.lang as well.

Sep 19 2014, 3:24 AM · Restricted Project
glebs added a reviewer for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}: alex.
Sep 19 2014, 2:37 AM · Restricted Project
glebs retitled D2: INP-1380 - Use named parameters in error messages and add new parameter {field} from to Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 2:36 AM · Restricted Project

Aug 28 2014

alex abandoned D1: INP-1351 - Don't change user sorting on search result page.
Aug 28 2014, 11:44 AM
alex updated the diff for D1: INP-1351 - Don't change user sorting on search result page.
Aug 28 2014, 11:42 AM

May 13 2014

alex retitled D1: INP-1351 - Don't change user sorting on search result page from to Don't change user sorting on search result page.
May 13 2014, 3:24 AM