Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Mar 12 2015

alex set the repository for D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages to rINP In-Portal.
Mar 12 2015, 6:56 AM
alex added a comment to D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.

The http://qa.in-portal.org/D8?id=120 diff was created using wrong command arc diff --update D8 instead of arc diff --update D8 --cl and that's why it doesn't contain any relevant changes.

Mar 12 2015, 6:51 AM
alex retitled D49: INP-1412 - Always create extra priority for temp-only DB records from to INP-1412 - Always create extra priority for temp-only DB records.
Mar 12 2015, 6:28 AM
alex updated the test plan for D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Mar 12 2015, 5:31 AM

Mar 11 2015

alex added inline comments to D48: MINC-118 - Fix notices on Shipping/Billing tab of order in "To Ship" status.
Mar 11 2015, 1:40 PM
alex retitled D48: MINC-118 - Fix notices on Shipping/Billing tab of order in "To Ship" status from to MINC-118 - Notices on Shipping/Billing tab of order in "To Ship" status.
Mar 11 2015, 1:39 PM
alex updated the test plan for D46: INP-1411 - Store empty value in form field as-as.
Mar 11 2015, 12:51 PM · Restricted Project
alex updated the test plan for D46: INP-1411 - Store empty value in form field as-as.
Mar 11 2015, 12:50 PM · Restricted Project
alex requested review of D46: INP-1411 - Store empty value in form field as-as.
Mar 11 2015, 12:47 PM · Restricted Project
alex updated the diff for D46: INP-1411 - Store empty value in form field as-as.

Now numeric fields (int, float, double) won't have 0 stored in database, when an empty string value is submitted from the form.

Mar 11 2015, 12:47 PM · Restricted Project
alex planned changes to D46: INP-1411 - Store empty value in form field as-as.

Turns out this have negative side effect for numeric fields, where empty string is converted to 0 in database.

Mar 11 2015, 12:40 PM · Restricted Project
alex added inline comments to D47: MINC-117 - Update Backorder Flag, when reserving products in the order.
Mar 11 2015, 11:36 AM · Restricted Project
alex retitled D47: MINC-117 - Update Backorder Flag, when reserving products in the order from to MINC-117 - Reset backorder flag on orderitems.
Mar 11 2015, 11:34 AM · Restricted Project

Mar 10 2015

alex committed rINP16135: Fixes INP-1407 - Move Arcanist linter options to new location.
Fixes INP-1407 - Move Arcanist linter options to new location
Mar 10 2015, 6:33 AM
alex closed D41: INP-1407 - Move Arcanist linter options to new location by committing rINP16135: Fixes INP-1407 - Move Arcanist linter options to new location.
Mar 10 2015, 6:33 AM
alex added inline comments to D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Mar 10 2015, 5:10 AM

Mar 9 2015

alex retitled D46: INP-1411 - Store empty value in form field as-as from to INP-1411 - Store empty value in form field as-as.
Mar 9 2015, 7:27 AM · Restricted Project

Mar 6 2015

alex accepted D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.
Mar 6 2015, 4:01 AM

Mar 3 2015

alex updated the test plan for D45: INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter.
Mar 3 2015, 3:19 AM · Restricted Project
alex updated the test plan for D45: INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter.
Mar 3 2015, 3:17 AM · Restricted Project

Mar 2 2015

alex retitled D44: MINC-114 - Cleanup IDs of saved orders before adding/editing new orders from to MINC-114 - Cleanup IDs of saved orders before adding/editing new orders.
Mar 2 2015, 11:13 AM · Restricted Project

Feb 22 2015

alex requested changes to D10: INP-1315 - Reset cached sorting on sorting configuration change.

Code works, but it doesn't comply to coding standards.

Feb 22 2015, 3:15 PM
alex requested changes to D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.

Example hook in modules/custom/units/sections/sections_config.php file, that is currently commented out, still uses hAFTER.

Feb 22 2015, 3:01 PM
alex committed rMINC16134: Fixes MINC-110 - Add Addresses tab to user editing form by name, not index.
Fixes MINC-110 - Add Addresses tab to user editing form by name, not index
Feb 22 2015, 2:44 PM
alex updated the diff for D41: INP-1407 - Move Arcanist linter options to new location.

Solve merge conflicts after D33 merge

Feb 22 2015, 10:21 AM
alex retitled D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE from INP-1369 - Transform all hooks to u::OnAfterConfigRead event into hBEFORE to INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.
Feb 22 2015, 9:12 AM
alex committed rMINC16133: Fixes MINC-112 - Remove the SSN field.
Fixes MINC-112 - Remove the SSN field
Feb 22 2015, 9:08 AM
alex committed rTADV16132: Bug MINC-112 - Remove the SSN field.
Bug MINC-112 - Remove the SSN field
Feb 22 2015, 9:07 AM
alex closed D26: MINC-112 - Remove the SSN field by committing rTADV16132: Bug MINC-112 - Remove the SSN field.
Feb 22 2015, 9:07 AM · Restricted Project
alex committed rINP16131: Fixes INP-1389 - The hardcoded empty option in "CountryStatesHelper….
Fixes INP-1389 - The hardcoded empty option in "CountryStatesHelper…
Feb 22 2015, 8:50 AM
alex closed D19: INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method by committing rINP16131: Fixes INP-1389 - The hardcoded empty option in "CountryStatesHelper….
Feb 22 2015, 8:50 AM
alex committed rINP16130: Fixes INP-1397 - Validate PHP syntax during linting.
Fixes INP-1397 - Validate PHP syntax during linting
Feb 22 2015, 7:44 AM
alex closed D33: INP-1397 - Validate PHP syntax during linting by committing rINP16130: Fixes INP-1397 - Validate PHP syntax during linting.
Feb 22 2015, 7:44 AM
alex committed rINP16129: Fixes INP-1399 - Use relative paths during hash calculations.
Fixes INP-1399 - Use relative paths during hash calculations
Feb 22 2015, 7:37 AM
alex closed D35: INP-1399 - Use relative paths during hash calculations by committing rINP16129: Fixes INP-1399 - Use relative paths during hash calculations.
Feb 22 2015, 7:37 AM · Restricted Project

Feb 20 2015

alex accepted D43: INP-1409 - Don't calculate search relevance twice, when searching for one word only.
Feb 20 2015, 10:38 AM · Restricted Project
alex added inline comments to D43: INP-1409 - Don't calculate search relevance twice, when searching for one word only.
Feb 20 2015, 10:10 AM · Restricted Project
alex requested changes to D43: INP-1409 - Don't calculate search relevance twice, when searching for one word only.

Need to think about what are pros/cons of each approach described as inline comment below.

Feb 20 2015, 7:40 AM · Restricted Project

Feb 11 2015

alex retitled D42: INP-1408 - Perform search, when ENTER used in "grid_like_combo_filter" block (the AJAXDropdown) from to INP-1408 - The "grid_like_combo_filter" doesn't trigger search on ENTER press.
Feb 11 2015, 11:36 AM · Restricted Project

Feb 6 2015

alex retitled D41: INP-1407 - Move Arcanist linter options to new location from to INP-1407 - Move Arcanist linter options to new location.
Feb 6 2015, 4:00 PM

Jan 30 2015

alex retitled D40: INP-1406 - Change odd/even row color in SimpleGrid via jQuery from to INP-1406 - Change odd/even row color in SimpleGrid via jQuery.
Jan 30 2015, 9:17 AM · Restricted Project

Jan 23 2015

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 23 2015, 8:04 AM · Restricted Project

Jan 20 2015

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 20 2015, 4:16 AM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 20 2015, 4:08 AM · Restricted Project
alex requested changes to D3: INP-1381 - Create special template for fatal error page.

The translation of new setting is missing:

Jan 20 2015, 3:56 AM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 20 2015, 3:25 AM · Restricted Project
alex requested changes to D3: INP-1381 - Create special template for fatal error page.

Just this one minor fix and we're done I guess.

Jan 20 2015, 3:10 AM · Restricted Project

Jan 19 2015

alex retitled D39: INP-1403 - Trim long argument values in trace from to INP-1403 - Trim long argument values in trace.
Jan 19 2015, 10:39 AM

Jan 16 2015

alex requested changes to D3: INP-1381 - Create special template for fatal error page.

Almost there. Still I think following can be improved.

Jan 16 2015, 8:31 AM · Restricted Project
alex retitled D38: INP-1402 - Use "call_user_func" in System Log from to INP-1402 - Use "call_user_func" in System Log.
Jan 16 2015, 4:26 AM
alex added a comment to D37: INP-1401 - Don't use "die" in Debugger.

This will also solve problem in D3, where with enabled debugger System Log never logs fatal error about non-existing object method call.

Jan 16 2015, 3:56 AM
alex retitled D37: INP-1401 - Don't use "die" in Debugger from to INP-1401 - Don't use "die" in Debugger.
Jan 16 2015, 3:53 AM

Jan 15 2015

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 15 2015, 5:08 PM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 15 2015, 4:38 PM · Restricted Project

Jan 14 2015

alex updated the diff for D36: INP-1400 - Store resized images from theme under /system folder.

Default image, that was specified using relative path (containing ../) wasn't detected

Jan 14 2015, 10:26 AM · Restricted Project
alex retitled D36: INP-1400 - Store resized images from theme under /system folder from to INP-1400 - Store resized images from theme under /system folder.
Jan 14 2015, 7:35 AM · Restricted Project
alex updated the test plan for D35: INP-1399 - Use relative paths during hash calculations.
Jan 14 2015, 5:52 AM · Restricted Project
alex retitled D35: INP-1399 - Use relative paths during hash calculations from to INP-1399 - Use relative paths during hash calculations.
Jan 14 2015, 5:51 AM · Restricted Project

Jan 7 2015

alex retitled D34: INP-1398 - Add support for "result_to_var" parameter in "m_RenderElement" tag from to INP-1398 - Tag "m_RenderElement" is not handling "result_to_var" param.
Jan 7 2015, 5:29 AM

Jan 2 2015

alex retitled D33: INP-1397 - Validate PHP syntax during linting from to INP-1397 - Validate PHP syntax during linting.
Jan 2 2015, 6:05 AM

Jan 1 2015

alex committed rTADV16128: Merge of "themes/advanced/branches/1.2.x@16083" to "themes/advanced/branches/1..
Merge of "themes/advanced/branches/1.2.x@16083" to "themes/advanced/branches/1.
Jan 1 2015, 8:32 AM
alex committed rMINB16127: Merge of "modules/in-bulletin/branches/5.2.x@16097" to "modules/in….
Merge of "modules/in-bulletin/branches/5.2.x@16097" to "modules/in…
Jan 1 2015, 8:25 AM
alex committed rINP16124: Merge of "in-portal/branches/5.2.x@16121" to "in-portal/branches/5.3.x@16111"..
Merge of "in-portal/branches/5.2.x@16121" to "in-portal/branches/5.3.x@16111".
Jan 1 2015, 8:06 AM

Dec 30 2014

alex committed rINP16121: Fixes INP-1396 - Automatically validate submitted patches.
Fixes INP-1396 - Automatically validate submitted patches
Dec 30 2014, 10:38 AM
alex closed D32: INP-1396 - Automatically validate submitted patches by committing rINP16121: Fixes INP-1396 - Automatically validate submitted patches.
Dec 30 2014, 10:38 AM
alex retitled D32: INP-1396 - Automatically validate submitted patches from to INP-1396 - Automatically validate submitted patches.
Dec 30 2014, 9:10 AM
alex committed rINP16120: Fixes INP-1393 - Add description about "Except" header usage.
Fixes INP-1393 - Add description about "Except" header usage
Dec 30 2014, 8:46 AM
alex closed D28: INP-1393 - Add description about "Except" header usage to "kCurlHelper" class by committing rINP16120: Fixes INP-1393 - Add description about "Except" header usage.
Dec 30 2014, 8:46 AM
alex committed rINP16117: Fixes INP-1394 - Enable Composer Support.
Fixes INP-1394 - Enable Composer Support
Dec 30 2014, 6:46 AM
alex closed D29: INP-1394 - Enable Composer Support by committing rINP16117: Fixes INP-1394 - Enable Composer Support.
Dec 30 2014, 6:46 AM
alex closed D31: INP-1395 - Normalize "svn:ignore" across profiles.
Dec 30 2014, 6:08 AM
alex added a comment to D31: INP-1395 - Normalize "svn:ignore" across profiles.

The vendor folder got in property change by mistake. It's changed in D29 instead.

Dec 30 2014, 6:07 AM
alex committed rINP16116: Fixes INP-1395 - Normalize "svn:ignore" across profiles.
Fixes INP-1395 - Normalize "svn:ignore" across profiles
Dec 30 2014, 6:06 AM

Dec 27 2014

alex retitled D31: INP-1395 - Normalize "svn:ignore" across profiles from to INP-1395 - Normalize "svn:ignore" across profiles.
Dec 27 2014, 11:44 AM
alex retitled D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console from to INP-1205 - Category item in "Home" category not accessible.
Dec 27 2014, 4:42 AM
alex updated the diff for D29: INP-1394 - Enable Composer Support.

Accidentally removed all other changes from patch

Dec 27 2014, 4:33 AM
alex updated the diff for D29: INP-1394 - Enable Composer Support.

Changes to "svn:ignore" property of root folder were missing in previous version.

Dec 27 2014, 4:32 AM
alex retitled D29: INP-1394 - Enable Composer Support from to INP-1394 - Enable Composer Support.
Dec 27 2014, 4:27 AM

Dec 26 2014

alex retitled D28: INP-1393 - Add description about "Except" header usage to "kCurlHelper" class from to INP-1393 - Add description about "Except" header usage.
Dec 26 2014, 3:10 AM

Dec 19 2014

alex retitled D27: MINC-113 - Use mod-rewrite for Affiliate links from to MINC-113 - Use mod-rewrite for Affiliate links.
Dec 19 2014, 10:02 AM · Restricted Project

Dec 10 2014

alex retitled D26: MINC-112 - Remove the SSN field from to MINC-112 - Remove the SSN field.
Dec 10 2014, 8:27 AM · Restricted Project

Dec 9 2014

alex committed rINP16112: Bug INP-1390 - Create Phabricator configuration file.
Bug INP-1390 - Create Phabricator configuration file
Dec 9 2014, 2:48 AM
alex closed D25: INP-1390 - Create Phabricator configuration file by committing rINP16112: Bug INP-1390 - Create Phabricator configuration file.
Dec 9 2014, 2:48 AM

Dec 7 2014

alex set the repository for D2: INP-1380 - Use named parameters in error messages and add new parameter {field} to rINP In-Portal.
Dec 7 2014, 3:43 PM · Restricted Project
alex set the repository for D3: INP-1381 - Create special template for fatal error page to rINP In-Portal.
Dec 7 2014, 3:43 PM · Restricted Project
alex set the repository for D5: TADV-34 - Incorrect usage of "block_no_data" attribute to rINP In-Portal.
Dec 7 2014, 3:43 PM
alex changed the repository for D6: MINB-22 - Fix notice during Poll voating from rMINB Modules.In-Bulletin to rINP In-Portal.
Dec 7 2014, 3:43 PM
alex set the repository for D7: INP-1379 - Don't query related items, when main item isn't found to rINP In-Portal.
Dec 7 2014, 3:42 PM
alex set the repository for D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages to rINP In-Portal.
Dec 7 2014, 3:42 PM
alex set the repository for D1: INP-1351 - Don't change user sorting on search result page to rINP In-Portal.
Dec 7 2014, 3:42 PM
alex set the repository for D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username to rINP In-Portal.
Dec 7 2014, 3:41 PM
alex set the repository for D10: INP-1315 - Reset cached sorting on sorting configuration change to rINP In-Portal.
Dec 7 2014, 3:41 PM
alex set the repository for D11: INP-1313 - Add support for copying content blocks between themes to rINP In-Portal.
Dec 7 2014, 3:41 PM
alex set the repository for D12: INP-1312 - Mark themes as deleted instead of actually deleting them to rINP In-Portal.
Dec 7 2014, 3:41 PM
alex set the repository for D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice to rINP In-Portal.
Dec 7 2014, 3:41 PM
alex set the repository for D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request to rINP In-Portal.
Dec 7 2014, 3:40 PM · Restricted Project
alex set the repository for D16: INP-1387 - Move primary theme/language detection into corresponding units to rINP In-Portal.
Dec 7 2014, 3:40 PM
alex set the repository for D17: INP-1388 - Make CKEditor stylesheet within theme editable to rINP In-Portal.
Dec 7 2014, 3:40 PM · Restricted Project
alex changed the repository for D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products from rMINC Modules.In-Commerce to rINP In-Portal.
Dec 7 2014, 3:40 PM
alex set the repository for D19: INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method to rINP In-Portal.
Dec 7 2014, 3:39 PM