Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Mar 25 2019

alex requested review of D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Mar 25 2019, 11:38 AM · Restricted Project

Mar 21 2019

alex added a project to D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation: Restricted Project.
Mar 21 2019, 4:58 AM · Restricted Project
alex requested review of D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Mar 21 2019, 4:58 AM · Restricted Project

Jan 23 2019

alex accepted D270: INP-1654 Handle resource type in System Log.
Jan 23 2019, 6:16 AM

Jan 11 2019

alex accepted D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 10:21 AM · Restricted Project
alex requested changes to D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.

I've found one use case, that wasn't covered by initial plan.

Jan 11 2019, 8:29 AM · Restricted Project

Dec 20 2018

alex accepted D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 20 2018, 2:58 AM · Restricted Project
alex updated the test plan for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 20 2018, 2:57 AM · Restricted Project

Dec 19 2018

alex requested changes to D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 9:33 AM · Restricted Project
alex requested changes to D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 3:50 AM · Restricted Project

Dec 9 2018

alex added "INP-1758" JIRA issue(s) to rINP16637: Fixes INP-1758 - Support PHP_CodeSniffer 3.x.
Dec 9 2018, 6:35 AM
alex committed rINP16637: Fixes INP-1758 - Support PHP_CodeSniffer 3.x.
Fixes INP-1758 - Support PHP_CodeSniffer 3.x
Dec 9 2018, 6:35 AM

Nov 15 2018

alex updated the test plan for D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 15 2018, 2:06 PM · Restricted Project
alex requested review of D354: INP-1756 - Create "Security*" classes for security-related jobs.
  1. Installation is possible only with PHP v.7 because of "random_int" function, used in added code.
Nov 15 2018, 2:05 PM · Restricted Project
alex updated the test plan for D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 15 2018, 9:36 AM · Restricted Project
alex created D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 15 2018, 9:33 AM · Restricted Project

Nov 13 2018

alex accepted D351: INP-1750 - Support PHP Memcached extension for caching.
Nov 13 2018, 8:36 AM · Restricted Project
alex updated the test plan for D351: INP-1750 - Support PHP Memcached extension for caching.
Nov 13 2018, 8:31 AM · Restricted Project
alex updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Removed test file.

Nov 13 2018, 8:03 AM · Restricted Project
alex updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Fixed API difference causing a notice (and non-working cache), when attempting to get several keys at once using get method.

Nov 13 2018, 8:01 AM · Restricted Project
alex added "INP-1744" JIRA issue(s) to rTSIM16636: Bug INP-1744 - Make page content blocks searcheable.
Nov 13 2018, 3:38 AM
alex committed rTSIM16636: Bug INP-1744 - Make page content blocks searcheable.
Bug INP-1744 - Make page content blocks searcheable
Nov 13 2018, 3:38 AM
alex added "INP-1744" JIRA issue(s) to rTDEF16635: Bug INP-1744 - Make page content blocks searcheable.
Nov 13 2018, 3:38 AM
alex committed rTDEF16635: Bug INP-1744 - Make page content blocks searcheable.
Bug INP-1744 - Make page content blocks searcheable
Nov 13 2018, 3:38 AM
alex committed rINP16634: Fixes INP-1744 - Make page content blocks searcheable.
Fixes INP-1744 - Make page content blocks searcheable
Nov 13 2018, 3:38 AM
alex added "INP-1744" JIRA issue(s) to rINP16634: Fixes INP-1744 - Make page content blocks searcheable.
Nov 13 2018, 3:38 AM
alex closed D343: INP-1744 Make page content blocks searcheable by committing rINP16634: Fixes INP-1744 - Make page content blocks searcheable.
Nov 13 2018, 3:38 AM · Unknown Object (Project)
alex accepted D343: INP-1744 Make page content blocks searcheable.
Nov 13 2018, 3:23 AM · Unknown Object (Project)
alex updated the test plan for D343: INP-1744 Make page content blocks searcheable.
Nov 13 2018, 3:23 AM · Unknown Object (Project)

Nov 12 2018

alex added a comment to D340: INP-1741 - Vertically align grid icons.
In D340#7001, @erik wrote:
  1. When testing, I tried to add more rows to "Regional" grid, and, after 5-6 rows added by standard in-portal grid interface, i got errors.
Nov 12 2018, 6:01 AM · Restricted Project
alex requested review of D340: INP-1741 - Vertically align grid icons.

This must be perception issue with that specific icon and fact, that it has own transparent margins that aren't aligned. Below I've attached 2 images to demonstrate the issue:

Nov 12 2018, 5:58 AM · Restricted Project
alex updated the test plan for D340: INP-1741 - Vertically align grid icons.
Nov 12 2018, 5:54 AM · Restricted Project
alex updated the diff for D343: INP-1744 Make page content blocks searcheable.
  1. Updated demo data of "default" and "simple" themes to make them searchable immediately after installation.
  2. Improved trimming logic, when combining content block data to end up in less trailing spaces.
  3. Fixed notice during search about missing PageContent field of categories.
Nov 12 2018, 3:49 AM · Unknown Object (Project)
alex added a project to D343: INP-1744 Make page content blocks searcheable: Unknown Object (Project).
Nov 12 2018, 3:41 AM · Unknown Object (Project)
alex updated the test plan for D343: INP-1744 Make page content blocks searcheable.
Nov 12 2018, 3:38 AM · Unknown Object (Project)

Nov 9 2018

alex requested changes to D353: INP-1755 Make images in Admin Console Retina-friendly.
Nov 9 2018, 4:16 AM
alex requested review of D340: INP-1741 - Vertically align grid icons.
Nov 9 2018, 4:07 AM · Restricted Project
alex updated the diff for D340: INP-1741 - Vertically align grid icons.

Fixed Firefox icon alignment issues on large (>10 rows) grids

Nov 9 2018, 4:06 AM · Restricted Project

Nov 8 2018

alex added a comment to D351: INP-1750 - Support PHP Memcached extension for caching.

Not reopening, but test plan have issues:

Nov 8 2018, 5:08 AM · Restricted Project
alex requested changes to D351: INP-1750 - Support PHP Memcached extension for caching.
In D351#6952, @alex wrote:

Test plan requested updates:

  • cover auto-usage of Memcached on PHP 7+, when Memcache is configured to be used
  • cover usage of new caching backend (all public methods via corresponding kApplication facade methods (e.g. MemcachedCacheHandler::add maps to kApplication::addCache and so on)

    I'm not able to test any further, because all data set to cache will auto-expire immediately.
Nov 8 2018, 1:45 AM · Restricted Project

Nov 7 2018

alex updated the test plan for D351: INP-1750 - Support PHP Memcached extension for caching.
Nov 7 2018, 7:11 AM · Restricted Project

Nov 1 2018

alex requested changes to D351: INP-1750 - Support PHP Memcached extension for caching.

Test plan requested updates:

Nov 1 2018, 6:39 AM · Restricted Project
alex added a project to D351: INP-1750 - Support PHP Memcached extension for caching: Restricted Project.
Nov 1 2018, 6:20 AM · Restricted Project
alex accepted D348: MINC-195 Don't use "break" during shipping quote aggregation.
Nov 1 2018, 4:06 AM · Restricted Project
alex updated the test plan for D348: MINC-195 Don't use "break" during shipping quote aggregation.
Nov 1 2018, 3:53 AM · Restricted Project
alex added "INP-1721" JIRA issue(s) to rINP16633: Fixes INP-1721 - Correct math for detecting allowed file size during upload.
Nov 1 2018, 3:51 AM
alex committed rINP16633: Fixes INP-1721 - Correct math for detecting allowed file size during upload.
Fixes INP-1721 - Correct math for detecting allowed file size during upload
Nov 1 2018, 3:51 AM
alex closed D349: INP-1721 Correct math for detecting allowed file size during upload by committing rINP16633: Fixes INP-1721 - Correct math for detecting allowed file size during upload.
Nov 1 2018, 3:51 AM
alex added a project to D348: MINC-195 Don't use "break" during shipping quote aggregation: Restricted Project.
Nov 1 2018, 3:40 AM · Restricted Project
alex updated the summary of D348: MINC-195 Don't use "break" during shipping quote aggregation.
Nov 1 2018, 3:40 AM · Restricted Project

Oct 30 2018

alex added a project to D350: INP-1751 - Use PHP5-style constructor names only in LibChart library code: Restricted Project.
Oct 30 2018, 11:05 AM · Restricted Project
alex added a project to D352: INP-1752 - Update sub-class method signatures to match overridden methods in parent class: Restricted Project.
Oct 30 2018, 11:04 AM · Restricted Project
alex created D352: INP-1752 - Update sub-class method signatures to match overridden methods in parent class.
Oct 30 2018, 11:04 AM · Restricted Project

Oct 29 2018

alex created D350: INP-1751 - Use PHP5-style constructor names only in LibChart library code.
Oct 29 2018, 8:32 AM · Restricted Project

Oct 26 2018

alex requested changes to D343: INP-1744 Make page content blocks searcheable.

No matter how I try to follow test plan I'm get getting pages used in test:

Oct 26 2018, 8:44 AM · Unknown Object (Project)
alex updated the test plan for D343: INP-1744 Make page content blocks searcheable.
Oct 26 2018, 8:25 AM · Unknown Object (Project)
alex requested changes to D343: INP-1744 Make page content blocks searcheable.

Test plan not updated to cover searching through large amount of text.

Oct 26 2018, 7:54 AM · Unknown Object (Project)
alex requested changes to D348: MINC-195 Don't use "break" during shipping quote aggregation.

You're only testing new code, but existing code isn't tested. The test plan should also cover, that shipping limitations are applied correctly.

Oct 26 2018, 4:21 AM · Restricted Project
alex accepted D349: INP-1721 Correct math for detecting allowed file size during upload.
Oct 26 2018, 4:19 AM
alex updated the test plan for D349: INP-1721 Correct math for detecting allowed file size during upload.
Oct 26 2018, 4:06 AM
alex updated the test plan for D349: INP-1721 Correct math for detecting allowed file size during upload.
Oct 26 2018, 3:58 AM

Oct 25 2018

alex added a comment to D349: INP-1721 Correct math for detecting allowed file size during upload.

Also the test plan doesn't cover a glimpse of what's actually being checked in code. To test what you've done you need to manually change values of corresponding setting via ini_set (to cover each if/else created) before calling new code from startup.php to assert that result is desired number of bytes.

Oct 25 2018, 8:28 AM
alex requested changes to D349: INP-1721 Correct math for detecting allowed file size during upload.
Oct 25 2018, 8:27 AM
alex added a comment to D343: INP-1744 Make page content blocks searcheable.

Also update test plan to cover cases, when we're searching last word in large text (more then 65 KB).

Oct 25 2018, 3:48 AM · Unknown Object (Project)
alex requested changes to D343: INP-1744 Make page content blocks searcheable.
Oct 25 2018, 3:47 AM · Unknown Object (Project)

Sep 27 2018

alex added a comment to D243: INP-1571 Form field validation should account for array-like field values.
In D243#6845, @erik wrote:

No strlen error in debugger from changed ValidateRange method. 'FirstName' test value detected as invalid in other validation method (ValidateType) and not passed to ValidateRange method.

Sep 27 2018, 7:20 AM
alex requested changes to D243: INP-1571 Form field validation should account for array-like field values.
Sep 27 2018, 5:10 AM
alex updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Sep 27 2018, 3:51 AM

Sep 21 2018

alex updated the test plan for D269: INP-1645 - Create categories during theme scan based on their location in SMS.
Sep 21 2018, 2:57 AM
alex added inline comments to D346: INP-1746 Correct time parsing in date range filter.
Sep 21 2018, 2:48 AM · Restricted Project
alex requested changes to D346: INP-1746 Correct time parsing in date range filter.
Sep 21 2018, 2:39 AM · Restricted Project

Sep 19 2018

alex added a project to D347: INP-1749 - Load all content blocks of a page with a single database query: Restricted Project.
Sep 19 2018, 4:52 AM · Restricted Project
alex created D347: INP-1749 - Load all content blocks of a page with a single database query.
Sep 19 2018, 4:52 AM · Restricted Project
alex added a comment to D346: INP-1746 Correct time parsing in date range filter.

The inline comments with NOTE: battle against malformed dates entered by user line above them are actually UX discovered issues, that weren't part of original task, but without fixing them user would be as confused as now thinking that date entered in incorrect format is actually working as filter, when it's not.

Sep 19 2018, 3:19 AM · Restricted Project
alex requested changes to D346: INP-1746 Correct time parsing in date range filter.
Sep 19 2018, 3:18 AM · Restricted Project
alex added a project to D346: INP-1746 Correct time parsing in date range filter: Restricted Project.
Sep 19 2018, 2:09 AM · Restricted Project

Sep 12 2018

alex added a project to D345: INP-1748 - Follow location, when generating static version of Maintenance Page: Restricted Project.
Sep 12 2018, 7:39 AM · Restricted Project
alex updated the test plan for D345: INP-1748 - Follow location, when generating static version of Maintenance Page.
Sep 12 2018, 7:38 AM · Restricted Project
alex created D345: INP-1748 - Follow location, when generating static version of Maintenance Page.
Sep 12 2018, 7:37 AM · Restricted Project

May 16 2018

alex accepted D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 9:10 AM
alex updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 9:09 AM
alex updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 8:48 AM
alex requested changes to D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 7:59 AM

May 15 2018

alex requested changes to D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.

Please also separate test plan into smaller fragments to ease testing. One test plan per each In-Portal module would be great.

May 15 2018, 11:45 AM

Apr 30 2018

alex added a comment to D337: INP-1738 - Apply CKEditor style changes in portable form.

After discussing with reviewer figured out, that test plan needs to be changed to test, that correct Styles dropdown works in all themes and not advanced theme only.

Apr 30 2018, 7:28 AM · Restricted Project

Apr 26 2018

alex updated the test plan for D342: INP-1742 Apply "ItemType" filter in JOIN to Search Results table.
Apr 26 2018, 11:10 AM · Restricted Project
alex added inline comments to D342: INP-1742 Apply "ItemType" filter in JOIN to Search Results table.
Apr 26 2018, 9:22 AM · Restricted Project
alex added a project to D342: INP-1742 Apply "ItemType" filter in JOIN to Search Results table: Restricted Project.
Apr 26 2018, 9:20 AM · Restricted Project

Apr 25 2018

alex added a project to D341: INP-1743 - Don't use "JOIN" in "ListSQLs" property of unit configs: Restricted Project.
Apr 25 2018, 9:34 AM · Restricted Project
alex created D341: INP-1743 - Don't use "JOIN" in "ListSQLs" property of unit configs.
Apr 25 2018, 9:34 AM · Restricted Project

Apr 23 2018

alex accepted D129: INP-1476 - Allow to customize "st_AdminEditButton" tag.
Apr 23 2018, 2:33 AM · Restricted Project
alex updated the test plan for D129: INP-1476 - Allow to customize "st_AdminEditButton" tag.
Apr 23 2018, 2:33 AM · Restricted Project

Apr 20 2018

alex planned changes to D340: INP-1741 - Vertically align grid icons.

In Firefox checkbox table cell height is slightly larger (by 0.23 px) then data row height resulting in visible vertical checkbox column offset for grids with 10+ rows. Needs to be addressed via CSS somehow.

Apr 20 2018, 2:45 AM · Restricted Project

Apr 19 2018

alex added a project to D340: INP-1741 - Vertically align grid icons: Restricted Project.
Apr 19 2018, 4:43 AM · Restricted Project
alex created D340: INP-1741 - Vertically align grid icons.
Apr 19 2018, 4:42 AM · Restricted Project

Apr 18 2018

alex added a project to D339: INP-1740 - Make CKEditor URL preview respect "SEO URL Ending": Restricted Project.
Apr 18 2018, 8:17 AM · Restricted Project
alex created D339: INP-1740 - Make CKEditor URL preview respect "SEO URL Ending".
Apr 18 2018, 8:17 AM · Restricted Project
alex added a parent revision for D338: INP-1739 - Cache results of "\fckFCKHelper::getStyles" method: D251: INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS.
Apr 18 2018, 6:12 AM
alex added a child revision for D251: INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS: D338: INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.
Apr 18 2018, 6:12 AM · Restricted Project
alex created D338: INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.
Apr 18 2018, 6:12 AM