In D529#10934, @erik wrote:

Added tests for Core and Custom modules -

unknown_option_tests_v2.patch72 KBDownload

Added tests for "core" and "custom" modules.

Reclassified some tests from Unit to Functional.

Renamed the "kOptionsFormatter" class test for Phabricator to be able to generate coverage report from it.

Found these problems and fixed them (related to tests in the patch):

Added more unit tests (original version created by Erik).

1. I've noticed, that the same issue happens also with coupi and api units of the In-Commerce. Please expand the Differential Revision code/test plan to cover them as well.
2. I've noticed, that you're testing, that notice is gone, but not testing that item adding code still works. Please test that as well.
3. I've also renamed the task. Please rename your changelist in the PhpStorm to avoid accidental Differential Revision rename on patch update.

In D529#10861, @erik wrote:

I do not understand relation between test plan and proposed automation logic.

1. As I understand from test plan, not only required fields should be tested, but fields with specific formatter.
2. As I understand from test plan, should test not only create, but also update.
3. Each unit may be specific, may have dependencies to another units, so proposed automation logic seems is not helpful.

In D529#10843, @erik wrote:

Made partial testing. In the u and addr units, on State field Detected unknown_option validation error. As discussed in Zoom, started writing code for automated unit test to check create/update all units with kOptionsFormatter.

In D531#10825, @erik wrote:

Part 3 - "confirm that the Select Module Root Section system setting value was properly saved" - It's not properly saved. After "Save" button pressed, page reloads and returns old Home → Products value.

Corrected the length of the UserSessionLogs.IP during clean install.

In D528#10766, @erik wrote:

After clean install:

2.1 kUtilTest::testNetMatch test, 2 tests failed

name: www.in-portal.org; actual: 69.27.40.110
This test printed output: name: www.in-portal.org; actual: 69.27.40.110

name: www.yahoo.com; actual: 188.125.94.204
This test printed output: name: www.yahoo.com; actual: 188.125.94.204

Added missing phrase.

Use www.in-portal.org domain for testing instead of www.google.com to avoid Anycast DNS issues (random IP address returned on each DNS query).

Added missing la_fld_ExtraHTTPHeaders phrase.

I've added # (new) apply the patch from the D524, unless it's already committed line, that should fix the problem. Please retest.

2.2 - this part of test plan is excessive

Added code to support changes from the D466.

1. resubmit from the 5.3.x branch, because an associated Jira task is for the 5.3.x branch as well.
2. (test plan only tests 50% of changed code) improve test plan by checking, that request header logging still works, when HttpQuery is present

In D519#10607, @erik wrote:

Part 2 - "confirm, that you're seeing an Admin Console" - no, adding test code to OnLogin prevents from login to the adm.console.