Please resubmit patch against 5.2.x. I've changed my mind against target version of this change.
- Queries
- All Stories
- Search
- Advanced Search
Feed All Stories
All Stories
All Stories
Jul 13 2016
Jul 13 2016
Jul 13 2016, 3:39 AM · Restricted Project
alex added a parent revision for D120: INP-1470 - Google Sitemap support: D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Jul 13 2016, 3:06 AM · Restricted Project
alex added a child revision for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class: D120: INP-1470 - Google Sitemap support.
Jul 13 2016, 3:06 AM · Restricted Project
Jul 12 2016
Jul 12 2016
ci added a comment to rINP16363: Fixes INP-1528 - When attaching file to e-mail verify, that it's a file, not a….
Build #61 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/61/
alex committed rMINC16366: Fixes MINC-138 - On user login/registration update Order user via "OrdersItem"….
Fixes MINC-138 - On user login/registration update Order user via…
alex closed D183: MINC-138 - Update Order user via "OrdersItem" object on the user login/registration page by committing rMINC16366: Fixes MINC-138 - On user login/registration update Order user via "OrdersItem"….
Jul 12 2016, 3:00 AM · Restricted Project
alex committed rMINC16365: Fixes MINC-140 - Assign last order to user registered after checkout process.
Fixes MINC-140 - Assign last order to user registered after checkout process
alex closed D184: MINC-140 - Assign last order to user registered after checkout process by committing rMINC16365: Fixes MINC-140 - Assign last order to user registered after checkout process.
Jul 12 2016, 2:57 AM · Restricted Project
ci added a comment to rINP16359: Fixes INP-1530 - The "Image" tag must set DataExists flag for Template Parser.
Build #60 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/60/
Fixes MINC-143 - Use table aliases in "ord" unit calculated fields
alex closed D187: MINC-143 - Use table aliases in "ord" unit calculated fields by committing rMINC16364: Fixes MINC-143 - Use table aliases in "ord" unit calculated fields.
Jul 12 2016, 2:54 AM · Restricted Project
alex committed rINP16363: Fixes INP-1528 - When attaching file to e-mail verify, that it's a file, not a….
Fixes INP-1528 - When attaching file to e-mail verify, that it's a file, not…
alex closed D190: INP-1528 - When attaching file to e-mail verify, that it's a file, not a directory by committing rINP16363: Fixes INP-1528 - When attaching file to e-mail verify, that it's a file, not a….
Jul 12 2016, 2:52 AM · Restricted Project
Fixes INP-1529 - Don't attach same file twice to same e-mail
alex closed D191: INP-1529 - Don't attach same file twice to same e-mail by committing rINP16362: Fixes INP-1529 - Don't attach same file twice to same e-mail.
Jul 12 2016, 2:49 AM · Restricted Project
Fixes MINC-145 - Modernize "orditems:LinkRemoveFromCart" tag
alex closed D192: MINC-145 - Modernize "orditems:LinkRemoveFromCart" tag by committing rMINC16361: Fixes MINC-145 - Modernize "orditems:LinkRemoveFromCart" tag.
Jul 12 2016, 2:47 AM · Restricted Project
ci added a comment to rINP16357: Fixes INP-1535 - Escape referrer displayed during redirect debugging.
Build #59 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/59/
Fixes MINC-146 - Modernize "orditems:RemoveCouponLink" tag
alex closed D193: MINC-146 - Modernize "orditems:RemoveCouponLink" tag by committing rMINC16360: Fixes MINC-146 - Modernize "orditems:RemoveCouponLink" tag.
Jul 12 2016, 2:45 AM · Restricted Project
alex committed rINP16359: Fixes INP-1530 - The "Image" tag must set DataExists flag for Template Parser.
Fixes INP-1530 - The "Image" tag must set DataExists flag for Template Parser
alex closed D194: INP-1530 - The "Image" tag must set DataExists flag for Template Parser by committing rINP16359: Fixes INP-1530 - The "Image" tag must set DataExists flag for Template Parser.
Jul 12 2016, 2:41 AM · Restricted Project
Fixes INP-1533 - Use "EXTR_SKIP" with "extract" function
ci added a comment to rINP16355: Fixes INP-1537 - The CS fix for "kUtil::array_merge_recursive" method.
Build #58 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/58/
Fixes INP-1535 - Escape referrer displayed during redirect debugging
alex committed rINP16356: Fixes INP-1536 - Escape url for JavaScript context during JavaScript made….
Fixes INP-1536 - Escape url for JavaScript context during JavaScript made…
Fixes INP-1537 - The CS fix for "kUtil::array_merge_recursive" method
Jul 11 2016
Jul 11 2016
- Can't "confirm, that redirect to thank you page happened", as written in test plan. When not logged in front-end user performs "Place Order" operation, happens redirect to registration page, not to thank you page.
- Can't "confirm, that redirect to thank you page happened", as written in test plan. When not logged in front-end user performs "Place Order" operation, happens redirect to registration page, not to thank you page.
- Seems, test plan is incomplete - last line (press Ship toolbar button) requests test action, but no confirmation line following.
- Performing that "press Ship toolbar button" results in "mail error: header To is required" exception - http://screencast.com/t/ahSVogRnph6
Jul 10 2016
Jul 10 2016
Build #57 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/57/
ci added a comment to rINP16350: Fixes INP-1546 - Make "user-profile:Field" tag support fields of any type.
Build #56 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/56/
Fixes INP-1538 - Enable Mod-Rewrite by default
Fixes INP-1543 - Return detected theme/language ID immediately from…
Fixes INP-1544 - Delete expired session without using "Session" object
Build #55 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/55/
alex committed rMINB16351: Fixes MINB-25 - Declare forum user preferences in the "user-profile" unit.
Fixes MINB-25 - Declare forum user preferences in the "user-profile" unit
alex committed rINP16350: Fixes INP-1546 - Make "user-profile:Field" tag support fields of any type.
Fixes INP-1546 - Make "user-profile:Field" tag support fields of any type
Fixes MINB-26 - Don't persist data for anonymous users
Fixes INP-1563 - Make "kApplication::QuickRun" method reusable
alex retitled D234: INP-1570 - Make In-Portal Class Locator externally usable from to INP-1570 - Make In-Portal Class Locator externally usable.
Jul 8 2016
Jul 8 2016
Fixing CS issues in added lines.
alex retitled D233: MINC-176 - Register missing classes in class factory from to MINC-176 - Register missing classes in class factory.
Jul 6 2016
Jul 6 2016
alex updated the test plan for D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.
Jul 5 2016
Jul 5 2016
alex updated the test plan for D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.
alex retitled D232: INP-1566 - Don't log errors from 3rd party libraries to System Log from to INP-1566 - Don't log errors from 3rd party libraries to System Log.
Removed CS fixes, added condition for DBType update.
Jul 4 2016
Jul 4 2016
erik retitled D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade from to INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.
Jun 30 2016
Jun 30 2016
Jun 23 2016
Jun 23 2016
glebs updated the test plan for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Jun 22 2016
Jun 22 2016
Jun 21 2016
Jun 21 2016
alex retitled D230: INP-1567 - Register missing classes in class factory from to INP-1567 - Register missing classes in class factory.
Jun 20 2016
Jun 20 2016
Need to finalize test plan.
alex edited reviewers for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI, added: erik; removed: glebs.
alex edited reviewers for D225: INP-1563 - Make "kApplication::QuickRun" method reusable, added: erik; removed: glebs.
alex edited reviewers for D146: INP-1494 - Create "phing:run" console command, added: erik; removed: glebs.
Done - test plan improved.
Jun 17 2016
Jun 17 2016
alex requested changes to D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Alex, sorry, but I haven't understood what these cases mean
glebs updated the diff for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Requested changes
glebs added a comment to D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
- list wasn't counted prior to new method being called, but more records than fits on per page were selected
- list wasn't counted prior to new method being called, but per page is -1
glebs updated the test plan for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
glebs updated the test plan for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Requested changes
Jun 16 2016
Jun 16 2016
Jun 15 2016
Jun 15 2016
And test plan still doesn't cover direct method usage of DateHelper class.
alex requested changes to D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
And test is incomplete.
glebs updated the test plan for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
glebs updated the diff for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
- Always call Query in kDBList::GetSelectedCount()
- Moved to 5.3 branch
Requested changes
Jun 14 2016
Jun 14 2016
Also test plan doesn't reflect addition of new method.
Requested changes
- make changes specified below to transform code into more reusable state
- test plan needs to be updated to cover not only indirect DateHelper::getHumanTime method usage, but also it's direct usage
Jun 13 2016
Jun 13 2016
glebs retitled D229: INP-1565 Add support for "relative" date format from to INP-1565 Add support for "relative" date format.