Page MenuHomeIn-Portal Phabricator
Feed All Stories

Tue, Dec 23

alex added a comment to D551: INP-1932 - Unify code for converting absolute into relative paths.
In D551#11308, @erik wrote:

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

convertPathToRelative is called to convert each element in the $params array, however only "default" parameter contains file path. There are made excessive convertPathToRelative calls for some parameters (quality, output_format, etc.)

Tue, Dec 23, 6:28 AM
erik accepted D553: INP-1934 - Improve template compilation error reportring.
Tue, Dec 23, 5:40 AM
erik reopened D551: INP-1932 - Unify code for converting absolute into relative paths.

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

Tue, Dec 23, 5:33 AM
erik accepted D552: INP-1933 - Report Compiled Template removal errors.
Tue, Dec 23, 4:14 AM

Mon, Dec 22

erik requested changes to D546: INP-1930 - Add Command-Line Template Compilation Support.

After clean install
Part 4.9 - confirm that you'll see an error message above the system settings list indicating which folders weren't deleted as part of the system setting change. - There appears only "Please manually delete paths:" message. No folder names are present in the message.

Mon, Dec 22, 4:55 AM

Sat, Dec 20

alex added a child revision for D551: INP-1932 - Unify code for converting absolute into relative paths: D553: INP-1934 - Improve template compilation error reportring.
Sat, Dec 20, 1:04 PM
alex added a parent revision for D553: INP-1934 - Improve template compilation error reportring: D551: INP-1932 - Unify code for converting absolute into relative paths.
Sat, Dec 20, 1:04 PM
alex requested review of D553: INP-1934 - Improve template compilation error reportring.
Sat, Dec 20, 1:04 PM
alex requested review of D546: INP-1930 - Add Command-Line Template Compilation Support.
Sat, Dec 20, 12:43 PM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Sat, Dec 20, 12:43 PM
alex updated the diff for D546: INP-1930 - Add Command-Line Template Compilation Support.

Restored chages in the TemplatesCache class, that were accidentally removed.

Sat, Dec 20, 6:19 AM
alex updated the diff for D546: INP-1930 - Add Command-Line Template Compilation Support.

Corrected permissions on the system folder itself. Report indirect compiled template removal as part of system setting change.

Sat, Dec 20, 6:17 AM