Page MenuHomeIn-Portal Phabricator
Feed All Stories

Fri, May 30

erik accepted D525: INP-1913 - Allow sending custom HTTP headers.
Fri, May 30, 7:51 AM
alex updated the diff for D525: INP-1913 - Allow sending custom HTTP headers.

Added missing la_fld_ExtraHTTPHeaders phrase.

Fri, May 30, 7:12 AM
erik requested changes to D525: INP-1913 - Allow sending custom HTTP headers.

All test plan passed.

Fri, May 30, 7:07 AM
alex updated the test plan for D525: INP-1913 - Allow sending custom HTTP headers.
Fri, May 30, 5:44 AM
alex requested review of D525: INP-1913 - Allow sending custom HTTP headers.
Fri, May 30, 5:42 AM

Tue, May 27

alex added "INP-1912" JIRA issue(s) to rINP16830: Fixes INP-1912 - Show "404 Page Not Found" page on the Front-End for….
Tue, May 27, 8:26 AM
alex committed rINP16830: Fixes INP-1912 - Show "404 Page Not Found" page on the Front-End for….
Fixes INP-1912 - Show "404 Page Not Found" page on the Front-End for…
Tue, May 27, 8:25 AM
alex closed D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
Tue, May 27, 8:25 AM
alex added "INP-1857" JIRA issue(s) to rINP16829: Bug INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Tue, May 27, 8:23 AM
alex committed rINP16829: Bug INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Bug INP-1857 - Prevent recursion in the "\kUrlManager::show404" method
Tue, May 27, 8:23 AM
alex closed D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Tue, May 27, 8:23 AM
erik accepted D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Tue, May 27, 6:00 AM
erik accepted D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
Tue, May 27, 5:51 AM
alex requested review of D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.

I've added # (new) apply the patch from the D524, unless it's already committed line, that should fix the problem. Please retest.

Tue, May 27, 4:44 AM
alex updated the test plan for D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
Tue, May 27, 4:43 AM
alex added a parent revision for D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method: D462: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Tue, May 27, 4:32 AM
alex added a child revision for D462: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method: D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Tue, May 27, 4:32 AM · Restricted Project
alex requested review of D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Tue, May 27, 4:32 AM

Mon, May 26

alex added a comment to D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.

2.2 - this part of test plan is excessive

Mon, May 26, 12:36 PM
alex updated the test plan for D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
Mon, May 26, 12:11 PM
erik requested changes to D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.

2.2 - this part of test plan is excessive
2.3 - Failed all front-end tests. Always shown Oops, something went wrong text, not 404 page. Always System Log IS created about incident

Mon, May 26, 11:05 AM
alex added a parent revision for D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events: D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit.
Mon, May 26, 10:34 AM
alex added a child revision for D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit: D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
Mon, May 26, 10:34 AM
alex requested review of D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
Mon, May 26, 10:33 AM
alex added "INP-1911" JIRA issue(s) to rINP16828: Fixes INP-1911 - Adjust exception message, when accessing non-existing event of….
Mon, May 26, 10:21 AM
alex committed rINP16828: Fixes INP-1911 - Adjust exception message, when accessing non-existing event of….
Fixes INP-1911 - Adjust exception message, when accessing non-existing event of…
Mon, May 26, 10:21 AM
alex closed D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit.
Mon, May 26, 10:21 AM
erik accepted D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit.
Mon, May 26, 10:10 AM
alex requested review of D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit.
Mon, May 26, 9:50 AM
erik accepted D521: INP-1910 - Allow specifying upcoming System Log record defaults.
Mon, May 26, 9:12 AM

Sat, May 24

alex updated the test plan for D521: INP-1910 - Allow specifying upcoming System Log record defaults.
Sat, May 24, 9:45 AM
alex updated the diff for D521: INP-1910 - Allow specifying upcoming System Log record defaults.

Added code to support changes from the D466.

Sat, May 24, 9:31 AM
alex added a parent revision for D521: INP-1910 - Allow specifying upcoming System Log record defaults: D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log.
Sat, May 24, 9:24 AM
alex added a child revision for D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log: D521: INP-1910 - Allow specifying upcoming System Log record defaults.
Sat, May 24, 9:24 AM
alex requested review of D521: INP-1910 - Allow specifying upcoming System Log record defaults.
Sat, May 24, 9:17 AM

Tue, May 20

alex retitled D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installation from INP-1902 Populate the "SessionCookieDomains" system setting upon installationI to INP-1902 Populate the "SessionCookieDomains" system setting upon installation.
Tue, May 20, 3:53 AM

May 2 2025

erik accepted D505: INP-1894 - Extract "Change Log" code to a central place.
May 2 2025, 11:44 AM
erik accepted D514: INP-1822 - Use modern cookie encryption library.
May 2 2025, 11:40 AM

Apr 30 2025

erik updated the test plan for D520: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Apr 30 2025, 6:09 AM
erik requested review of D520: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Apr 30 2025, 6:09 AM
alex requested changes to D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
  1. resubmit from the 5.3.x branch, because an associated Jira task is for the 5.3.x branch as well.
  2. (test plan only tests 50% of changed code) improve test plan by checking, that request header logging still works, when HttpQuery is present
Apr 30 2025, 4:30 AM

Apr 29 2025

alex accepted D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Apr 29 2025, 8:03 AM
alex updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Apr 29 2025, 8:00 AM
erik accepted D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Apr 29 2025, 8:00 AM
alex requested review of D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
In D519#10607, @erik wrote:

Part 2 - "confirm, that you're seeing an Admin Console" - no, adding test code to OnLogin prevents from login to the adm.console.

Apr 29 2025, 7:43 AM
alex updated the test plan for D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Apr 29 2025, 7:42 AM

Apr 25 2025

erik updated the diff for D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installation.

Boyscout improvements in session.php

Apr 25 2025, 11:31 AM

Apr 16 2025

erik requested changes to D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.

Part 2 - "confirm, that you're seeing an Admin Console" - no, adding test code to OnLogin prevents from login to the adm.console.
Part 3 - "replace the tab URL with the provided URL (text after #redirect#)" - seems, missing some action and/or confirmation after this step ot the test plan

Apr 16 2025, 5:29 AM

Apr 15 2025

alex updated the test plan for D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Apr 15 2025, 11:14 AM
alex requested review of D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Apr 15 2025, 11:07 AM
alex added "INP-1906" JIRA issue(s) to rINP16827: Fixes INP-1906 - Execute "customProcessing" method in the "OnDelete" and….
Apr 15 2025, 3:59 AM
alex committed rINP16827: Fixes INP-1906 - Execute "customProcessing" method in the "OnDelete" and….
Fixes INP-1906 - Execute "customProcessing" method in the "OnDelete" and…
Apr 15 2025, 3:59 AM
alex closed D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 15 2025, 3:58 AM
alex updated the diff for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.

Applying the Boyscout Rule principe.

Apr 15 2025, 3:16 AM
alex accepted D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 15 2025, 3:12 AM

Apr 10 2025

alex committed rINP16826: Bug INP-1725 - Introduce secure Session Key generation/storage.
Bug INP-1725 - Introduce secure Session Key generation/storage
Apr 10 2025, 12:55 AM
alex added "INP-1725" JIRA issue(s) to rINP16826: Bug INP-1725 - Introduce secure Session Key generation/storage.
Apr 10 2025, 12:55 AM
alex added "INP-1725" JIRA issue(s) to rINP16825: Bug INP-1725 - Introduce secure Session Key generation/storage.
Apr 10 2025, 12:51 AM
alex committed rINP16825: Bug INP-1725 - Introduce secure Session Key generation/storage.
Bug INP-1725 - Introduce secure Session Key generation/storage
Apr 10 2025, 12:51 AM

Apr 9 2025

alex added a comment to D518: INP-1907 - Permit file uploads in any Web Browser.
In D518#10578, @erik wrote:

Today I have z-index; 0; in DIV Can't provide screenshot without -index today.

Apr 9 2025, 6:40 AM
erik added a comment to D518: INP-1907 - Permit file uploads in any Web Browser.

Today I have z-index; 0; in DIV Can't provide screenshot without -index today.

Apr 9 2025, 6:27 AM
alex updated the test plan for D518: INP-1907 - Permit file uploads in any Web Browser.
Apr 9 2025, 3:11 AM
alex added a comment to D518: INP-1907 - Permit file uploads in any Web Browser.
In D518#10573, @erik wrote:
Apr 9 2025, 3:10 AM

Apr 8 2025

erik accepted D518: INP-1907 - Permit file uploads in any Web Browser.

Part 2 - all right, so revision is accepted.

Apr 8 2025, 9:27 AM
alex updated the diff for D518: INP-1907 - Permit file uploads in any Web Browser.

Added reference to the used code origins.

Apr 8 2025, 8:18 AM
alex requested review of D518: INP-1907 - Permit file uploads in any Web Browser.
Apr 8 2025, 8:15 AM

Apr 3 2025

erik updated the diff for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.

done all requested code improvements

Apr 3 2025, 6:03 AM
erik updated the test plan for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 3 2025, 6:01 AM
alex added a comment to D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.

Update test plan to cover requested changes as well.

Apr 3 2025, 2:34 AM
alex requested changes to D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 3 2025, 2:32 AM
alex updated the test plan for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 3 2025, 2:15 AM

Apr 2 2025

erik updated the test plan for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 2 2025, 6:23 AM
erik requested review of D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 2 2025, 6:20 AM

Mar 25 2025

erik accepted D516: INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from the "OnCancelEdit" event.
Mar 25 2025, 7:57 AM
alex requested review of D516: INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from the "OnCancelEdit" event.
Mar 25 2025, 7:43 AM

Mar 13 2025

erik accepted D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 12:59 PM
erik accepted D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 13 2025, 11:48 AM
alex requested review of D513: INP-1904 - Support opening an Admin Console from a Site Domain.
In D513#10483, @erik wrote:

Part 3.1.1 login to the Admin Console by accessing it on the sd1.test.domain.com domain over http:// protocol - FAILED, after login attempt - redirect to the login page. SUCCESS after cookies deleted (beyond test plan)
Part 3.1.12 confirm, that orange buttons for editing page/content blocks are now shown - NOT STABLE. At first attempt - no orange buttons. Then I logged in from main domain, set Default theme as primary theme, checked that orange buttons shown, restored Advanced theme as primary theme, then tried again login to sd1 domain, failed, cleared cookies, login to sd1 admin - and only then orange buttons shown

Mar 13 2025, 7:30 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 13 2025, 7:28 AM
alex updated the test plan for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 7:28 AM
alex added a parent revision for D513: INP-1904 - Support opening an Admin Console from a Site Domain: D514: INP-1822 - Use modern cookie encryption library.
Mar 13 2025, 7:27 AM
alex added child revisions for D514: INP-1822 - Use modern cookie encryption library: D511: INP-1903 - Disallow opening a website on unsupported domains/protocols, D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 13 2025, 7:27 AM
alex added a parent revision for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols: D514: INP-1822 - Use modern cookie encryption library.
Mar 13 2025, 7:27 AM
alex requested review of D514: INP-1822 - Use modern cookie encryption library.
Mar 13 2025, 7:27 AM
alex requested review of D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 7:03 AM
alex updated the test plan for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 6:59 AM
alex added a comment to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
In D511#10453, @erik wrote:

Part 3.2 go to the Configuration → Website → Advanced section - FAILED, can't. login, redirects to login screen. Logged in only after all current site cookies deleted before login.

Mar 13 2025, 6:58 AM
erik requested changes to D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Part 3.1.1 login to the Admin Console by accessing it on the sd1.test.domain.com domain over http:// protocol - FAILED, after login attempt - redirect to the login page. SUCCESS after cookies deleted (beyond test plan)
Part 3.1.12 confirm, that orange buttons for editing page/content blocks are now shown - NOT STABLE. At first attempt - no orange buttons. Then I logged in from main domain, set Default theme as primary theme, checked that orange buttons shown, restored Advanced theme as primary theme, then tried again login to sd1 domain, failed, cleared cookies, login to sd1 admin - and only then orange buttons shown

Mar 13 2025, 6:14 AM
alex updated the diff for D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Added some explanatory comments.

Mar 13 2025, 4:49 AM

Mar 12 2025

alex requested review of D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 1:14 PM
alex added a comment to D513: INP-1904 - Support opening an Admin Console from a Site Domain.
In D513#10467, @erik wrote:

Part 3.1.7 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) - NO, [SD ID: ] is added. And this is right, because at Preparations 10 "add 1st site domain with: Domain Name=sd1-http.test.domain.com", not sd1.test.domain.com
Part 3.1.9 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]

Mar 12 2025, 1:14 PM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 1:12 PM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 12:27 PM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 12:02 PM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 11:39 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 11:38 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 11:26 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 10:51 AM
erik requested changes to D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Part 3.1.7 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) - NO, [SD ID: ] is added. And this is right, because at Preparations 10 "add 1st site domain with: Domain Name=sd1-http.test.domain.com", not sd1.test.domain.com
Part 3.1.9 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 3.1.12 logout - FAILED, infinite redirect to http://sd1.test.domain.com/SVN/5.3.x/admin/index.php?env=-index%3Am0--default---&expired=1 happens
Part 3.2.2 confirm that you're looking at Admin Console at the test.domain.com domain over https:// protocol - NO, I'm looking at Admin Console at the sd1.test.domain.com domain over https:// protocol
Part 3.2.3 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) = NO, [SD ID: ] is added in the current page blue bar
Part 3.2.5 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 4.2 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 4.4 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]

Mar 12 2025, 10:04 AM
alex added a parent revision for D513: INP-1904 - Support opening an Admin Console from a Site Domain: D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 12 2025, 8:35 AM