Page MenuHomeIn-Portal Phabricator
Feed All Stories

Today

erik accepted D550: INP-1931 - Color Log Level names in the System Log.
Tue, Dec 16, 1:02 PM
alex updated the test plan for D550: INP-1931 - Color Log Level names in the System Log.
Tue, Dec 16, 12:46 PM
alex updated the diff for D550: INP-1931 - Color Log Level names in the System Log.

Improve handling of log levels, that doesn't require coloring.

Tue, Dec 16, 12:43 PM
erik accepted D550: INP-1931 - Color Log Level names in the System Log.

All task-defined coloring is right.

Tue, Dec 16, 8:24 AM
alex requested review of D550: INP-1931 - Color Log Level names in the System Log.
Tue, Dec 16, 6:17 AM

Thu, Dec 11

alex updated the test plan for D549: MINC-214 - Unify total calculation for Sale Reports.
Thu, Dec 11, 6:34 AM
erik added a comment to D549: MINC-214 - Unify total calculation for Sale Reports.

"use the above-created user and products (several with different quantities)"

Thu, Dec 11, 4:57 AM
erik accepted D549: MINC-214 - Unify total calculation for Sale Reports.
Thu, Dec 11, 4:56 AM
alex updated the diff for D549: MINC-214 - Unify total calculation for Sale Reports.

Cosmetic change.

Thu, Dec 11, 4:42 AM
erik accepted D548: MINC-213 - Change architecture of the Sales Report generator.
Thu, Dec 11, 4:32 AM
alex updated the test plan for D549: MINC-214 - Unify total calculation for Sale Reports.
Thu, Dec 11, 4:10 AM
alex requested review of D549: MINC-214 - Unify total calculation for Sale Reports.
Thu, Dec 11, 4:09 AM

Wed, Dec 10

alex updated the test plan for D548: MINC-213 - Change architecture of the Sales Report generator.
Wed, Dec 10, 12:37 PM
alex updated the test plan for D548: MINC-213 - Change architecture of the Sales Report generator.
Wed, Dec 10, 12:37 PM
alex requested review of D548: MINC-213 - Change architecture of the Sales Report generator.
Wed, Dec 10, 12:35 PM
alex added "INP-1859" JIRA issue(s) to rMINC16863: Bug INP-1859 - Escape MySQL 8.3 keywords.
Wed, Dec 10, 3:12 AM
alex committed rMINC16863: Bug INP-1859 - Escape MySQL 8.3 keywords.
Bug INP-1859 - Escape MySQL 8.3 keywords
Wed, Dec 10, 3:12 AM
alex closed D547: INP-1859 - Escape MySQL 8.3 keywords.
Wed, Dec 10, 3:12 AM

Tue, Dec 9

erik accepted D547: INP-1859 - Escape MySQL 8.3 keywords.

Without this change - also no SQL error. Maybe, because no MySQL 8.x in the test system.

Tue, Dec 9, 10:20 AM
alex updated the test plan for D547: INP-1859 - Escape MySQL 8.3 keywords.
Tue, Dec 9, 9:56 AM
alex requested review of D547: INP-1859 - Escape MySQL 8.3 keywords.
Tue, Dec 9, 9:54 AM

Tue, Nov 25

erik accepted D546: INP-1930 - Add Command-Line Template Compilation Support.
Tue, Nov 25, 11:26 AM
alex requested review of D546: INP-1930 - Add Command-Line Template Compilation Support.
In D546#11169, @erik wrote:

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

after "use the Clear Templates Cache functionality"
system/cache/core/admin_templates folder is present and has drwxr-xr-x permissions, but system/cache/core/admin_templates/config folder is not present, and system/cache/core/admin_templates/config/config_universal.php file is not present.

under system/cache/core/admin_templates folder are present only incs folder and and tools folder

after "Compiled Template Permission Mode" is changed, system/cache/core/admin_templates/tools folder disappears and system/cache/core/admin_templates/config folder is created, so all other test plan checks are passed.

Tue, Nov 25, 10:53 AM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Tue, Nov 25, 10:52 AM
erik requested changes to D546: INP-1930 - Add Command-Line Template Compilation Support.

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

Tue, Nov 25, 10:19 AM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Tue, Nov 25, 5:40 AM
alex requested review of D546: INP-1930 - Add Command-Line Template Compilation Support.
Tue, Nov 25, 5:37 AM

Wed, Nov 19

erik accepted D545: INP-1929 - Increase e-mail template name size.
Wed, Nov 19, 10:34 AM
alex requested review of D545: INP-1929 - Increase e-mail template name size.
Wed, Nov 19, 8:29 AM

Nov 5 2025

alex added "INP-1928" JIRA issue(s) to rINP16862: Fixes INP-1928 - Automatic Scheduled Task creation protection.
Nov 5 2025, 7:58 AM
alex committed rINP16862: Fixes INP-1928 - Automatic Scheduled Task creation protection.
Fixes INP-1928 - Automatic Scheduled Task creation protection
Nov 5 2025, 7:58 AM
alex closed D544: INP-1928 - Automatic Scheduled Task creation protection.
Nov 5 2025, 7:58 AM

Oct 23 2025

erik accepted D544: INP-1928 - Automatic Scheduled Task creation protection.
Oct 23 2025, 10:45 AM
alex requested review of D544: INP-1928 - Automatic Scheduled Task creation protection.
Oct 23 2025, 10:31 AM

Oct 6 2025

alex added "INP-1927" JIRA issue(s) to rINP16861: Fixes INP-1927 - Support "tinyint" data type in Table Structure Generator.
Oct 6 2025, 3:42 AM
alex committed rINP16861: Fixes INP-1927 - Support "tinyint" data type in Table Structure Generator.
Fixes INP-1927 - Support "tinyint" data type in Table Structure Generator
Oct 6 2025, 3:42 AM
alex closed D543: INP-1927 Support "tinyint" data type in Table Structure Generator.
Oct 6 2025, 3:41 AM
alex accepted D543: INP-1927 Support "tinyint" data type in Table Structure Generator.
Oct 6 2025, 3:31 AM
alex updated the test plan for D543: INP-1927 Support "tinyint" data type in Table Structure Generator.
Oct 6 2025, 3:31 AM

Sep 25 2025

erik updated the test plan for D543: INP-1927 Support "tinyint" data type in Table Structure Generator.
Sep 25 2025, 12:36 PM
erik requested review of D543: INP-1927 Support "tinyint" data type in Table Structure Generator.
Sep 25 2025, 12:32 PM

Sep 4 2025

alex added "INP-1926" JIRA issue(s) to rINP16860: Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Sep 4 2025, 7:29 AM
alex committed rINP16860: Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log
Sep 4 2025, 7:29 AM
alex closed D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Sep 4 2025, 7:29 AM
erik accepted D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Sep 4 2025, 6:28 AM
alex updated the diff for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

Use "la_fld_LogServerHostname" phrases (existing) instead of "la_fld_ServerHostname" (non-existing) in the Session Log grid.

Sep 4 2025, 5:57 AM
erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

In the D539 added another phrase. Phrase la_fld_ServerHostname is detected as missing during tests.

Sep 4 2025, 5:12 AM
alex requested review of D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
In D542#11101, @erik wrote:

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Sep 4 2025, 2:24 AM
alex updated the test plan for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Sep 4 2025, 2:18 AM

Sep 3 2025

erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Sep 3 2025, 12:25 PM
alex added a parent revision for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log: D539: INP-1923 - Display "Server Hostname" in the System Log.
Sep 3 2025, 11:52 AM
alex added a child revision for D539: INP-1923 - Display "Server Hostname" in the System Log: D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Sep 3 2025, 11:52 AM
alex requested review of D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Sep 3 2025, 11:51 AM
alex committed rINP16859: Fixes INP-1923 - Display "Server Hostname" in the System Log.
Fixes INP-1923 - Display "Server Hostname" in the System Log
Sep 3 2025, 11:46 AM
alex added "INP-1923" JIRA issue(s) to rINP16859: Fixes INP-1923 - Display "Server Hostname" in the System Log.
Sep 3 2025, 11:46 AM
alex closed D539: INP-1923 - Display "Server Hostname" in the System Log.
Sep 3 2025, 11:46 AM
alex planned changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Sep 3 2025, 11:20 AM
alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Extracted Arcanist integration into a separate Differential Revision.

Sep 3 2025, 11:19 AM
alex added "INP-1924" JIRA issue(s) to rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet….
Sep 3 2025, 11:09 AM
alex committed rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet….
Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet…
Sep 3 2025, 11:09 AM
alex closed D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Sep 3 2025, 11:09 AM
alex committed rINP16857: Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"….
Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"…
Sep 3 2025, 11:03 AM
alex added "INP-1900" JIRA issue(s) to rINP16857: Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"….
Sep 3 2025, 11:03 AM
alex closed D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Sep 3 2025, 11:03 AM
erik accepted D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Sep 3 2025, 10:47 AM
alex accepted D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Sep 3 2025, 10:17 AM
alex updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Rename test file/class to make Phabricator understand PHPUnit test results/coverage.

Sep 3 2025, 10:08 AM
alex added a child revision for D540: INP-1925 - Configure PHPUnit integration with Arcanist: D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Sep 3 2025, 9:57 AM
alex added a parent revision for D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 9:57 AM
alex requested review of D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Sep 3 2025, 9:44 AM
alex committed rINP16856: Fixes INP-1925 - Configure PHPUnit integration with Arcanist.
Fixes INP-1925 - Configure PHPUnit integration with Arcanist
Sep 3 2025, 9:35 AM
alex added "INP-1925" JIRA issue(s) to rINP16856: Fixes INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 9:35 AM
alex closed D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 9:35 AM
erik accepted D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 9:28 AM
alex updated the test plan for D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 8:25 AM
alex updated the test plan for D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 8:19 AM
alex added child revisions for D540: INP-1925 - Configure PHPUnit integration with Arcanist: D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method, D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Sep 3 2025, 8:17 AM
alex added a parent revision for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 8:17 AM
alex added a parent revision for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 8:17 AM
alex requested review of D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Sep 3 2025, 8:15 AM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Replaced assertEquels with assertSame in all tests, added in this revision.

Sep 3 2025, 5:28 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Sep 3 2025, 4:14 AM

Sep 2 2025

erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Added test case when pounds and ounces both are zero.

Sep 2 2025, 9:09 AM
erik added inline comments to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Sep 2 2025, 9:05 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Sep 2 2025, 8:02 AM
erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Sep 2 2025, 7:37 AM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Made all requested fixes. Created tests for kUbitFormatter class.

Sep 2 2025, 7:33 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Also try to modify tested code to confirm, that related tests would fail.

Sep 2 2025, 5:33 AM
erik accepted D539: INP-1923 - Display "Server Hostname" in the System Log.
Sep 2 2025, 5:23 AM

Sep 1 2025

erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Sep 1 2025, 1:38 PM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Changed ligic, added unit tests.

Sep 1 2025, 1:33 PM
alex requested review of D539: INP-1923 - Display "Server Hostname" in the System Log.
Sep 1 2025, 7:05 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Let's implement this the other way around (sender does type casting, but recipient throws an exception on error on any PHP version):

Sep 1 2025, 3:46 AM

Aug 31 2025

alex added "INP-1874" JIRA issue(s) to rINP16855: Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value.
Aug 31 2025, 12:18 PM
alex committed rINP16855: Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value.
Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value
Aug 31 2025, 12:18 PM
alex added "INP-1876" JIRA issue(s) to rINP16854: Fixes INP-1876 - Verify system settings access permissions before allowing to….
Aug 31 2025, 12:15 PM
alex committed rINP16854: Fixes INP-1876 - Verify system settings access permissions before allowing to….
Fixes INP-1876 - Verify system settings access permissions before allowing to…
Aug 31 2025, 12:15 PM
alex closed D486: INP-1876 - Verify system settings access permissions before allowing to change them.
Aug 31 2025, 12:15 PM · Restricted Project
alex added "INP-1880" JIRA issue(s) to rINP16853: Fixes INP-1880 - Fix notice on missing event permission mapping.
Aug 31 2025, 12:09 PM
alex committed rINP16853: Fixes INP-1880 - Fix notice on missing event permission mapping.
Fixes INP-1880 - Fix notice on missing event permission mapping
Aug 31 2025, 12:09 PM