Page MenuHomeIn-Portal Phabricator
Feed All Stories

Today

alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Renamed the "kOptionsFormatter" class test for Phabricator to be able to generate coverage report from it.

Fri, Aug 8, 2:28 AM

Wed, Aug 6

alex added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Found these problems and fixed them (related to tests in the patch):

Wed, Aug 6, 9:21 AM
alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Added more unit tests (original version created by Erik).

Wed, Aug 6, 9:15 AM

Tue, Aug 5

erik requested changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Tested all units, additional bugs found in the In-Commerce module.

Tue, Aug 5, 12:27 PM
alex added "MINC-212" JIRA issue(s) to rMINC16840: Fixes MINC-212 - Fix notice in the "Entire Order" functionality for the….
Tue, Aug 5, 2:45 AM
alex committed rMINC16840: Fixes MINC-212 - Fix notice in the "Entire Order" functionality for the….
Fixes MINC-212 - Fix notice in the "Entire Order" functionality for the…
Tue, Aug 5, 2:45 AM
alex closed D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Tue, Aug 5, 2:45 AM

Mon, Aug 4

erik updated the test plan for D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Mon, Aug 4, 6:32 AM
erik updated the test plan for D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Mon, Aug 4, 6:29 AM
erik requested review of D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Mon, Aug 4, 6:27 AM
alex added "INP-1919" JIRA issue(s) to rINP16839: Fixes INP-1919 - Reset unit config cache after Module Root Category change.
Mon, Aug 4, 2:44 AM
alex committed rINP16839: Fixes INP-1919 - Reset unit config cache after Module Root Category change.
Fixes INP-1919 - Reset unit config cache after Module Root Category change
Mon, Aug 4, 2:44 AM
alex closed D533: INP-1919 Reset unit config cache after Module Root Category change.
Mon, Aug 4, 2:44 AM
alex accepted D533: INP-1919 Reset unit config cache after Module Root Category change.
Mon, Aug 4, 2:42 AM

Fri, Aug 1

alex requested changes to D537: MINC-211 Remove "TitleField" option for the di/coupi/api units.

I've noticed, that the same issue happens also with coupi and api units of the In-Commerce. Please expand the Differential Revision code/test plan to cover them as well.

Fri, Aug 1, 3:36 AM
alex retitled D537: MINC-211 Remove "TitleField" option for the di/coupi/api units from MINC-211 Fix discount items configuration to MINC-211 Remove "TitleField" option for the di/coupi/api units.
Fri, Aug 1, 3:31 AM

Thu, Jul 31

erik added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Partially tested (done testing for Core module part).

  1. Languages.

1.1. Broken In-Portal clean install due error in lang prefix, preventing language record creation, required in normal installation process.
1.2. Due specific option_sql configuration for PackName and LocalName fields, possible add only record with values, that already exists. So, when no records in Languages table - can't add first language record.

  1. Categories - works well in admin interface, but problematic to add through object, because of Priority field options, that are populated only in OnPreSaveCreated event hook.
  2. Change logs - sometimes can't create through object same as languages, due specific Prefix and MasterPrefix field options_sql configuration. But in system records are created by direct SQL, so this not a problem. maybe.
  3. Users - can't create and update records with US State, because state options are populated too late - after SetFieldsFromHash already set error to the State field.
Thu, Jul 31, 12:10 PM
erik updated the test plan for D537: MINC-211 Remove "TitleField" option for the di/coupi/api units.
Thu, Jul 31, 5:51 AM
erik requested review of D537: MINC-211 Remove "TitleField" option for the di/coupi/api units.
Thu, Jul 31, 5:51 AM
erik accepted D535: INP-1921 - Improve Change Log performance.
Thu, Jul 31, 5:30 AM

Wed, Jul 30

alex requested review of D535: INP-1921 - Improve Change Log performance.
Wed, Jul 30, 5:43 AM

Tue, Jul 29

alex added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
In D529#10861, @erik wrote:

I do not understand relation between test plan and proposed automation logic.

  1. As I understand from test plan, not only required fields should be tested, but fields with specific formatter.
  2. As I understand from test plan, should test not only create, but also update.
  3. Each unit may be specific, may have dependencies to another units, so proposed automation logic seems is not helpful.
Tue, Jul 29, 2:21 AM

Mon, Jul 28

erik added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

I do not understand relation between test plan and proposed automation logic.

Mon, Jul 28, 11:46 AM
alex added "INP-1920" JIRA issue(s) to rMINN16838: Bug INP-1920 - Ensure consistent named tab preset usage.
Mon, Jul 28, 7:08 AM
alex committed rMINN16838: Bug INP-1920 - Ensure consistent named tab preset usage.
Bug INP-1920 - Ensure consistent named tab preset usage
Mon, Jul 28, 7:08 AM
alex added "INP-1920" JIRA issue(s) to rMINB16837: Bug INP-1920 - Ensure consistent named tab preset usage.
Mon, Jul 28, 7:08 AM
alex committed rMINB16837: Bug INP-1920 - Ensure consistent named tab preset usage.
Bug INP-1920 - Ensure consistent named tab preset usage
Mon, Jul 28, 7:08 AM
alex added "INP-1920" JIRA issue(s) to rINP16836: Fixes INP-1920 - Ensure consistent named tab preset usage.
Mon, Jul 28, 7:08 AM
alex committed rINP16836: Fixes INP-1920 - Ensure consistent named tab preset usage.
Fixes INP-1920 - Ensure consistent named tab preset usage
Mon, Jul 28, 7:08 AM
alex closed D534: INP-1920 - Ensure consistent named tab preset usage.
Mon, Jul 28, 7:08 AM
erik accepted D534: INP-1920 - Ensure consistent named tab preset usage.
Mon, Jul 28, 6:37 AM
alex requested review of D534: INP-1920 - Ensure consistent named tab preset usage.
Mon, Jul 28, 3:41 AM
alex added "INP-1915" JIRA issue(s) to rMINC16835: Bug INP-1915 - Add support for IPv6 addresses.
Mon, Jul 28, 3:02 AM
alex committed rMINC16835: Bug INP-1915 - Add support for IPv6 addresses.
Bug INP-1915 - Add support for IPv6 addresses
Mon, Jul 28, 3:02 AM
alex added "INP-1915" JIRA issue(s) to rMINB16834: Bug INP-1915 - Add support for IPv6 addresses.
Mon, Jul 28, 3:02 AM
alex committed rMINB16834: Bug INP-1915 - Add support for IPv6 addresses.
Bug INP-1915 - Add support for IPv6 addresses
Mon, Jul 28, 3:02 AM
alex added "INP-1915" JIRA issue(s) to rINP16833: Fixes INP-1915 - Add support for IPv6 addresses.
Mon, Jul 28, 3:02 AM
alex committed rINP16833: Fixes INP-1915 - Add support for IPv6 addresses.
Fixes INP-1915 - Add support for IPv6 addresses
Mon, Jul 28, 3:02 AM
alex closed D528: INP-1915 - Add support for IPv6 addresses.
Mon, Jul 28, 3:02 AM

Fri, Jul 25

alex added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
In D529#10843, @erik wrote:

Made partial testing. In the u and addr units, on State field Detected unknown_option validation error. As discussed in Zoom, started writing code for automated unit test to check create/update all units with kOptionsFormatter.

Fri, Jul 25, 7:46 AM

Thu, Jul 24

erik added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Made partial testing. In the u and addr units, on State field Detected unknown_option validation error. As discussed in Zoom, started writing code for automated unit test to check create/update all units with kOptionsFormatter.

Thu, Jul 24, 1:51 PM

Wed, Jul 23

erik updated the test plan for D533: INP-1919 Reset unit config cache after Module Root Category change.
Wed, Jul 23, 12:50 PM
erik requested review of D533: INP-1919 Reset unit config cache after Module Root Category change.
Wed, Jul 23, 12:48 PM
erik accepted D531: INP-1916 - Correct scroll-to-error behavior on the Configuration Pages.
Wed, Jul 23, 6:25 AM
alex requested review of D531: INP-1916 - Correct scroll-to-error behavior on the Configuration Pages.
In D531#10825, @erik wrote:

Part 3 - "confirm that the Select Module Root Section system setting value was properly saved" - It's not properly saved. After "Save" button pressed, page reloads and returns old Home → Products value.

Wed, Jul 23, 6:23 AM
erik requested changes to D531: INP-1916 - Correct scroll-to-error behavior on the Configuration Pages.

Part 3 - "confirm that the Select Module Root Section system setting value was properly saved" - It's not properly saved. After "Save" button pressed, page reloads and returns old Home → Products value.

Wed, Jul 23, 6:00 AM
erik accepted D530: MINC-210 - Repair Downloadable products file downloads on the Front-End.
Wed, Jul 23, 5:45 AM

Tue, Jul 22

erik accepted D528: INP-1915 - Add support for IPv6 addresses.
Tue, Jul 22, 7:03 AM

Sat, Jul 19

alex requested review of D532: INP-1859 - Escape MySQL 8.3 keywords.
Sat, Jul 19, 7:25 AM
alex updated the diff for D528: INP-1915 - Add support for IPv6 addresses.

Corrected the length of the UserSessionLogs.IP during clean install.

Sat, Jul 19, 7:20 AM
alex added a comment to D528: INP-1915 - Add support for IPv6 addresses.
In D528#10766, @erik wrote:

After clean install:

2.1 kUtilTest::testNetMatch test, 2 tests failed

name: www.in-portal.org; actual: 69.27.40.110
This test printed output: name: www.in-portal.org; actual: 69.27.40.110

name: www.yahoo.com; actual: 188.125.94.204
This test printed output: name: www.yahoo.com; actual: 188.125.94.204

Sat, Jul 19, 7:17 AM
alex updated the test plan for D528: INP-1915 - Add support for IPv6 addresses.
Sat, Jul 19, 7:16 AM
alex updated the test plan for D531: INP-1916 - Correct scroll-to-error behavior on the Configuration Pages.
Sat, Jul 19, 7:05 AM
alex requested review of D531: INP-1916 - Correct scroll-to-error behavior on the Configuration Pages.
Sat, Jul 19, 7:04 AM
alex added "TADV-54" JIRA issue(s) to rTADV16832: Fixes TADV-54 - Repair poll commenting in Mod-Rewrite mode.
Sat, Jul 19, 6:28 AM
alex committed rTADV16832: Fixes TADV-54 - Repair poll commenting in Mod-Rewrite mode.
Fixes TADV-54 - Repair poll commenting in Mod-Rewrite mode
Sat, Jul 19, 6:28 AM
alex closed D527: TADV-54 - Repair poll commenting in Mod-Rewrite mode.
Sat, Jul 19, 6:27 AM
alex added "INP-1890" JIRA issue(s) to rINP16831: Fixes INP-1890 - Force "\kApplication::NextResourceId" method to use master….
Sat, Jul 19, 6:25 AM
alex committed rINP16831: Fixes INP-1890 - Force "\kApplication::NextResourceId" method to use master….
Fixes INP-1890 - Force "\kApplication::NextResourceId" method to use master…
Sat, Jul 19, 6:25 AM
alex closed D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.
Sat, Jul 19, 6:25 AM
alex updated the test plan for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Sat, Jul 19, 5:44 AM
alex updated the test plan for D530: MINC-210 - Repair Downloadable products file downloads on the Front-End.
Sat, Jul 19, 5:00 AM
alex requested review of D530: MINC-210 - Repair Downloadable products file downloads on the Front-End.
Sat, Jul 19, 5:00 AM
alex updated the test plan for D528: INP-1915 - Add support for IPv6 addresses.
Sat, Jul 19, 4:56 AM

Fri, Jul 18

alex updated the test plan for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Fri, Jul 18, 12:56 PM

Tue, Jul 15

alex updated the test plan for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Tue, Jul 15, 2:17 AM

Mon, Jul 14

alex updated the test plan for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Mon, Jul 14, 12:43 PM
alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Added missing phrase.

Mon, Jul 14, 12:39 PM
alex requested review of D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Mon, Jul 14, 12:35 PM

Fri, Jul 11

erik requested changes to D528: INP-1915 - Add support for IPv6 addresses.

After clean install:

Fri, Jul 11, 6:55 AM

Thu, Jul 10

alex updated the diff for D528: INP-1915 - Add support for IPv6 addresses.

Use www.in-portal.org domain for testing instead of www.google.com to avoid Anycast DNS issues (random IP address returned on each DNS query).

Thu, Jul 10, 12:41 PM
alex updated the test plan for D528: INP-1915 - Add support for IPv6 addresses.
Thu, Jul 10, 10:21 AM
alex requested review of D528: INP-1915 - Add support for IPv6 addresses.
Thu, Jul 10, 10:14 AM
erik accepted D527: TADV-54 - Repair poll commenting in Mod-Rewrite mode.
Thu, Jul 10, 9:50 AM
alex requested review of D527: TADV-54 - Repair poll commenting in Mod-Rewrite mode.
Thu, Jul 10, 8:29 AM

Jun 30 2025

erik accepted D526: INP-1914 - Disable "pass_through" handling on the Front-End.
Jun 30 2025, 1:07 PM
alex requested review of D526: INP-1914 - Disable "pass_through" handling on the Front-End.
Jun 30 2025, 9:00 AM

May 30 2025

erik accepted D525: INP-1913 - Allow sending custom HTTP headers.
May 30 2025, 7:51 AM
alex updated the diff for D525: INP-1913 - Allow sending custom HTTP headers.

Added missing la_fld_ExtraHTTPHeaders phrase.

May 30 2025, 7:12 AM
erik requested changes to D525: INP-1913 - Allow sending custom HTTP headers.

All test plan passed.

May 30 2025, 7:07 AM
alex updated the test plan for D525: INP-1913 - Allow sending custom HTTP headers.
May 30 2025, 5:44 AM
alex requested review of D525: INP-1913 - Allow sending custom HTTP headers.
May 30 2025, 5:42 AM

May 27 2025

alex added "INP-1912" JIRA issue(s) to rINP16830: Fixes INP-1912 - Show "404 Page Not Found" page on the Front-End for….
May 27 2025, 8:26 AM
alex committed rINP16830: Fixes INP-1912 - Show "404 Page Not Found" page on the Front-End for….
Fixes INP-1912 - Show "404 Page Not Found" page on the Front-End for…
May 27 2025, 8:25 AM
alex closed D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
May 27 2025, 8:25 AM
alex added "INP-1857" JIRA issue(s) to rINP16829: Bug INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
May 27 2025, 8:23 AM
alex committed rINP16829: Bug INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Bug INP-1857 - Prevent recursion in the "\kUrlManager::show404" method
May 27 2025, 8:23 AM
alex closed D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
May 27 2025, 8:23 AM
erik accepted D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
May 27 2025, 6:00 AM
erik accepted D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
May 27 2025, 5:51 AM
alex requested review of D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.

I've added # (new) apply the patch from the D524, unless it's already committed line, that should fix the problem. Please retest.

May 27 2025, 4:44 AM
alex updated the test plan for D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
May 27 2025, 4:43 AM
alex added a parent revision for D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method: D462: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
May 27 2025, 4:32 AM
alex added a child revision for D462: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method: D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
May 27 2025, 4:32 AM · Restricted Project
alex requested review of D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
May 27 2025, 4:32 AM

May 26 2025

alex added a comment to D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.

2.2 - this part of test plan is excessive

May 26 2025, 12:36 PM
alex updated the test plan for D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
May 26 2025, 12:11 PM
erik requested changes to D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.

2.2 - this part of test plan is excessive
2.3 - Failed all front-end tests. Always shown Oops, something went wrong text, not 404 page. Always System Log IS created about incident

May 26 2025, 11:05 AM
alex added a parent revision for D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events: D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit.
May 26 2025, 10:34 AM
alex added a child revision for D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit: D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
May 26 2025, 10:34 AM