JS code in the CSV export not detected in both cases - with patch and without patch..

JS code in the CSV export not detected in both cases - with patch and without patch..

Perform some minor CS fixes (Boyscout rule).

Removed temporary $ReportItem ($report_item) variable, that is no longer needed.

Extracted non on-topic changes into D556 (removing Debugger JS from an exported sales report).

1. resubmit from the 5.3.x branch, because an associated Jira task is for the 5.3.x branch as well.

Instead of updating D508 this Differential Revision was created. Closing as duplicate.

Resubmitting the same code from the 5.3.x branch.

No such notice in the coupi unit. TitleField for coupi unit was not configured.

Added similar fix for the api unit

Allow changing created report structure based on the filters.

This appears to be a duplicate of the D547.

In D532#11363, @erik wrote:

1. missing system/downloads folder, so can't save file for downloadable product

1. missing system/downloads folder, so can't save file for downloadable product
2. on downloadable product creation "Price" field on the "Files & Pricing" tab is not required, but, if this input is missing, SQL error happens when trying buy this product in front-end.

Added more tests.

Added unit tests for multi-generator usage.

CS fix: added visibility modifier for the \AbstractSalesReportGenerator::$unitConfigBackup property.

Allow generating several sales reports (even of different type) during one PHP script run.

In D555#11331, @erik wrote:

Notices detected on the E-commerce → Transactions section.

1. Requested ID for prefix affil.log not passed
2. Parent ID not found (prefix: "affil.log"; sub-prefix: "apayments.log")
   
   
   

Notices detected on the E-commerce → Transactions section.

In D551#11308, @erik wrote:

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

convertPathToRelative is called to convert each element in the $params array, however only "default" parameter contains file path. There are made excessive convertPathToRelative calls for some parameters (quality, output_format, etc.)

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

After clean install
Part 4.9 - confirm that you'll see an error message above the system settings list indicating which folders weren't deleted as part of the system setting change. - There appears only "Please manually delete paths:" message. No folder names are present in the message.

Restored chages in the TemplatesCache class, that were accidentally removed.

Corrected permissions on the system folder itself. Report indirect compiled template removal as part of system setting change.

In D551#11256, @erik wrote:

2. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.

2. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.

Reverted change from array_merge into += during template parser mass-compilation error displaying.

Added color names in comments.

Improve handling of log levels, that doesn't require coloring.

All task-defined coloring is right.

"use the above-created user and products (several with different quantities)"

Cosmetic change.