Submitted by accident.
- Queries
- All Stories
- Search
- Advanced Search
All Stories
Nov 14 2014
Nov 13 2014
Nov 12 2014
Nov 4 2014
Handle Fatal error in CLI and non-catchable fatal error
Nov 3 2014
update FormSubmissionsEventHandler::OnBuildFormFields
Adding "project.name" key.
I've forgot to add project.name key, which is crutial when Arcanist is determening whatever arc diff should create new revision or update existing one.
Nov 1 2014
Property changes were included by accident and aren't part of final commit.
Oct 31 2014
Changed version in upgredes.sql
Checked that these options never used in controls like inp_edoit_options. Fields State, BillingState, ShippingState are shown only as inp_edit_box or inp_label.
Oct 30 2014
Please also update FormSubmissionsEventHandler::OnBuildFormFields method to include following lines in the cycle that creates form field configuration:
$field_options['front_label'] = $options['FieldLabel']; $field_options['admin_label'] = $options['Prompt'];
Make sure it works.
Oct 29 2014
Oct 23 2014
fix latest issues
Oct 22 2014
Oct 21 2014
Oct 20 2014
Removed indentation changes added by mistake.
Oct 19 2014
change field name in validation message via unit config - full patch
By uploading patch that only has uncommited changes you've wiped out all other changes in this Differential Revision. Please reupload patch that has all pieces together: commited and uncommited.
change field name in validation message via unit config
Oct 18 2014
Oct 14 2014
Oct 13 2014
Oct 3 2014
After using it a bit I've one edge case, that wasn't covered:
Oct 1 2014
Sep 26 2014
Sep 25 2014
fixes by Alex's review
- please use only TABs for indentation (via TeamViewer discovered, that incorrect PhpStorm settings lead to this)
- populate (in upgrade.sql) the value of AddedOn column with UNIX_TIMESTAMP()
Sep 24 2014
The patch needs to be created against 5.3.x branch.
Sep 23 2014
Sep 19 2014
remove unused code to detect replaces count
Fix Alex's notes
fix by Alex's comments
Also please replace %s in all error messages that are affected by named error parameter introduction to corresponding named parameters in /core/install/upgrades.sql for 5.2.2-B1 version. Don't forget to update /core/install/english.lang as well.