Page MenuHomeIn-Portal Phabricator
Feed All Stories

Nov 14 2014

alex abandoned D22: Build System.

Submitted by accident.

Nov 14 2014, 4:42 AM
glebs retitled D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE from to [INP-1369] Transform all hooks to u::OnAfterConfigRead event into hBEFORE.
Nov 14 2014, 4:38 AM
alex retitled D22: Build System from to Build System.
Nov 14 2014, 3:23 AM

Nov 13 2014

glebs accepted D21: INP-1391 - Allow to separately run deployment steps.
Nov 13 2014, 5:57 AM · Restricted Project

Nov 12 2014

alex retitled D21: INP-1391 - Allow to separately run deployment steps from to INP-1391 - Allow to separately run deployment steps.
Nov 12 2014, 8:24 AM · Restricted Project

Nov 4 2014

glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.

Handle Fatal error in CLI and non-catchable fatal error

Nov 4 2014, 6:08 AM · Restricted Project

Nov 3 2014

alex accepted D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Nov 3 2014, 3:08 PM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

update FormSubmissionsEventHandler::OnBuildFormFields

Nov 3 2014, 1:26 PM · Restricted Project
alex committed rINP16092: Bug INP-1390 - Create Phabricator configuration file.
Bug INP-1390 - Create Phabricator configuration file
Nov 3 2014, 3:22 AM
alex updated the diff for D20: INP-1390 - Create Phabricator configuration file.

Adding "project.name" key.

Nov 3 2014, 3:19 AM
alex planned changes to D20: INP-1390 - Create Phabricator configuration file.

I've forgot to add project.name key, which is crutial when Arcanist is determening whatever arc diff should create new revision or update existing one.

Nov 3 2014, 3:16 AM
glebs accepted D20: INP-1390 - Create Phabricator configuration file.
Nov 3 2014, 2:24 AM

Nov 1 2014

alex committed rINP16090: Fixes INP-1390 - Create Phabricator configuration file.
Fixes INP-1390 - Create Phabricator configuration file
Nov 1 2014, 9:09 AM
alex added a comment to D20: INP-1390 - Create Phabricator configuration file.

Property changes were included by accident and aren't part of final commit.

Nov 1 2014, 8:53 AM
alex retitled D20: INP-1390 - Create Phabricator configuration file from to Create Phabricator configuration file.
Nov 1 2014, 8:11 AM

Oct 31 2014

erik updated the diff for D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username.

Changed version in upgredes.sql

Oct 31 2014, 7:37 AM
erik added a comment to D19: INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method.

Checked that these options never used in controls like inp_edoit_options. Fields State, BillingState, ShippingState are shown only as inp_edit_box or inp_label.

Oct 31 2014, 7:07 AM
erik retitled D19: INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method from to Removed empty option.
Oct 31 2014, 7:05 AM

Oct 30 2014

alex accepted D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products.
Oct 30 2014, 3:27 PM
alex set the repository for D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products to rMINC Modules.In-Commerce.
Oct 30 2014, 2:56 PM
erik retitled D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products from to Icons moved to core module.
Oct 30 2014, 1:40 PM
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

Please also update FormSubmissionsEventHandler::OnBuildFormFields method to include following lines in the cycle that creates form field configuration:

$field_options['front_label'] = $options['FieldLabel'];
$field_options['admin_label'] = $options['Prompt'];

Make sure it works.

Oct 30 2014, 12:21 PM · Restricted Project
alex requested changes to D3: INP-1381 - Create special template for fatal error page.
Oct 30 2014, 6:14 AM · Restricted Project

Oct 29 2014

alex committed rMCUS16085: Releasing version 'releases/1.2.1' (copy from 'branches/1.2.x') of….
Releasing version 'releases/1.2.1' (copy from 'branches/1.2.x') of…
Oct 29 2014, 7:13 AM

Oct 23 2014

glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.

fix latest issues

Oct 23 2014, 4:04 AM · Restricted Project

Oct 22 2014

alex committed rTADV16083: Bug INP-1388 - Make CKEditor stylesheet within theme editable.
Bug INP-1388 - Make CKEditor stylesheet within theme editable
Oct 22 2014, 6:58 AM
alex committed rINP16084: Fixes INP-1388 - Make CKEditor stylesheet within theme editable.
Fixes INP-1388 - Make CKEditor stylesheet within theme editable
Oct 22 2014, 3:59 AM

Oct 21 2014

alex committed rINP16082: Fixes INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX….
Fixes INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX…
Oct 21 2014, 1:34 PM
alex committed rINP16081: Fixes INP-1387 - Move primary theme/language detection into corresponding units.
Fixes INP-1387 - Move primary theme/language detection into corresponding units
Oct 21 2014, 1:34 PM
glebs accepted D17: INP-1388 - Make CKEditor stylesheet within theme editable.
Oct 21 2014, 1:23 PM · Restricted Project
alex added a reviewer for D17: INP-1388 - Make CKEditor stylesheet within theme editable: glebs.
Oct 21 2014, 12:11 PM · Restricted Project
alex retitled D17: INP-1388 - Make CKEditor stylesheet within theme editable from to Make CKEditor stylesheet within theme editable.
Oct 21 2014, 12:11 PM · Restricted Project
glebs accepted D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request.
Oct 21 2014, 10:25 AM · Restricted Project
glebs accepted D16: INP-1387 - Move primary theme/language detection into corresponding units.
Oct 21 2014, 10:24 AM
alex retitled D16: INP-1387 - Move primary theme/language detection into corresponding units from to Move primary theme/language detection into corresponding units.
Oct 21 2014, 9:33 AM

Oct 20 2014

alex added a reviewer for D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request: glebs.
Oct 20 2014, 5:38 AM · Restricted Project
alex updated the diff for D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request.

Removed indentation changes added by mistake.

Oct 20 2014, 5:31 AM · Restricted Project
alex retitled D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request from to Don't violate Same-Origin Policy by doing redirect within AJAX request.
Oct 20 2014, 5:28 AM · Restricted Project

Oct 19 2014

alex accepted D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Oct 19 2014, 9:04 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

change field name in validation message via unit config - full patch

Oct 19 2014, 8:27 AM · Restricted Project
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

By uploading patch that only has uncommited changes you've wiped out all other changes in this Differential Revision. Please reupload patch that has all pieces together: commited and uncommited.

Oct 19 2014, 3:42 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

change field name in validation message via unit config

Oct 19 2014, 1:55 AM · Restricted Project

Oct 18 2014

alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Oct 18 2014, 2:27 AM · Restricted Project
alex reopened D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Oct 18 2014, 2:27 AM · Restricted Project

Oct 14 2014

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Oct 14 2014, 11:00 AM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Oct 14 2014, 9:22 AM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Oct 14 2014, 9:19 AM · Restricted Project

Oct 13 2014

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Oct 13 2014, 4:36 AM · Restricted Project

Oct 3 2014

alex requested changes to D3: INP-1381 - Create special template for fatal error page.

After using it a bit I've one edge case, that wasn't covered:

Oct 3 2014, 6:38 AM · Restricted Project

Oct 1 2014

alex accepted D14: INP-1385 - Redirect to last page of list after switching PerPage value.
Oct 1 2014, 4:38 AM · Restricted Project
glebs retitled D14: INP-1385 - Redirect to last page of list after switching PerPage value from to INP-1385 Redirect to last page of list after switching PerPage value.
Oct 1 2014, 4:22 AM · Restricted Project

Sep 26 2014

alex accepted D3: INP-1381 - Create special template for fatal error page.
Sep 26 2014, 3:01 AM · Restricted Project

Sep 25 2014

glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.

fixes by Alex's review

Sep 25 2014, 2:20 PM · Restricted Project
erik retitled D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice from to Duplicate empty_label translation.
Sep 25 2014, 11:33 AM
alex requested changes to D11: INP-1313 - Add support for copying content blocks between themes.
Sep 25 2014, 11:02 AM
alex requested changes to D12: INP-1312 - Mark themes as deleted instead of actually deleting them.
  1. please use only TABs for indentation (via TeamViewer discovered, that incorrect PhpStorm settings lead to this)
  2. populate (in upgrade.sql) the value of AddedOn column with UNIX_TIMESTAMP()
Sep 25 2014, 10:50 AM
alex requested changes to D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username.
Sep 25 2014, 10:40 AM
erik retitled D12: INP-1312 - Mark themes as deleted instead of actually deleting them from to Improving theme deleting alghoritm.
Sep 25 2014, 10:35 AM
alex requested changes to D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Sep 25 2014, 10:32 AM
erik retitled D11: INP-1313 - Add support for copying content blocks between themes from to Copy content blocks between themes.
Sep 25 2014, 10:31 AM
erik retitled D10: INP-1315 - Reset cached sorting on sorting configuration change from to Reset cached sorting on sorting configuration change.
Sep 25 2014, 10:28 AM
erik retitled D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username from to Admins are receiving e-mails with empty quotes.
Sep 25 2014, 10:09 AM
erik retitled D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages from to Keywords absent in the url of the search results page.
Sep 25 2014, 10:05 AM
alex requested changes to D7: INP-1379 - Don't query related items, when main item isn't found.
Sep 25 2014, 10:02 AM
alex accepted D6: MINB-22 - Fix notice during Poll voating.
Sep 25 2014, 9:52 AM
erik retitled D7: INP-1379 - Don't query related items, when main item isn't found from to SQL error, when printing related pages.
Sep 25 2014, 9:51 AM
erik retitled D6: MINB-22 - Fix notice during Poll voating from to Notice, when making a vote on Poll.
Sep 25 2014, 9:48 AM
erik retitled D5: TADV-34 - Incorrect usage of "block_no_data" attribute from to Incorrect usage of "block_no_data" attribute.
Sep 25 2014, 9:45 AM
alex accepted D4: INP-1382 - Rename "CategoryItemsEventHander" class into "CategoryItemsEventHandler" class.
Sep 25 2014, 9:39 AM
erik retitled D4: INP-1382 - Rename "CategoryItemsEventHander" class into "CategoryItemsEventHandler" class from to Typo in "CategoryItemsEventHander" class name.
Sep 25 2014, 9:33 AM

Sep 24 2014

alex requested changes to D3: INP-1381 - Create special template for fatal error page.

The patch needs to be created against 5.3.x branch.

Sep 24 2014, 8:50 AM · Restricted Project
glebs closed D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 24 2014, 6:08 AM · Restricted Project
alex removed rINP In-Portal as the repository for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 24 2014, 3:40 AM · Restricted Project
alex added a reviewer for D3: INP-1381 - Create special template for fatal error page: alex.
Sep 24 2014, 3:39 AM · Restricted Project

Sep 23 2014

glebs retitled D3: INP-1381 - Create special template for fatal error page from to INP-1381 Create special template for fatal error page.
Sep 23 2014, 12:25 PM · Restricted Project

Sep 19 2014

alex changed the visibility for D1: INP-1351 - Don't change user sorting on search result page.
Sep 19 2014, 10:19 AM
alex changed the visibility for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 10:18 AM · Restricted Project
alex accepted D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 10:07 AM · Restricted Project
alex set the repository for D2: INP-1380 - Use named parameters in error messages and add new parameter {field} to rINP In-Portal.
Sep 19 2014, 10:03 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

remove unused code to detect replaces count

Sep 19 2014, 9:56 AM · Restricted Project
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 9:51 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

Fix Alex's notes

Sep 19 2014, 9:21 AM · Restricted Project
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 5:48 AM · Restricted Project
alex set the repository for D2: INP-1380 - Use named parameters in error messages and add new parameter {field} to rINP In-Portal.
Sep 19 2014, 5:44 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

fix by Alex's comments

Sep 19 2014, 5:07 AM · Restricted Project
alex updated the test plan for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 4:09 AM · Restricted Project
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.

Also please replace %s in all error messages that are affected by named error parameter introduction to corresponding named parameters in /core/install/upgrades.sql for 5.2.2-B1 version. Don't forget to update /core/install/english.lang as well.

Sep 19 2014, 3:24 AM · Restricted Project
glebs added a reviewer for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}: alex.
Sep 19 2014, 2:37 AM · Restricted Project
glebs retitled D2: INP-1380 - Use named parameters in error messages and add new parameter {field} from to Use named parameters in error messages and add new parameter {field}.
Sep 19 2014, 2:36 AM · Restricted Project

Aug 28 2014

alex abandoned D1: INP-1351 - Don't change user sorting on search result page.
Aug 28 2014, 11:44 AM
alex updated the diff for D1: INP-1351 - Don't change user sorting on search result page.
Aug 28 2014, 11:42 AM

May 13 2014

alex retitled D1: INP-1351 - Don't change user sorting on search result page from to Don't change user sorting on search result page.
May 13 2014, 3:24 AM