Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
- Queries
- All Stories
- Search
- Advanced Search
Feed All Stories
All Stories
All Stories
Nov 23 2014
Nov 23 2014
alex added a comment to D16: INP-1387 - Move primary theme/language detection into corresponding units.
alex added a comment to D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Nov 23 2014, 3:13 AM · Restricted Project
alex added a comment to D14: INP-1385 - Redirect to last page of list after switching PerPage value.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Nov 23 2014, 3:13 AM · Restricted Project
alex added a comment to D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
alex added a comment to D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
alex added a comment to D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
alex added a comment to D4: INP-1382 - Rename "CategoryItemsEventHander" class into "CategoryItemsEventHandler" class.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Nov 23 2014, 3:10 AM · Restricted Project
alex added a comment to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Nov 23 2014, 3:10 AM · Restricted Project
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
Nov 21 2014
Nov 21 2014
Nov 19 2014
Nov 19 2014
Nov 19 2014, 12:57 PM · Restricted Project
Nov 18 2014
Nov 18 2014
Fixes MINB-22 - Notice, when making a vote on Poll
alex requested changes to D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products.
Patch was created against In-Commerce 5.3.x, while associated JIRA task is targeted to In-Commerce 5.2.x. Because of this patch can't be clearly applied.
alex committed rINP16096: Fixes INP-1385 - Redirect to last page of list after switching PerPage value.
Fixes INP-1385 - Redirect to last page of list after switching PerPage value
alex closed D14: INP-1385 - Redirect to last page of list after switching PerPage value by committing rINP16096: Fixes INP-1385 - Redirect to last page of list after switching PerPage value.
Nov 18 2014, 1:28 PM · Restricted Project
Fixes INP-1382 - Typo in "CategoryItemsEventHander" class name
Nov 18 2014, 4:15 AM · Restricted Project
Fixes INP-1391 - Allow to separately run deployment steps
alex closed D21: INP-1391 - Allow to separately run deployment steps by committing rINP16094: Fixes INP-1391 - Allow to separately run deployment steps.
Nov 18 2014, 3:10 AM · Restricted Project
Returning back original revision content, that was overwritten by commit.
Nov 18 2014, 3:06 AM · Restricted Project
Was closed mistakenly instead of D24.
Nov 18 2014, 2:59 AM · Restricted Project
Nov 17 2014
Nov 17 2014
Nov 17 2014, 4:27 PM · Restricted Project
Nov 17 2014, 4:26 PM · Restricted Project
I mistakenly associated this commit with wrong differential revision. Correct one is below.
Fixes INP-1392 - Create profile configuration script
alex closed D21: INP-1391 - Allow to separately run deployment steps by committing rINP16093: Fixes INP-1392 - Create profile configuration script.
Nov 17 2014, 4:06 PM · Restricted Project
alex retitled D24: INP-1392 - Create profile configuration script from to INP-1392 - Create profile configuration script.
Nov 14 2014
Nov 14 2014
glebs updated the diff for D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.
Fix paths
glebs retitled D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE from to [INP-1369] Transform all hooks to u::OnAfterConfigRead event into hBEFORE.
Nov 13 2014
Nov 13 2014
Nov 13 2014, 5:57 AM · Restricted Project
Nov 12 2014
Nov 12 2014
alex retitled D21: INP-1391 - Allow to separately run deployment steps from to INP-1391 - Allow to separately run deployment steps.
Nov 12 2014, 8:24 AM · Restricted Project
Nov 4 2014
Nov 4 2014
Handle Fatal error in CLI and non-catchable fatal error
Nov 4 2014, 6:08 AM · Restricted Project
Nov 3 2014
Nov 3 2014
Nov 3 2014, 3:08 PM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
update FormSubmissionsEventHandler::OnBuildFormFields
Nov 3 2014, 1:26 PM · Restricted Project
Bug INP-1390 - Create Phabricator configuration file
Adding "project.name" key.
I've forgot to add project.name key, which is crutial when Arcanist is determening whatever arc diff should create new revision or update existing one.
Nov 1 2014
Nov 1 2014
Fixes INP-1390 - Create Phabricator configuration file
Property changes were included by accident and aren't part of final commit.
alex retitled D20: INP-1390 - Create Phabricator configuration file from to Create Phabricator configuration file.
Oct 31 2014
Oct 31 2014
erik updated the diff for D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username.
Changed version in upgredes.sql
erik added a comment to D19: INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method.
Checked that these options never used in controls like inp_edoit_options. Fields State, BillingState, ShippingState are shown only as inp_edit_box or inp_label.
erik retitled D19: INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method from to Removed empty option.
Oct 30 2014
Oct 30 2014
alex set the repository for D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products to rMINC Modules.In-Commerce.
erik retitled D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products from to Icons moved to core module.
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Please also update FormSubmissionsEventHandler::OnBuildFormFields method to include following lines in the cycle that creates form field configuration:
$field_options['front_label'] = $options['FieldLabel']; $field_options['admin_label'] = $options['Prompt'];
Make sure it works.
Oct 30 2014, 12:21 PM · Restricted Project
Oct 30 2014, 6:14 AM · Restricted Project
Oct 29 2014
Oct 29 2014
Releasing version 'releases/1.2.1' (copy from 'branches/1.2.x') of…
Oct 23 2014
Oct 23 2014
fix latest issues
Oct 23 2014, 4:04 AM · Restricted Project
Oct 22 2014
Oct 22 2014
Bug INP-1388 - Make CKEditor stylesheet within theme editable
Fixes INP-1388 - Make CKEditor stylesheet within theme editable
Oct 21 2014
Oct 21 2014
alex committed rINP16082: Fixes INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX….
Fixes INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX…
alex committed rINP16081: Fixes INP-1387 - Move primary theme/language detection into corresponding units.
Fixes INP-1387 - Move primary theme/language detection into corresponding units
Oct 21 2014, 1:23 PM · Restricted Project
Oct 21 2014, 12:11 PM · Restricted Project
alex retitled D17: INP-1388 - Make CKEditor stylesheet within theme editable from to Make CKEditor stylesheet within theme editable.
Oct 21 2014, 12:11 PM · Restricted Project
glebs accepted D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request.
Oct 21 2014, 10:25 AM · Restricted Project
alex retitled D16: INP-1387 - Move primary theme/language detection into corresponding units from to Move primary theme/language detection into corresponding units.
Oct 20 2014
Oct 20 2014
alex added a reviewer for D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request: glebs.
Oct 20 2014, 5:38 AM · Restricted Project
alex updated the diff for D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request.
Removed indentation changes added by mistake.
Oct 20 2014, 5:31 AM · Restricted Project
alex retitled D15: INP-1386 - Don't violate Same-Origin Policy by doing redirect within AJAX request from to Don't violate Same-Origin Policy by doing redirect within AJAX request.
Oct 20 2014, 5:28 AM · Restricted Project
Oct 19 2014
Oct 19 2014
Oct 19 2014, 9:04 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
change field name in validation message via unit config - full patch
Oct 19 2014, 8:27 AM · Restricted Project
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
By uploading patch that only has uncommited changes you've wiped out all other changes in this Differential Revision. Please reupload patch that has all pieces together: commited and uncommited.
Oct 19 2014, 3:42 AM · Restricted Project
glebs updated the diff for D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
change field name in validation message via unit config
Oct 19 2014, 1:55 AM · Restricted Project
Oct 18 2014
Oct 18 2014
alex requested changes to D2: INP-1380 - Use named parameters in error messages and add new parameter {field}.
Oct 18 2014, 2:27 AM · Restricted Project
Oct 18 2014, 2:27 AM · Restricted Project
Oct 14 2014
Oct 14 2014
Oct 14 2014, 11:00 AM · Restricted Project
Oct 14 2014, 9:22 AM · Restricted Project
Oct 14 2014, 9:19 AM · Restricted Project
Oct 13 2014
Oct 13 2014
Oct 13 2014, 4:36 AM · Restricted Project
Oct 3 2014
Oct 3 2014
After using it a bit I've one edge case, that wasn't covered:
Oct 3 2014, 6:38 AM · Restricted Project
Oct 1 2014
Oct 1 2014
Oct 1 2014, 4:38 AM · Restricted Project
glebs retitled D14: INP-1385 - Redirect to last page of list after switching PerPage value from to INP-1385 Redirect to last page of list after switching PerPage value.
Oct 1 2014, 4:22 AM · Restricted Project
Sep 26 2014
Sep 26 2014
Sep 26 2014, 3:01 AM · Restricted Project
Sep 25 2014
Sep 25 2014
fixes by Alex's review
Sep 25 2014, 2:20 PM · Restricted Project
erik retitled D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice from to Duplicate empty_label translation.
- please use only TABs for indentation (via TeamViewer discovered, that incorrect PhpStorm settings lead to this)
- populate (in upgrade.sql) the value of AddedOn column with UNIX_TIMESTAMP()
alex requested changes to D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username.
erik retitled D12: INP-1312 - Mark themes as deleted instead of actually deleting them from to Improving theme deleting alghoritm.