In D228#4271, @alex wrote:

• list wasn't counted prior to new method being called, but more records than fits on per page were selected
• list wasn't counted prior to new method being called, but per page is -1

Requested changes

And test plan still doesn't cover direct method usage of DateHelper class.

And test is incomplete.

1. Always call Query in kDBList::GetSelectedCount()
2. Moved to 5.3 branch

Requested changes

Also test plan doesn't reflect addition of new method.

Requested changes

1. make changes specified below to transform code into more reusable state
2. test plan needs to be updated to cover not only indirect DateHelper::getHumanTime method usage, but also it's direct usage

Also the test plan must test all outcomes of http://qa.in-portal.org/diffusion/INP/browse/branches%252F5.2.x/in-portal/branches/5.2.x/core/kernel/db/dblist.php;16347$532-534 code:

@glebs , please retest all again. I've made some fixes and added Part 3 to the plan.

Restored files, that were removed in previous diff by accident.

Clear all output buffering levels before showing 404 page.

When output compression is enabled and debug mode is disabled there will content decoding error in Web Browser and no content will be shown.

I don't see test plan update.

Remove outdated comment

Test plan doesn't have part with regression testing. We need to test 2 scenarios:

Requested changes

Overwrite language pack on in-portal install, but do not on separate module install

Right now, when installing In-Portal with modules in one go no language pack overwrite happened.

Since permission system is affected please also include tests that would demonstrate, that if user has needed permissions no redirect happens and whatever should happen (upon user taking action) will happen.

Please do a complete retest.

Fixed case, when passed request variable wasn't reset, when Page Not Found page was shown.

The passed request variable isn't reset, when showing Page Not Found page, which results in links using pass="all" using prefixes from url.

To help you out I've pointed out places that should trigger all code paths not covered by test plan. You still need to very that it all works like this and write step-by-step test plan to execute changed code of course.

Patch transformed to 5.2.x version.

Adding comment to trigger automatic link creation between Phabricator and JIRA (was broken after last upgrade of Phabricator).

Adding comment to trigger automatic link creation between Phabricator and JIRA (was broken after last upgrade of Phabricator).

Adding comment to trigger automatic link creation between Phabricator and JIRA (was broken after last upgrade of Phabricator).

Actually please create this patch against 5.2.x branch. The changes doesn't look as breaking ones and 5.2.x developers would be happy.

Test plan should also include scenarios for testing each changed code fragment (e.g. where finalizePermissionCheck was called, but is no more) to demonstrate that in case of permission violation proper No Permission page is displayed.