Page MenuHomeIn-Portal Phabricator
Feed All Stories

Jul 12 2016

alex committed rMINC16360: Fixes MINC-146 - Modernize "orditems:RemoveCouponLink" tag.
Fixes MINC-146 - Modernize "orditems:RemoveCouponLink" tag
Jul 12 2016, 2:45 AM
alex closed D193: MINC-146 - Modernize "orditems:RemoveCouponLink" tag by committing rMINC16360: Fixes MINC-146 - Modernize "orditems:RemoveCouponLink" tag.
Jul 12 2016, 2:45 AM · Restricted Project
alex committed rINP16359: Fixes INP-1530 - The "Image" tag must set DataExists flag for Template Parser.
Fixes INP-1530 - The "Image" tag must set DataExists flag for Template Parser
Jul 12 2016, 2:41 AM
alex closed D194: INP-1530 - The "Image" tag must set DataExists flag for Template Parser by committing rINP16359: Fixes INP-1530 - The "Image" tag must set DataExists flag for Template Parser.
Jul 12 2016, 2:41 AM · Restricted Project
alex committed rINP16358: Fixes INP-1533 - Use "EXTR_SKIP" with "extract" function.
Fixes INP-1533 - Use "EXTR_SKIP" with "extract" function
Jul 12 2016, 2:38 AM
alex closed D197: INP-1533 - Use "EXTR_SKIP" with "extract" function by committing rINP16358: Fixes INP-1533 - Use "EXTR_SKIP" with "extract" function.
Jul 12 2016, 2:38 AM
ci added a comment to rINP16355: Fixes INP-1537 - The CS fix for "kUtil::array_merge_recursive" method.

Build #58 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/58/

Jul 12 2016, 2:36 AM
alex committed rINP16357: Fixes INP-1535 - Escape referrer displayed during redirect debugging.
Fixes INP-1535 - Escape referrer displayed during redirect debugging
Jul 12 2016, 2:35 AM
alex committed rINP16356: Fixes INP-1536 - Escape url for JavaScript context during JavaScript made….
Fixes INP-1536 - Escape url for JavaScript context during JavaScript made…
Jul 12 2016, 2:31 AM
alex committed rINP16355: Fixes INP-1537 - The CS fix for "kUtil::array_merge_recursive" method.
Fixes INP-1537 - The CS fix for "kUtil::array_merge_recursive" method
Jul 12 2016, 2:27 AM
alex closed D200: INP-1537 - Fix CS violations in for "kUtil::array_merge_recursive" method by committing rINP16355: Fixes INP-1537 - The CS fix for "kUtil::array_merge_recursive" method.
Jul 12 2016, 2:27 AM

Jul 11 2016

alex requested review of D233: MINC-176 - Register missing classes in class factory.
  1. Can't "confirm, that redirect to thank you page happened", as written in test plan. When not logged in front-end user performs "Place Order" operation, happens redirect to registration page, not to thank you page.
Jul 11 2016, 5:30 AM
alex updated the test plan for D233: MINC-176 - Register missing classes in class factory.
Jul 11 2016, 4:38 AM
erik requested changes to D233: MINC-176 - Register missing classes in class factory.
  1. Can't "confirm, that redirect to thank you page happened", as written in test plan. When not logged in front-end user performs "Place Order" operation, happens redirect to registration page, not to thank you page.
  2. Seems, test plan is incomplete - last line (press Ship toolbar button) requests test action, but no confirmation line following.
  3. Performing that "press Ship toolbar button" results in "mail error: header To is required" exception - http://screencast.com/t/ahSVogRnph6
Jul 11 2016, 4:35 AM

Jul 10 2016

ci added a comment to rINP16354: Fixes INP-1538 - Enable Mod-Rewrite by default.

Build #57 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/57/

Jul 10 2016, 3:12 PM
ci added a comment to rINP16350: Fixes INP-1546 - Make "user-profile:Field" tag support fields of any type.

Build #56 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/56/

Jul 10 2016, 3:03 PM
alex committed rINP16354: Fixes INP-1538 - Enable Mod-Rewrite by default.
Fixes INP-1538 - Enable Mod-Rewrite by default
Jul 10 2016, 3:02 PM
alex closed D203: INP-1538 - Enable Mod-Rewrite by default by committing rINP16354: Fixes INP-1538 - Enable Mod-Rewrite by default.
Jul 10 2016, 3:02 PM
alex committed rINP16353: Fixes INP-1543 - Return detected theme/language ID immediately from….
Fixes INP-1543 - Return detected theme/language ID immediately from…
Jul 10 2016, 3:01 PM
alex closed D207: INP-1543 - Return detected theme/language ID immediately from "getPassedID" method by committing rINP16353: Fixes INP-1543 - Return detected theme/language ID immediately from….
Jul 10 2016, 3:00 PM
alex committed rINP16352: Fixes INP-1544 - Delete expired session without using "Session" object.
Fixes INP-1544 - Delete expired session without using "Session" object
Jul 10 2016, 2:57 PM
alex closed D208: INP-1544 - Delete expired session without using "Session" object by committing rINP16352: Fixes INP-1544 - Delete expired session without using "Session" object.
Jul 10 2016, 2:57 PM
ci added a comment to rINP16348: Fixes INP-1563 - Make "kApplication::QuickRun" method reusable.

Build #55 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/55/

Jul 10 2016, 2:55 PM
alex committed rMINB16351: Fixes MINB-25 - Declare forum user preferences in the "user-profile" unit.
Fixes MINB-25 - Declare forum user preferences in the "user-profile" unit
Jul 10 2016, 2:54 PM
alex closed D211: MINB-25 - Declare forum user preferences in the "user-profile" unit by committing rMINB16351: Fixes MINB-25 - Declare forum user preferences in the "user-profile" unit.
Jul 10 2016, 2:54 PM
alex committed rINP16350: Fixes INP-1546 - Make "user-profile:Field" tag support fields of any type.
Fixes INP-1546 - Make "user-profile:Field" tag support fields of any type
Jul 10 2016, 2:51 PM
alex closed D210: INP-1546 - Make "user-profile:Field" tag support fields of any type by committing rINP16350: Fixes INP-1546 - Make "user-profile:Field" tag support fields of any type.
Jul 10 2016, 2:51 PM
alex committed rMINB16349: Fixes MINB-26 - Don't persist data for anonymous users.
Fixes MINB-26 - Don't persist data for anonymous users
Jul 10 2016, 2:47 PM
alex closed D212: MINB-26 - Don't persist data for anonymous users by committing rMINB16349: Fixes MINB-26 - Don't persist data for anonymous users.
Jul 10 2016, 2:47 PM
alex committed rINP16348: Fixes INP-1563 - Make "kApplication::QuickRun" method reusable.
Fixes INP-1563 - Make "kApplication::QuickRun" method reusable
Jul 10 2016, 2:41 PM
alex closed D225: INP-1563 - Make "kApplication::QuickRun" method reusable by committing rINP16348: Fixes INP-1563 - Make "kApplication::QuickRun" method reusable.
Jul 10 2016, 2:41 PM
alex updated the test plan for D234: INP-1570 - Make In-Portal Class Locator externally usable.
Jul 10 2016, 5:14 AM
alex updated the test plan for D234: INP-1570 - Make In-Portal Class Locator externally usable.
Jul 10 2016, 5:07 AM
alex retitled D234: INP-1570 - Make In-Portal Class Locator externally usable from to INP-1570 - Make In-Portal Class Locator externally usable.
Jul 10 2016, 5:06 AM

Jul 8 2016

alex updated the diff for D233: MINC-176 - Register missing classes in class factory.

Fixing CS issues in added lines.

Jul 8 2016, 3:07 PM
alex updated the test plan for D233: MINC-176 - Register missing classes in class factory.
Jul 8 2016, 3:04 PM
alex retitled D233: MINC-176 - Register missing classes in class factory from to MINC-176 - Register missing classes in class factory.
Jul 8 2016, 3:03 PM

Jul 6 2016

alex updated the test plan for D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.
Jul 6 2016, 4:58 AM
erik accepted D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.
Jul 6 2016, 4:30 AM

Jul 5 2016

alex updated the test plan for D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.
Jul 5 2016, 4:53 AM
alex retitled D232: INP-1566 - Don't log errors from 3rd party libraries to System Log from to INP-1566 - Don't log errors from 3rd party libraries to System Log.
Jul 5 2016, 4:52 AM
erik updated the diff for D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.

Removed CS fixes, added condition for DBType update.

Jul 5 2016, 4:30 AM

Jul 4 2016

alex requested changes to D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.
Jul 4 2016, 5:45 AM
erik retitled D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade from to INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.
Jul 4 2016, 5:06 AM

Jun 30 2016

erik accepted D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
Jun 30 2016, 4:58 AM

Jun 23 2016

glebs requested review of D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Jun 23 2016, 3:21 AM
glebs updated the test plan for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Jun 23 2016, 3:20 AM

Jun 22 2016

erik accepted D230: INP-1567 - Register missing classes in class factory.
Jun 22 2016, 4:58 AM

Jun 21 2016

alex updated the test plan for D230: INP-1567 - Register missing classes in class factory.
Jun 21 2016, 3:48 AM
alex retitled D230: INP-1567 - Register missing classes in class factory from to INP-1567 - Register missing classes in class factory.
Jun 21 2016, 3:42 AM

Jun 20 2016

alex planned changes to D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

Need to finalize test plan.

Jun 20 2016, 5:05 AM
alex edited reviewers for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI, added: erik; removed: glebs.
Jun 20 2016, 5:04 AM
alex edited reviewers for D225: INP-1563 - Make "kApplication::QuickRun" method reusable, added: erik; removed: glebs.
Jun 20 2016, 5:03 AM
alex edited reviewers for D146: INP-1494 - Create "phing:run" console command, added: erik; removed: glebs.
Jun 20 2016, 5:02 AM
erik requested review of D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 20 2016, 5:01 AM
erik added a comment to D222: INP-1327 Simplify custom permission checking in Event Handler.

Done - test plan improved.

Jun 20 2016, 4:48 AM
erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 20 2016, 4:44 AM

Jun 17 2016

alex requested changes to D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.

Alex, sorry, but I haven't understood what these cases mean

Jun 17 2016, 3:12 AM
glebs updated the diff for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.

Requested changes

Jun 17 2016, 2:22 AM
glebs added a comment to D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
In D228#4271, @alex wrote:
  • list wasn't counted prior to new method being called, but more records than fits on per page were selected
  • list wasn't counted prior to new method being called, but per page is -1
Jun 17 2016, 2:20 AM
glebs updated the test plan for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Jun 17 2016, 2:19 AM
glebs updated the test plan for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Jun 17 2016, 2:19 AM
glebs updated the diff for D229: INP-1565 Add support for "relative" date format.

Requested changes

Jun 17 2016, 1:54 AM
glebs updated the test plan for D229: INP-1565 Add support for "relative" date format.
Jun 17 2016, 1:51 AM

Jun 16 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 16 2016, 4:54 AM

Jun 15 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 15 2016, 4:53 AM
alex requested changes to D229: INP-1565 Add support for "relative" date format.

And test plan still doesn't cover direct method usage of DateHelper class.

Jun 15 2016, 3:02 AM
alex requested changes to D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.

And test is incomplete.

Jun 15 2016, 2:52 AM
glebs updated the test plan for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Jun 15 2016, 2:43 AM
glebs updated the diff for D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
  1. Always call Query in kDBList::GetSelectedCount()
  2. Moved to 5.3 branch
Jun 15 2016, 2:40 AM
glebs updated the diff for D229: INP-1565 Add support for "relative" date format.

Requested changes

Jun 15 2016, 2:33 AM

Jun 14 2016

alex added inline comments to D229: INP-1565 Add support for "relative" date format.
Jun 14 2016, 5:16 AM
alex requested changes to D229: INP-1565 Add support for "relative" date format.

Also test plan doesn't reflect addition of new method.

Jun 14 2016, 5:10 AM
glebs updated the diff for D229: INP-1565 Add support for "relative" date format.

Requested changes

Jun 14 2016, 4:46 AM
erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 14 2016, 4:18 AM
alex requested changes to D229: INP-1565 Add support for "relative" date format.
  1. make changes specified below to transform code into more reusable state
  2. test plan needs to be updated to cover not only indirect DateHelper::getHumanTime method usage, but also it's direct usage
Jun 14 2016, 3:48 AM

Jun 13 2016

glebs updated the test plan for D229: INP-1565 Add support for "relative" date format.
Jun 13 2016, 9:04 AM
glebs updated the test plan for D229: INP-1565 Add support for "relative" date format.
Jun 13 2016, 9:04 AM
glebs retitled D229: INP-1565 Add support for "relative" date format from to INP-1565 Add support for "relative" date format.
Jun 13 2016, 9:04 AM
erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 13 2016, 4:29 AM

Jun 10 2016

alex requested changes to D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.

Also the test plan must test all outcomes of http://qa.in-portal.org/diffusion/INP/browse/branches%252F5.2.x/in-portal/branches/5.2.x/core/kernel/db/dblist.php;16347$532-534 code:

Jun 10 2016, 2:39 AM
glebs retitled D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it from to INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Jun 10 2016, 1:33 AM

Jun 9 2016

alex added a comment to D225: INP-1563 - Make "kApplication::QuickRun" method reusable.

@glebs , please retest all again. I've made some fixes and added Part 3 to the plan.

Jun 9 2016, 12:06 PM
alex updated the diff for D225: INP-1563 - Make "kApplication::QuickRun" method reusable.

Restored files, that were removed in previous diff by accident.

Jun 9 2016, 12:04 PM
alex requested review of D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
Jun 9 2016, 11:59 AM
alex updated the diff for D225: INP-1563 - Make "kApplication::QuickRun" method reusable.

Clear all output buffering levels before showing 404 page.

Jun 9 2016, 11:58 AM
alex updated the test plan for D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
Jun 9 2016, 11:56 AM
alex planned changes to D225: INP-1563 - Make "kApplication::QuickRun" method reusable.

When output compression is enabled and debug mode is disabled there will content decoding error in Web Browser and no content will be shown.

Jun 9 2016, 11:45 AM
glebs requested review of D227: INP-1564 Check duplicate SQL revisions across all defined revisions.
Jun 9 2016, 2:11 AM
glebs updated the test plan for D227: INP-1564 Check duplicate SQL revisions across all defined revisions.
Jun 9 2016, 1:19 AM

Jun 7 2016

alex requested changes to D227: INP-1564 Check duplicate SQL revisions across all defined revisions.

I don't see test plan update.

Jun 7 2016, 3:20 AM
glebs updated the diff for D227: INP-1564 Check duplicate SQL revisions across all defined revisions.

Remove outdated comment

Jun 7 2016, 2:42 AM

Jun 2 2016

alex requested changes to D227: INP-1564 Check duplicate SQL revisions across all defined revisions.

Test plan doesn't have part with regression testing. We need to test 2 scenarios:

Jun 2 2016, 3:00 AM
glebs retitled D227: INP-1564 Check duplicate SQL revisions across all defined revisions from to INP-1564 Check duplicate SQL revisions across all defined revisions.
Jun 2 2016, 2:34 AM

May 27 2016

alex updated the test plan for D226: INP-1552 Import language pack without overwrite on separate module install.
May 27 2016, 2:19 AM
glebs updated the diff for D226: INP-1552 Import language pack without overwrite on separate module install.

Requested changes

May 27 2016, 2:02 AM

May 26 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 26 2016, 4:30 AM
alex requested changes to D226: INP-1552 Import language pack without overwrite on separate module install.
May 26 2016, 2:27 AM
glebs updated the diff for D226: INP-1552 Import language pack without overwrite on separate module install.

Overwrite language pack on in-portal install, but do not on separate module install

May 26 2016, 1:55 AM
glebs updated the test plan for D226: INP-1552 Import language pack without overwrite on separate module install.
May 26 2016, 1:50 AM