Page MenuHomeIn-Portal Phabricator
Feed All Stories

Jul 2 2017

alex committed rMINC16548: Merge of "w/in-commerce/branches/5.2.x@16541" to "w/in-commerce/branches/5.3..
Merge of "w/in-commerce/branches/5.2.x@16541" to "w/in-commerce/branches/5.3.
Jul 2 2017, 8:58 AM
alex committed rMINB16547: Merge of "modules/in-bulletin/branches/5.2.x@16540" to "modules/in….
Merge of "modules/in-bulletin/branches/5.2.x@16540" to "modules/in…
Jul 2 2017, 8:55 AM
alex committed rMCUS16546: Merge of "modules/custom/branches/1.2.x@16539" to "modules/custom/branches/1.3..
Merge of "modules/custom/branches/1.2.x@16539" to "modules/custom/branches/1.3.
Jul 2 2017, 8:53 AM
alex committed rINP16545: Merge of "in-portal/branches/5.2.x@16544" to "in-portal/branches/5.3.x@16534"..
Merge of "in-portal/branches/5.2.x@16544" to "in-portal/branches/5.3.x@16534".
Jul 2 2017, 8:51 AM

Jun 28 2017

erik added a comment to D12: INP-1312 - Mark themes as deleted instead of actually deleting them.

Today made locally all requested changes, left testing by plan.

Jun 28 2017, 5:58 AM

Jun 21 2017

erik accepted D312: INP-1709 - Validate "Categories.FriendlyURL" field for uniqueness.
Jun 21 2017, 9:54 AM

Jun 19 2017

alex created D312: INP-1709 - Validate "Categories.FriendlyURL" field for uniqueness.
Jun 19 2017, 11:03 AM

Jun 16 2017

alex added a comment to D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect.

I've updated test plan, because code was fine, but test plan had some copy/paste issues.

Jun 16 2017, 11:03 AM · Restricted Project
alex updated the test plan for D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect.
Jun 16 2017, 10:59 AM · Restricted Project
erik accepted D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect.
Jun 16 2017, 10:49 AM · Restricted Project
alex added a comment to D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect.

Need to specify 'direct_links' => false was the only reason tests have failed?

Jun 16 2017, 1:06 AM · Restricted Project

Jun 15 2017

erik requested changes to D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect.

Tested with image

. Some tests failed.

Jun 15 2017, 12:26 PM · Restricted Project
alex updated the test plan for D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect.
Jun 15 2017, 8:09 AM · Restricted Project

Jun 14 2017

alex added a project to D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect: Restricted Project.
Jun 14 2017, 8:21 AM · Restricted Project
alex created D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect.
Jun 14 2017, 8:19 AM · Restricted Project

Jun 5 2017

ci added a comment to rINP16544: Fixes INP-1566 - Don't log errors from 3rd party libraries to System Log.

Build #116 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/116/

Jun 5 2017, 5:21 AM
alex committed rINP16544: Fixes INP-1566 - Don't log errors from 3rd party libraries to System Log.
Fixes INP-1566 - Don't log errors from 3rd party libraries to System Log
Jun 5 2017, 5:07 AM
alex closed D232: INP-1566 - Don't log errors from 3rd party libraries to System Log by committing rINP16544: Fixes INP-1566 - Don't log errors from 3rd party libraries to System Log.
Jun 5 2017, 5:07 AM

May 26 2017

erik accepted D309: INP-1706 - Generate assets during deployment.
May 26 2017, 5:55 AM · Restricted Project

May 24 2017

alex added inline comments to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
May 24 2017, 3:09 AM · Restricted Project

May 22 2017

alex requested changes to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
May 22 2017, 4:50 AM · Restricted Project

May 21 2017

alex added a project to D309: INP-1706 - Generate assets during deployment: Unknown Object (Project).
May 21 2017, 2:22 PM · Unknown Object (Project)

May 20 2017

alex retitled D309: INP-1706 - Generate assets during deployment from to INP-1706 - Generate assets during deployment.
May 20 2017, 4:06 AM · Unknown Object (Project)

May 18 2017

erik accepted D299: INP-1695 - Automatically generate value for missing "upload_dir" field option.
May 18 2017, 5:48 AM
alex requested review of D299: INP-1695 - Automatically generate value for missing "upload_dir" field option.

Test plan updated to compensate for the found error. Turns out that include_path field option is mandatory, when kPictureFormatter is used without upload_dir option.

May 18 2017, 2:13 AM
alex updated the test plan for D299: INP-1695 - Automatically generate value for missing "upload_dir" field option.
May 18 2017, 2:12 AM

May 17 2017

erik accepted D298: INP-1694 - Upgrade YUICompressor to v2.4.8.
May 17 2017, 10:22 AM
erik accepted D308: INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI.

Tested also by D307 plan.

May 17 2017, 9:54 AM · Unknown Object (Project)
alex requested review of D308: INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI.

Please test again, because last time you've forgot to test all (skipped 1st line of test plan).

May 17 2017, 6:13 AM · Unknown Object (Project)
erik accepted D307: INP-1704 - Use strict comparison in "Session::NeedQueryString" method.
May 17 2017, 5:57 AM · Unknown Object (Project)
erik accepted D308: INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI.
May 17 2017, 5:50 AM · Unknown Object (Project)
alex added a project to D307: INP-1704 - Use strict comparison in "Session::NeedQueryString" method: Unknown Object (Project).
May 17 2017, 5:43 AM · Unknown Object (Project)
alex added a project to D308: INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI: Unknown Object (Project).
May 17 2017, 5:43 AM · Unknown Object (Project)
alex retitled D308: INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI from to INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI.
May 17 2017, 5:31 AM · Unknown Object (Project)
alex retitled D307: INP-1704 - Use strict comparison in "Session::NeedQueryString" method from to INP-1704 - Use strict comparison in "Session::NeedQueryString" method.
May 17 2017, 5:07 AM · Unknown Object (Project)

May 16 2017

erik requested changes to D299: INP-1695 - Automatically generate value for missing "upload_dir" field option.

Test failed in the Part 4 "confirm, that image preview is displayed". Image preview not displayed. Image uploaded in the /system/images/pending/ folder, and with "/system/images/pending/{image file name}" value in DB.

May 16 2017, 6:18 AM
erik accepted D306: INP-1703 - Set default expiration for font assets.
May 16 2017, 5:43 AM

May 11 2017

alex retitled D306: INP-1703 - Set default expiration for font assets from to INP-1703 - Set default expiration for font assets.
May 11 2017, 6:11 AM

May 10 2017

alex added a comment to D301: INP-1697 - Automate usage of "allow_html" block parameter.
In D301#5975, @erik wrote:

Some issues on test plan:

9.5.C. - No clickable General tab on label editing screen. Button Save used for test.
11.4 - no Label field in the theme editing form (Name field is there)
20.6 - Article excerpt do not use standard inp_edit_textarea control, so it can't be tested this way without some additional changes.

May 10 2017, 6:51 AM
alex updated the test plan for D301: INP-1697 - Automate usage of "allow_html" block parameter.
May 10 2017, 6:50 AM
alex updated the test plan for D301: INP-1697 - Automate usage of "allow_html" block parameter.
May 10 2017, 6:48 AM
erik accepted D301: INP-1697 - Automate usage of "allow_html" block parameter.

Some issues on test plan:

May 10 2017, 6:01 AM

May 9 2017

erik added a comment to D301: INP-1697 - Automate usage of "allow_html" block parameter.

Today tested parts 1..3 only.

May 9 2017, 6:30 AM

May 2 2017

alex updated the test plan for D299: INP-1695 - Automatically generate value for missing "upload_dir" field option.
May 2 2017, 8:12 AM
alex updated the test plan for D299: INP-1695 - Automatically generate value for missing "upload_dir" field option.
May 2 2017, 8:12 AM
erik accepted D302: INP-1698 - Allow using CKEditor and CodeMirror on same textarea.
May 2 2017, 5:37 AM
erik accepted D303: INP-1699 - Don't cache language/theme while in temp mode.
May 2 2017, 5:15 AM
erik accepted D304: INP-1700 - Translate invalid username phrase.
May 2 2017, 5:10 AM
alex retitled D304: INP-1700 - Translate invalid username phrase from to INP-1700 - Translate invalid username phrase.
May 2 2017, 4:48 AM

May 1 2017

alex updated the test plan for D301: INP-1697 - Automate usage of "allow_html" block parameter.
May 1 2017, 1:25 PM
alex retitled D303: INP-1699 - Don't cache language/theme while in temp mode from to INP-1699 - Don't cache language/theme while in temp mode.
May 1 2017, 7:17 AM
alex retitled D302: INP-1698 - Allow using CKEditor and CodeMirror on same textarea from to INP-1698 - Allow using CKEditor and CodeMirror on same textarea.
May 1 2017, 6:17 AM
alex retitled D301: INP-1697 - Automate usage of "allow_html" block parameter from to INP-1697 - Automate usage of "allow_html" block parameter.
May 1 2017, 1:52 AM

Apr 30 2017

alex retitled D299: INP-1695 - Automatically generate value for missing "upload_dir" field option from to INP-1695 - Automatically generate value for missing "upload_dir" field option.
Apr 30 2017, 4:01 AM

Apr 29 2017

alex updated the test plan for D298: INP-1694 - Upgrade YUICompressor to v2.4.8.
Apr 29 2017, 6:16 AM
alex retitled D298: INP-1694 - Upgrade YUICompressor to v2.4.8 from to INP-1694 - Upgrade YUICompressor to v2.4.8.
Apr 29 2017, 6:01 AM

Apr 27 2017

erik accepted D296: INP-1693 - Show all performed actions during deployment in synchronization mode.
Apr 27 2017, 5:15 AM

Apr 25 2017

alex accepted D297: INP-1692 - Allow searching pages by their Content Block content.
Apr 25 2017, 6:54 AM
erik updated the diff for D297: INP-1692 - Allow searching pages by their Content Block content.

Made upgrade SQL optimization.

Apr 25 2017, 6:50 AM
erik updated the diff for D297: INP-1692 - Allow searching pages by their Content Block content.

Made all necessary fixes.

Apr 25 2017, 6:37 AM
alex requested changes to D297: INP-1692 - Allow searching pages by their Content Block content.
Apr 25 2017, 6:23 AM
erik updated the test plan for D297: INP-1692 - Allow searching pages by their Content Block content.
Apr 25 2017, 6:08 AM
erik updated the diff for D297: INP-1692 - Allow searching pages by their Content Block content.

Made all requested fixes.

Apr 25 2017, 6:07 AM
alex requested changes to D297: INP-1692 - Allow searching pages by their Content Block content.

Also update test plan:

Apr 25 2017, 3:30 AM

Apr 24 2017

erik retitled D297: INP-1692 - Allow searching pages by their Content Block content from to INP-1692 Allow searching pages by their Content Block content.
Apr 24 2017, 9:38 AM

Apr 22 2017

alex retitled D296: INP-1693 - Show all performed actions during deployment in synchronization mode from to INP-1693 - Show all performed actions during deployment in synchronization mode.
Apr 22 2017, 4:32 AM

Apr 14 2017

alex requested changes to D12: INP-1312 - Mark themes as deleted instead of actually deleting them.
Apr 14 2017, 6:41 AM
erik updated the diff for D12: INP-1312 - Mark themes as deleted instead of actually deleting them.

Filled AddedOn date in themes table.

Apr 14 2017, 6:37 AM
erik updated the diff for D12: INP-1312 - Mark themes as deleted instead of actually deleting them.

Set AddedOn values for themes on install/upgrade.

Apr 14 2017, 6:00 AM
glebs updated the diff for D269: INP-1645 - Create categories during theme scan based on their location in SMS.

Requested changes

Apr 14 2017, 2:21 AM

Apr 13 2017

erik updated the test plan for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Apr 13 2017, 6:06 AM · Restricted Project
erik updated the diff for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Made all requested fixes.

Apr 13 2017, 6:05 AM · Restricted Project

Apr 12 2017

alex requested changes to D284: INP-1669 - Add local "mapper" variable to the "DropDownMapper.Init" method.

Please add corresponding discussion in Confluence.

Apr 12 2017, 6:06 AM · Unknown Object (Project)
erik updated the diff for D11: INP-1313 - Add support for copying content blocks between themes.

Made all requested CS and logic fixes.

Apr 12 2017, 6:06 AM
alex requested changes to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Some of requested changes might need changing the test plan as well.

Apr 12 2017, 6:03 AM · Restricted Project
erik updated the test plan for D11: INP-1313 - Add support for copying content blocks between themes.
Apr 12 2017, 5:49 AM

Apr 11 2017

alex added inline comments to D11: INP-1313 - Add support for copying content blocks between themes.
Apr 11 2017, 8:01 AM
erik added inline comments to D11: INP-1313 - Add support for copying content blocks between themes.
Apr 11 2017, 5:39 AM

Apr 10 2017

erik updated the diff for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Made all requested changes.

Apr 10 2017, 6:07 AM · Restricted Project
erik updated the test plan for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Apr 10 2017, 5:42 AM · Restricted Project
erik updated the test plan for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Apr 10 2017, 5:41 AM · Restricted Project

Apr 6 2017

erik added a comment to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

today made all code changes, but not tested by plan yet

Apr 6 2017, 6:00 AM · Restricted Project

Apr 5 2017

erik accepted D286: INP-1680 - Restore behavior of "Select All" checkbox in "grid_multioptions_filter" grid filter.
Apr 5 2017, 5:33 AM · Unknown Object (Project)
erik accepted D287: INP-1682 - Make "kFormatter::TypeCast" to return "false" when value (not type) is changed.
Apr 5 2017, 5:28 AM
erik accepted D290: INP-1684 - Ignore hidden columns during grid column width saving.
Apr 5 2017, 5:19 AM · Unknown Object (Project)

Apr 4 2017

erik accepted D292: INP-1686 - Don't include timestamp in compiled Admin Skin file.
Apr 4 2017, 6:01 AM
erik accepted D293: INP-1688 - Support both "%s" and "{param_name}" in validation error messages.
Apr 4 2017, 5:45 AM
erik accepted D294: INP-1689 - Use clever scrolling when editing is done in "Same Window" mode.
Apr 4 2017, 5:25 AM · Unknown Object (Project)

Apr 2 2017

ci added a comment to rINP16538: Bug INP-1690 - Remove "Intechnic\" from namespace.

Build #115 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/115/

Apr 2 2017, 9:42 AM
alex committed rMINN16543: [backported] Bug INP-1690 - Remove "Intechnic\" from namespace.
[backported] Bug INP-1690 - Remove "Intechnic\" from namespace
Apr 2 2017, 9:41 AM
alex committed rMINL16542: [backported] Bug INP-1690 - Remove "Intechnic\" from namespace.
[backported] Bug INP-1690 - Remove "Intechnic\" from namespace
Apr 2 2017, 9:39 AM
alex committed rMINC16541: [backported] Bug INP-1690 - Remove "Intechnic\" from namespace.
[backported] Bug INP-1690 - Remove "Intechnic\" from namespace
Apr 2 2017, 9:38 AM
alex committed rMINB16540: [backported] Bug INP-1690 - Remove "Intechnic\" from namespace.
[backported] Bug INP-1690 - Remove "Intechnic\" from namespace
Apr 2 2017, 9:35 AM
ci added a comment to rINP16537: [backported] Fixes INP-1690 - Remove "Intechnic\" from namespace.

Build #114 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/114/

Apr 2 2017, 9:34 AM
alex committed rMCUS16539: [backported] INP-1690 - Bug Remove "Intechnic\" from namespace.
[backported] INP-1690 - Bug Remove "Intechnic\" from namespace
Apr 2 2017, 9:31 AM
alex committed rINP16538: Bug INP-1690 - Remove "Intechnic\" from namespace.
Bug INP-1690 - Remove "Intechnic\" from namespace
Apr 2 2017, 9:29 AM
alex committed rINP16537: [backported] Fixes INP-1690 - Remove "Intechnic\" from namespace.
[backported] Fixes INP-1690 - Remove "Intechnic\" from namespace
Apr 2 2017, 9:21 AM

Mar 31 2017

alex added a project to D285: INP-1670 - Check for empty/null value in "UserHelper::getGroupsWithIPRestrictions" method: Unknown Object (Project).
Mar 31 2017, 6:04 AM · Unknown Object (Project)

Mar 30 2017

erik accepted D285: INP-1670 - Check for empty/null value in "UserHelper::getGroupsWithIPRestrictions" method.
Mar 30 2017, 1:15 PM · Unknown Object (Project)

Mar 29 2017

alex added a project to D284: INP-1669 - Add local "mapper" variable to the "DropDownMapper.Init" method: Unknown Object (Project).
Mar 29 2017, 1:59 AM · Unknown Object (Project)