In D351#6952, @alex wrote:

Test plan requested updates:

• cover auto-usage of Memcached on PHP 7+, when Memcache is configured to be used
• cover usage of new caching backend (all public methods via corresponding kApplication facade methods (e.g. MemcachedCacheHandler::add maps to kApplication::addCache and so on)
  
  I'm not able to test any further, because all data set to cache will auto-expire immediately.

Made requested code fixes. TODO - test plan changes.

Test plan requested updates:

Build #161 finished with FAILURE status: http://ci.in-portal.org/job/in-portal-52x/161/

Condition moved one level up.

Added missing phrase translation.

No matter how I try to follow test plan I'm get getting pages used in test:

Test plan not updated to cover searching through large amount of text.

GROUP_CONCAT usage replaced with concatenation on php level.

You're only testing new code, but existing code isn't tested. The test plan should also cover, that shipping limitations are applied correctly.

Improvement for calculations result caching

Also the test plan doesn't cover a glimpse of what's actually being checked in code. To test what you've done you need to manually change values of corresponding setting via ini_set (to cover each if/else created) before calling new code from startup.php to assert that result is desired number of bytes.

Also update test plan to cover cases, when we're searching last word in large text (more then 65 KB).

No, this error is not related to current task changes.

In D243#6845, @erik wrote:

No strlen error in debugger from changed ValidateRange method. 'FirstName' test value detected as invalid in other validation method (ValidateType) and not passed to ValidateRange method.

No strlen error in debugger from changed ValidateRange method. 'FirstName' test value detected as invalid in other validation method (ValidateType) and not passed to ValidateRange method.

Done refactoring.

Fixed bug in recursive call parameter.

Made filter out all records when incorrect date entered.

The inline comments with NOTE: battle against malformed dates entered by user line above them are actually UX discovered issues, that weren't part of original task, but without fixing them user would be as confused as now thinking that date entered in incorrect format is actually working as filter, when it's not.

Made "Modified By" username output in place of e-mail in the edit forms.

Changed "Modified" output on topic edit form.

Please also separate test plan into smaller fragments to ease testing. One test plan per each In-Portal module would be great.

1. Fixed phrase module.
2. Fixed CS errors.

add charset parameter to html_entity_decode in \PageHelper::makeSearchable

Requested changes

Tested - this change does not affect CKEditor style dropdown in the other themes (default, simple). While testing, cms.css was changed to have width 300px. In the advanced theme dropdown become about square (300x300), and dropdowns in the other themes (default, simple) has no changes.

After discussing with reviewer figured out, that test plan needs to be changed to test, that correct Styles dropdown works in all themes and not advanced theme only.