Page MenuHomeIn-Portal Phabricator
Feed All Stories

Mar 22 2021

alex added a parent revision for D402: MINC-198 - Don't use "continue" inside a "switch" statement: D384: INP-1786 - Don't use "continue" inside a "switch" statement.
Mar 22 2021, 4:09 AM
alex added a child revision for D384: INP-1786 - Don't use "continue" inside a "switch" statement: D402: MINC-198 - Don't use "continue" inside a "switch" statement.
Mar 22 2021, 4:09 AM · Restricted Project
alex requested review of D402: MINC-198 - Don't use "continue" inside a "switch" statement.
Mar 22 2021, 4:07 AM

Mar 18 2021

alex added "INP-1756" JIRA issue(s) to rINP16691: Fixes INP-1756 - Create "Security*" classes for security-related jobs.
Mar 18 2021, 9:29 AM
alex committed rINP16691: Fixes INP-1756 - Create "Security*" classes for security-related jobs.
Fixes INP-1756 - Create "Security*" classes for security-related jobs
Mar 18 2021, 9:29 AM
alex closed D354: INP-1756 - Create "Security*" classes for security-related jobs.
Mar 18 2021, 9:29 AM · Restricted Project

Mar 17 2021

erik requested changes to D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.

Partially tested.
6 records appears in the System Log on one News record export.

  1. Field "ThumbnailImage" is not defined in "n" unit config
  2. Undefined index: ThumbnailImage
  3. Field "FullImage" is not defined in "n" unit config
  4. Undefined index: FullImage
  5. Field "ImageAlt" is not defined in "n" unit config
  6. Undefined index: ImageAlt
Mar 17 2021, 6:04 AM · Restricted Project
erik accepted D400: INP-1800 - Remove duplicate primary theme detection query.

Tested. Parent Section dropdown is not empty, "Home" value is visible in the Parent Section dropdown.

Mar 17 2021, 5:38 AM
alex closed D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Closing in favor of D356.

Mar 17 2021, 3:45 AM · Restricted Project

Mar 16 2021

alex updated the test plan for D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.
Mar 16 2021, 9:22 AM · Restricted Project
alex requested review of D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.
Mar 16 2021, 9:14 AM · Restricted Project
alex added a comment to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Tested/improved current test plan. Please keep adding new test plan parts for non-tested code (in the modules) so that I can continue reviewing this task.

Mar 16 2021, 7:22 AM · Restricted Project
alex added a project to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities: Restricted Project.
Mar 16 2021, 6:47 AM · Restricted Project
alex added inline comments to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 6:46 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 6:35 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 6:33 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 6:27 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 6:24 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 6:00 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 5:50 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 5:37 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 5:25 AM · Restricted Project
alex added inline comments to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 5:21 AM · Restricted Project
alex updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 16 2021, 5:03 AM · Restricted Project
alex added a project to D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs: Restricted Project.
Mar 16 2021, 3:56 AM · Restricted Project
alex added a project to D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation: Restricted Project.
Mar 16 2021, 3:56 AM · Restricted Project
alex committed rINP16690: Fixes INP-1476 - Allow to customize "st_AdminEditButton" tag.
Fixes INP-1476 - Allow to customize "st_AdminEditButton" tag
Mar 16 2021, 3:39 AM
alex added "INP-1476" JIRA issue(s) to rINP16690: Fixes INP-1476 - Allow to customize "st_AdminEditButton" tag.
Mar 16 2021, 3:39 AM
alex closed D129: INP-1476 - Allow to customize "st_AdminEditButton" tag.
Mar 16 2021, 3:38 AM · Restricted Project
alex added "INP-1560" JIRA issue(s) to rINP16689: Fixes INP-1560 - Migrate "mysql" to "mysqli" database type during upgrade.
Mar 16 2021, 3:33 AM
alex committed rINP16689: Fixes INP-1560 - Migrate "mysql" to "mysqli" database type during upgrade.
Fixes INP-1560 - Migrate "mysql" to "mysqli" database type during upgrade
Mar 16 2021, 3:33 AM
alex closed D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.
Mar 16 2021, 3:33 AM
alex added "INP-1654" JIRA issue(s) to rINP16688: Fixes INP-1654 - Handle resource type in System Log.
Mar 16 2021, 3:31 AM
alex committed rINP16688: Fixes INP-1654 - Handle resource type in System Log.
Fixes INP-1654 - Handle resource type in System Log
Mar 16 2021, 3:31 AM
alex closed D270: INP-1654 Handle resource type in System Log.
Mar 16 2021, 3:31 AM
alex added "INP-1702" JIRA issue(s) to rINP16687: Fixes INP-1702 - Validate file type/size during upload on server side.
Mar 16 2021, 3:28 AM
alex committed rINP16687: Fixes INP-1702 - Validate file type/size during upload on server side.
Fixes INP-1702 - Validate file type/size during upload on server side
Mar 16 2021, 3:28 AM

Mar 15 2021

erik added a comment to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Made QA changes, extended test plan.

Mar 15 2021, 10:43 AM · Restricted Project
erik updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 15 2021, 10:41 AM · Restricted Project
erik updated the diff for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

QA Fixes

Mar 15 2021, 10:41 AM · Restricted Project
alex requested review of D400: INP-1800 - Remove duplicate primary theme detection query.
Mar 15 2021, 5:47 AM
alex added "INP-1711" JIRA issue(s) to rINP16686: Fixes INP-1711 - Add vertical scrollbar to "grid_multioptions_filter" filter.
Mar 15 2021, 4:08 AM
alex committed rINP16686: Fixes INP-1711 - Add vertical scrollbar to "grid_multioptions_filter" filter.
Fixes INP-1711 - Add vertical scrollbar to "grid_multioptions_filter" filter
Mar 15 2021, 4:08 AM
alex closed D314: INP-1711 - Add vertical scrollbar to "grid_multioptions_filter" filter.
Mar 15 2021, 4:08 AM · Restricted Project
alex added "INP-1729" JIRA issue(s) to rMINB16685: Bug INP-1729 - Use "preg_replace_callback" instead of "preg_replace" with "e"….
Mar 15 2021, 3:40 AM
alex committed rMINB16685: Bug INP-1729 - Use "preg_replace_callback" instead of "preg_replace" with "e"….
Bug INP-1729 - Use "preg_replace_callback" instead of "preg_replace" with "e"…
Mar 15 2021, 3:40 AM
alex added "INP-1729" JIRA issue(s) to rINP16684: Fixes INP-1729 - Use "preg_replace_callback" instead of "preg_replace" with "e"….
Mar 15 2021, 3:38 AM
alex committed rINP16684: Fixes INP-1729 - Use "preg_replace_callback" instead of "preg_replace" with "e"….
Fixes INP-1729 - Use "preg_replace_callback" instead of "preg_replace" with "e"…
Mar 15 2021, 3:38 AM
alex added "INP-1737" JIRA issue(s) to rINP16683: Fixes INP-1737 - Fallback to category title on primary language in Admin Console.
Mar 15 2021, 3:33 AM
alex committed rINP16683: Fixes INP-1737 - Fallback to category title on primary language in Admin Console.
Fixes INP-1737 - Fallback to category title on primary language in Admin Console
Mar 15 2021, 3:33 AM
alex closed D336: INP-1737 - Fallback to category title on primary language in Admin Console.
Mar 15 2021, 3:33 AM
alex added "INP-1739" JIRA issue(s) to rINP16682: Fixes INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.
Mar 15 2021, 3:27 AM
alex committed rINP16682: Fixes INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.
Fixes INP-1739 - Cache results of "\fckFCKHelper::getStyles" method
Mar 15 2021, 3:27 AM
alex closed D338: INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.
Mar 15 2021, 3:27 AM
alex committed rINP16681: Fixes INP-1740 - Make CKEditor URL preview respect "SEO URL Ending".
Fixes INP-1740 - Make CKEditor URL preview respect "SEO URL Ending"
Mar 15 2021, 3:25 AM
alex added "INP-1740" JIRA issue(s) to rINP16681: Fixes INP-1740 - Make CKEditor URL preview respect "SEO URL Ending".
Mar 15 2021, 3:25 AM
alex closed D339: INP-1740 - Make CKEditor URL preview respect "SEO URL Ending".
Mar 15 2021, 3:25 AM · Restricted Project
alex committed rINP16680: Fixes INP-1793 - Disable output buffering in Console.
Fixes INP-1793 - Disable output buffering in Console
Mar 15 2021, 3:08 AM
alex added "INP-1793" JIRA issue(s) to rINP16680: Fixes INP-1793 - Disable output buffering in Console.
Mar 15 2021, 3:08 AM
alex closed D391: INP-1793 - Disable output buffering in Console.
Mar 15 2021, 3:08 AM · Restricted Project

Mar 12 2021

erik updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 1:00 PM · Restricted Project
erik added inline comments to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 12:17 PM · Restricted Project
alex committed rINP16679: Fixes INP-1741 - Vertically align grid icons.
Fixes INP-1741 - Vertically align grid icons
Mar 12 2021, 10:36 AM
alex added "INP-1741" JIRA issue(s) to rINP16679: Fixes INP-1741 - Vertically align grid icons.
Mar 12 2021, 10:36 AM
alex closed D340: INP-1741 - Vertically align grid icons.
Mar 12 2021, 10:36 AM · Restricted Project
alex committed rMINN16678: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
Mar 12 2021, 10:31 AM
alex added "INP-1745" JIRA issue(s) to rMINN16678: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Mar 12 2021, 10:31 AM
alex added "INP-1745" JIRA issue(s) to rMINL16677: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Mar 12 2021, 10:30 AM
alex committed rMINL16677: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
Mar 12 2021, 10:30 AM
alex committed rMINC16676: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
Mar 12 2021, 10:30 AM
alex added "INP-1745" JIRA issue(s) to rMINC16676: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Mar 12 2021, 10:30 AM
alex added "INP-1745" JIRA issue(s) to rMINB16675: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Mar 12 2021, 10:30 AM
alex committed rMINB16675: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
Mar 12 2021, 10:30 AM
alex added "INP-1745" JIRA issue(s) to rINP16674: Fixes INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Mar 12 2021, 10:30 AM
alex committed rINP16674: Fixes INP-1745 - Connect "Modified" and "ModifiedById" fields to Links.
Fixes INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
Mar 12 2021, 10:30 AM
alex closed D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
Mar 12 2021, 10:30 AM
alex added "INP-1752" JIRA issue(s) to rMINC16673: Bug INP-1752 - Update sub-class method signatures to match overridden methods….
Mar 12 2021, 10:22 AM
alex committed rMINC16673: Bug INP-1752 - Update sub-class method signatures to match overridden methods….
Bug INP-1752 - Update sub-class method signatures to match overridden methods…
Mar 12 2021, 10:22 AM
alex committed rINP16672: Fixes INP-1752 - Update sub-class method signatures to match overridden methods….
Fixes INP-1752 - Update sub-class method signatures to match overridden methods…
Mar 12 2021, 10:22 AM
alex added "INP-1752" JIRA issue(s) to rINP16672: Fixes INP-1752 - Update sub-class method signatures to match overridden methods….
Mar 12 2021, 10:22 AM
alex closed D352: INP-1752 - Update sub-class method signatures to match overridden methods in parent class.
Mar 12 2021, 10:22 AM · Restricted Project
alex requested changes to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 5:25 AM · Restricted Project
erik updated the diff for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Added system user check to session LoggedIn method.

Mar 12 2021, 1:54 AM · Restricted Project

Mar 11 2021

erik requested review of D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 11 2021, 10:47 AM · Restricted Project

Mar 8 2021

erik accepted D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message.
Mar 8 2021, 4:42 AM · Restricted Project

Mar 4 2021

alex added a project to D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message: Restricted Project.
Mar 4 2021, 11:32 AM · Restricted Project
alex requested review of D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message.
Mar 4 2021, 11:31 AM · Restricted Project
alex updated the test plan for D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 7:22 AM
alex updated the diff for D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Fixed outdating sorting resetting code on report change. Before the fix user would have got an SQL error.

Mar 4 2021, 7:20 AM
erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:48 AM
alex requested review of D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:33 AM
alex updated the diff for D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Removed artifacts resulted after adding numberic IDField to every report grid:

Mar 4 2021, 5:32 AM
alex planned changes to D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:29 AM

Mar 3 2021

alex added a comment to D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
In D397#7804, @erik wrote:

Test plan is all right. But, beyond this patch, exists SQL error when doing "View Chart" for "By Product" and "By Section" cases. Problematic SQL is like

SELECT LEFT(c.l1_Name, 60) AS Name, c.CategoryId, SUM() as Metric
   FROM inp_Orders AS o
   LEFT JOIN inp_OrderItems AS od ON od.OrderId = o.OrderId
   LEFT JOIN inp_Products AS p ON p.ProductId = od.ProductId
   LEFT JOIN inp_CategoryItems AS ci ON ci.ItemResourceId = p.ResourceId
   LEFT JOIN inp_Categories AS c ON c.CategoryId = ci.CategoryId
   WHERE o.Status IN (4,6) AND o.OrderDate >= 1614718800 AND o.OrderDate <= 1614805199
   GROUP BY c.CategoryId
   HAVING NOT ISNULL(CategoryId)
   ORDER BY Metric DESC

There is "SUM() as Metric" column, where SUM argument is missing.

Mar 3 2021, 1:26 PM
erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Test plan is all right. But, beyond this patch, exists SQL error when doing "View Chart" for "By Product" and "By Section" cases. Problematic SQL is like

Mar 3 2021, 9:14 AM
alex updated the test plan for D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 3 2021, 7:34 AM
alex requested review of D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 3 2021, 6:16 AM
erik accepted D390: INP-1792 - Support HTML markup with Title Presets.
Mar 3 2021, 5:04 AM
erik accepted D391: INP-1793 - Disable output buffering in Console.
Mar 3 2021, 4:56 AM · Restricted Project
erik accepted D396: INP-1797 - Speed up formatter class access from "kDBItem".
Mar 3 2021, 4:48 AM · Restricted Project