Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1026034
D372.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Fri, Jun 13, 6:13 PM
Size
1 KB
Mime Type
text/x-diff
Expires
Sat, Jun 14, 6:13 PM (4 h, 45 m)
Engine
blob
Format
Raw Data
Handle
661680
Attached To
D372: INP-1774 - Display scaled down file size in uploader
D372.diff
View Options
Index: core/admin_templates/js/uploader/uploader.js
===================================================================
--- core/admin_templates/js/uploader/uploader.js
+++ core/admin_templates/js/uploader/uploader.js
@@ -616,8 +616,9 @@
return ;
}
- // new uploaded file name returned by OnUploadFile event
+ // new uploaded file name/size returned by OnUploadFile event
file.name = $json_response.result;
+ file.size = $json_response.size;
this.onUploadFileComplete(file);
};
Index: core/kernel/db/db_event_handler.php
===================================================================
--- core/kernel/db/db_event_handler.php
+++ core/kernel/db/db_event_handler.php
@@ -3151,12 +3151,13 @@
$upload_helper = $this->Application->recallObject('kUploadHelper');
try {
- $filename = $upload_helper->handle($event);
+ list($filename, $size) = $upload_helper->handle($event);
$response = array(
'jsonrpc' => '2.0',
'status' => 'success',
'result' => $filename,
+ 'size' => $size,
);
}
catch ( kUploaderException $e ) {
Index: core/units/helpers/upload_helper.php
===================================================================
--- core/units/helpers/upload_helper.php
+++ core/units/helpers/upload_helper.php
@@ -40,7 +40,7 @@
*
* @param kEvent $event Event.
*
- * @return string
+ * @return array
* @throws kUploaderException When upload could not be handled properly.
*/
public function handle(kEvent $event)
@@ -105,7 +105,11 @@
$this->deleteTempFiles($thumbs_path);
}
- return preg_replace('/^' . preg_quote($id, '/') . '_/', '', $filename);
+ // Add display name/size of uploaded file.
+ return array(
+ preg_replace('/^' . preg_quote($id, '/') . '_/', '', $filename),
+ filesize($file_path),
+ );
}
/**
Event Timeline
Log In to Comment