Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1102170
D514.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Mon, Aug 18, 2:54 AM
Size
902 B
Mime Type
text/x-diff
Expires
Tue, Aug 19, 2:54 AM (53 m, 38 s)
Engine
blob
Format
Raw Data
Handle
713690
Attached To
D514: INP-1822 - Use modern cookie encryption library
D514.diff
View Options
Index: core/kernel/session/session.php
===================================================================
--- core/kernel/session/session.php
+++ core/kernel/session/session.php
@@ -387,9 +387,15 @@
$this->_autoGuessDomain(SERVER_NAME)
);
- /** @var CookieManager $cookie_manager */
- $cookie_manager = $this->Application->recallObject('CookieManager');
- $encrypted_value = $cookie_manager->encryptAndTrack($name, $value);
+ // Allow auto-removal of cookies with empty value that encryption would otherwise block.
+ if ( $value === '' ) {
+ $encrypted_value = '';
+ }
+ else {
+ /** @var CookieManager $cookie_manager */
+ $cookie_manager = $this->Application->recallObject('CookieManager');
+ $encrypted_value = $cookie_manager->encryptAndTrack($name, $value);
+ }
foreach ($old_style_domains as $old_style_domain) {
if ($this->CookieDomain != $old_style_domain) {
Event Timeline
Log In to Comment