Page MenuHomeIn-Portal Phabricator
Files F847917

D216.diff
No OneTemporary
Actions

File Metadata

Created
Sat, Apr 19, 7:49 PM

D216.diff
View Options

Index: branches/5.2.x/units/helpers/order_helper.php
===================================================================
--- branches/5.2.x/units/helpers/order_helper.php
+++ branches/5.2.x/units/helpers/order_helper.php
@@ -169,15 +169,33 @@
}
/**
- * Detects credit card type by it's number
+ * Detects credit card type by it's number.
*
- * @param string $number
- * @return int
- * @access public
+ * @param string $number Credit card number.
+ *
+ * @return integer
+ * @deprecated
*/
public function getCreditCartType($number)
{
- // Get rid of any non-digits
+ @trigger_error(
+ 'Usage of deprecated method OrderHelper::getCreditCartType. Use OrderHelper::getCreditCardType.',
+ E_USER_DEPRECATED
+ );
+
+ return $this->getCreditCardType($number);
+ }
+
+ /**
+ * Detects credit card type by it's number.
+ *
+ * @param string $number Credit card number.
+ *
+ * @return integer
+ */
+ public function getCreditCardType($number)
+ {
+ // Get rid of any non-digits.
$number = preg_replace('/[^\d]/', '', $number);
$mapping = Array (
Index: branches/5.2.x/units/orders/orders_event_handler.php
===================================================================
--- branches/5.2.x/units/orders/orders_event_handler.php
+++ branches/5.2.x/units/orders/orders_event_handler.php
@@ -2528,7 +2528,10 @@
$order_helper = $this->Application->recallObject('OrderHelper');
/* @var $order_helper OrderHelper */
- $object->SetDBField('PaymentCardType', $order_helper->getCreditCartType($object->GetDBField('PaymentAccount')));
+ $object->SetDBField(
+ 'PaymentCardType',
+ $order_helper->getCreditCardType($object->GetDBField('PaymentAccount'))
+ );
}
else {
$object->SetDBField('PaymentCardType', '');

Event Timeline

In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server