Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1171389
D524.id1344.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Sun, Sep 28, 12:52 AM
Size
692 B
Mime Type
text/x-diff
Expires
Mon, Sep 29, 12:52 AM (13 h, 40 m)
Engine
blob
Format
Raw Data
Handle
759014
Attached To
D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method
D524.id1344.diff
View Options
Index: core/kernel/managers/url_manager.php
===================================================================
--- core/kernel/managers/url_manager.php
+++ core/kernel/managers/url_manager.php
@@ -464,8 +464,8 @@
$not_found = $this->Application->ConfigValue('ErrorTemplate');
$template = $not_found ? $not_found : 'error_notfound';
- // Avoid recursion, when attempt is made to show 404 page while on the 404 page.
- if ( $this->Application->GetVar('t') === $template ) {
+ // Avoid recursion when requesting 404-page from a 404-page template rendering process.
+ if ( is_object($this->Application->Parser) && $this->Application->GetVar('t') === $template ) {
return;
}
Event Timeline
Log In to Comment