Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1025968
D285.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Fri, Jun 13, 5:38 PM
Size
520 B
Mime Type
text/x-diff
Expires
Sat, Jun 14, 5:38 PM (4 h, 6 m)
Engine
blob
Format
Raw Data
Handle
661630
Attached To
D285: INP-1670 - Check for empty/null value in "UserHelper::getGroupsWithIPRestrictions" method
D285.diff
View Options
Index: branches/5.2.x/core/units/helpers/user_helper.php
===================================================================
--- branches/5.2.x/core/units/helpers/user_helper.php
+++ branches/5.2.x/core/units/helpers/user_helper.php
@@ -270,7 +270,7 @@
if ( !isset($cache) ) {
$sql = 'SELECT IPRestrictions, GroupId
FROM ' . TABLE_PREFIX . 'UserGroups
- WHERE IPRestrictions IS NOT NULL';
+ WHERE COALESCE(IPRestrictions, "") <> ""';
$cache = $this->Conn->GetCol($sql, 'GroupId');
}
Event Timeline
Log In to Comment