Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1098912
D160.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Thu, Aug 14, 7:30 AM
Size
1 KB
Mime Type
text/x-diff
Expires
Fri, Aug 15, 7:30 AM (3 h, 18 m)
Engine
blob
Format
Raw Data
Handle
709317
Attached To
D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method
D160.id.diff
View Options
Index: branches/5.2.x/core/kernel/db/cat_event_handler.php
===================================================================
--- branches/5.2.x/core/kernel/db/cat_event_handler.php
+++ branches/5.2.x/core/kernel/db/cat_event_handler.php
@@ -2652,24 +2652,17 @@
if ( $ids ) {
foreach ($ids as $id) {
- $ret = true;
$object->Load($id);
switch ( $event->Name ) {
case 'OnMassApprove':
- $ret = $object->ApproveChanges();
+ $object->ApproveChanges();
break;
case 'OnMassDecline':
- $ret = $object->DeclineChanges();
+ $object->DeclineChanges();
break;
}
-
- if ( !$ret ) {
- $event->status = kEvent::erFAIL;
- $event->redirect = false;
- break;
- }
}
}
Index: branches/5.2.x/core/kernel/db/db_event_handler.php
===================================================================
--- branches/5.2.x/core/kernel/db/db_event_handler.php
+++ branches/5.2.x/core/kernel/db/db_event_handler.php
@@ -2278,14 +2278,7 @@
break;
}
- if ( $object->Update() ) {
- $event->status = kEvent::erSUCCESS;
- }
- else {
- $event->status = kEvent::erFAIL;
- $event->redirect = false;
- break;
- }
+ $object->Update();
}
}
Index: branches/5.2.x/core/units/categories/categories_event_handler.php
===================================================================
--- branches/5.2.x/core/units/categories/categories_event_handler.php
+++ branches/5.2.x/core/units/categories/categories_event_handler.php
@@ -1594,16 +1594,9 @@
$this->Conn->Query($sql);
}
- $event->status = kEvent::erSUCCESS;
-
$email_event = $event->Name == 'OnMassApprove' ? 'CATEGORY.APPROVE' : 'CATEGORY.DENY';
$this->Application->emailUser($email_event, $object->GetDBField('CreatedById'));
}
- else {
- $event->status = kEvent::erFAIL;
- $event->redirect = false;
- break;
- }
}
}
Event Timeline
Log In to Comment