Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1046747
D186.id653.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Sun, Jun 29, 3:56 AM
Size
916 B
Mime Type
text/x-diff
Expires
Mon, Jun 30, 3:56 AM (4 h, 38 m)
Engine
blob
Format
Raw Data
Handle
676736
Attached To
D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine
D186.id653.diff
View Options
Index: modules/in-commerce/units/shipping_quote_engines/shipping_quote_collector.php
===================================================================
--- modules/in-commerce/units/shipping_quote_engines/shipping_quote_collector.php
+++ modules/in-commerce/units/shipping_quote_engines/shipping_quote_collector.php
@@ -17,10 +17,9 @@
function GetShippingQuotes($params)
{
+ /** @var kCountryStatesHelper $cs_helper */
$cs_helper = $this->Application->recallObject('CountryStatesHelper');
- /* @var $cs_helper kCountryStatesHelper */
-
- $has_states = $cs_helper->CountryHasStates( $cs_helper->getCountryIso($params['dest_country'], true) );
+ $has_states = $cs_helper->CountryHasStates($params['dest_country']);
if (
!$params['dest_city'] || !$params['dest_country'] ||
@@ -194,4 +193,4 @@
return $elem1['TotalCost'] < $elem2['TotalCost'] ? -1 : 1;
}
-}
\ No newline at end of file
+}
Event Timeline
Log In to Comment