Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F803926
D462.id1192.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Wed, Feb 26, 9:01 AM
Size
587 B
Mime Type
text/x-diff
Expires
Thu, Feb 27, 9:01 AM (7 h, 48 m)
Engine
blob
Format
Raw Data
Handle
576646
Attached To
D462: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method
D462.id1192.diff
View Options
Index: core/kernel/managers/url_manager.php
===================================================================
--- core/kernel/managers/url_manager.php
+++ core/kernel/managers/url_manager.php
@@ -464,6 +464,11 @@
$not_found = $this->Application->ConfigValue('ErrorTemplate');
$template = $not_found ? $not_found : 'error_notfound';
+ // Avoid recursion, when attempt is made to show 404 page while on the 404 page.
+ if ( $this->Application->GetVar('t') === $template ) {
+ return;
+ }
+
$this->Application->QuickRun($template);
$this->Application->Done();
exit;
Event Timeline
Log In to Comment