Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1025969
D286.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Fri, Jun 13, 5:38 PM
Size
992 B
Mime Type
text/x-diff
Expires
Sat, Jun 14, 5:38 PM (4 h, 8 m)
Engine
blob
Format
Raw Data
Handle
661631
Attached To
D286: INP-1680 - Restore behavior of "Select All" checkbox in "grid_multioptions_filter" grid filter
D286.diff
View Options
Index: branches/5.2.x/core/admin_templates/js/grid_filters.js
===================================================================
--- branches/5.2.x/core/admin_templates/js/grid_filters.js
+++ branches/5.2.x/core/admin_templates/js/grid_filters.js
@@ -88,7 +88,7 @@
MultiOptions.SelectAll($cur_index);
}
)
- .prop('checked', $options.length == $options.filter(':selected').length > 0);
+ .prop('checked', $options.length == $options.filter(':selected').length);
$('input._mutlioptions_cb_' + $cur_index).click(
function ($e) {
@@ -137,7 +137,7 @@
var $select_all = $('#_mutlioptions_cb_' + selector_index + '_all');
var $options = $("input[type='checkbox']", '#' + jq(MultiOptions.Selectors[selector_index]) + '_div').not($select_all);
- $select_all.prop('checked', $options.length == $options.filter(':checked').length > 0);
+ $select_all.prop('checked', $options.length == $options.filter(':checked').length);
}
MultiOptions.SelectAll = function(selector_index) {
Event Timeline
Log In to Comment