Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1171919
D311.id750.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Sun, Sep 28, 6:33 PM
Size
698 B
Mime Type
text/x-diff
Expires
Mon, Sep 29, 6:33 PM (22 h, 3 m)
Engine
blob
Format
Raw Data
Handle
759444
Attached To
D311: INP-1708 - Ignore crop/fill parameters during image resize, when they have no effect
D311.id750.diff
View Options
Index: core/units/helpers/image_helper.php
===================================================================
--- core/units/helpers/image_helper.php
+++ core/units/helpers/image_helper.php
@@ -123,6 +123,15 @@
$params['max_height'] = $params['target_height'];
}
+ // Optimize, because when cropping from center without resize we'll get same image back.
+ if ( !$needs_resize
+ && isset($params['crop_x'])
+ && $params['crop_x'] == 'c'
+ && $params['crop_y'] == 'c'
+ ) {
+ unset($params['crop_x'], $params['crop_y'], $params['fill']);
+ }
+
$src_path = dirname($src_image);
$transform_keys = Array ('crop_x', 'crop_y', 'fill', 'wm_filename');
Event Timeline
Log In to Comment