Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1046555
D349.id869.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Sat, Jun 28, 8:41 PM
Size
1 KB
Mime Type
text/x-diff
Expires
Sun, Jun 29, 8:41 PM (8 h, 6 m)
Engine
blob
Format
Raw Data
Handle
676575
Attached To
D349: INP-1721 Correct math for detecting allowed file size during upload
D349.id869.diff
View Options
Index: core/kernel/globals.php
===================================================================
--- core/kernel/globals.php
+++ core/kernel/globals.php
@@ -997,6 +997,33 @@
}
}
+ /**
+ * Parse ini size
+ *
+ * @param string $size Size.
+ *
+ * @return integer
+ */
+ public static function parseIniSize($size)
+ {
+ $result = (int)$size;
+ $size = strtolower($size);
+
+ if ( strpos($size, 'k') ) {
+ return $result * 1024;
+ }
+
+ if ( strpos($size, 'm') ) {
+ return $result * 1024 * 1024;
+ }
+
+ if ( strpos($size, 'g') ) {
+ return $result * 1024 * 1024 * 1024;
+ }
+
+ return $result;
+ }
+
}
/**
Index: core/kernel/startup.php
===================================================================
--- core/kernel/startup.php
+++ core/kernel/startup.php
@@ -114,7 +114,13 @@
define('IMAGES_PATH', WRITEBALE_BASE . '/images/');
define('IMAGES_PENDING_PATH', IMAGES_PATH . 'pending/');
- define('MAX_UPLOAD_SIZE', min(ini_get('upload_max_filesize'), ini_get('post_max_size'))*1024*1024);
+
+ $upload_limit = kUtil::parseIniSize(ini_get('upload_max_filesize'));
+ $post_max_size = ini_get('post_max_size');
+ $upload_limit = $post_max_size !== '0' ? min($upload_limit, kUtil::parseIniSize($post_max_size)) : $upload_limit;
+ $memory_limit = ini_get('memory_limit');
+ $upload_limit = $memory_limit !== '-1' ? min($upload_limit, kUtil::parseIniSize($memory_limit)) : $upload_limit;
+ define('MAX_UPLOAD_SIZE', $upload_limit);
define('EDITOR_PATH', $vars['EditorPath']);
Event Timeline
Log In to Comment