Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1098207
D534.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Wed, Aug 13, 11:33 AM
Size
3 KB
Mime Type
text/x-diff
Expires
Thu, Aug 14, 11:33 AM (15 h, 10 m)
Engine
blob
Format
Raw Data
Handle
711147
Attached To
D534: INP-1920 - Ensure consistent named tab preset usage
D534.id.diff
View Options
Index: branches/5.2.x/core/admin_templates/submissions/submission_view.tpl
===================================================================
--- branches/5.2.x/core/admin_templates/submissions/submission_view.tpl
+++ branches/5.2.x/core/admin_templates/submissions/submission_view.tpl
@@ -3,11 +3,7 @@
<inp2:m_include t="incs/header"/>
<inp2:m_Get var="form_id" result_to_var="form_id"/>
-<inp2:m_if check="form_Field" name="EnableEmailCommunication" db="db">
- <inp2:m_RenderElement name="combined_header" prefix="formsubs" section="in-portal:submissions:$form_id" title_preset="formsubs_view" tab_preset="Default"/>
-<inp2:m_else/>
- <inp2:m_RenderElement name="combined_header" prefix="formsubs" section="in-portal:submissions:$form_id" title_preset="formsubs_view"/>
-</inp2:m_if>
+<inp2:m_RenderElement name="combined_header" prefix="formsubs" section="in-portal:submissions:$form_id" title_preset="formsubs_view" tab_preset="Default"/>
<!-- ToolBar -->
<table class="toolbar" height="30" cellspacing="0" cellpadding="0" width="100%" border="0">
Index: branches/5.2.x/core/units/forms/form_submissions/form_submission_tp.php
===================================================================
--- branches/5.2.x/core/units/forms/form_submissions/form_submission_tp.php
+++ branches/5.2.x/core/units/forms/form_submissions/form_submission_tp.php
@@ -57,4 +57,29 @@
return $form_submission_helper->getFieldByName($object, $params['name'], $formatted, $format);
}
+
+ /**
+ * @inheritDoc
+ */
+ public function ModifyUnitConfig($params)
+ {
+ parent::ModifyUnitConfig($params);
+
+ $tab_preset = $params['tab_preset'];
+ $form_id = $this->Application->GetVar('form_id');
+
+ if ( $tab_preset && $form_id ) {
+ /** @var kDBItem $form */
+ $form = $this->Application->recallObject('form');
+
+ // Hides the "Messages" tab, when e-mail communication not enabled on the associated form.
+ if ( !$form->GetDBField('EnableEmailCommunication') ) {
+ /** @var array $edit_tab_presets */
+ $edit_tab_presets = $this->Application->getUnitOption($this->Prefix, 'EditTabPresets', array());
+ unset($edit_tab_presets[$tab_preset]['messages']);
+ $this->Application->setUnitOption($this->Prefix, 'EditTabPresets', $edit_tab_presets);
+ }
+ }
+ }
+
}
Index: branches/5.2.x/core/units/forms/form_submissions/form_submissions_config.php
===================================================================
--- branches/5.2.x/core/units/forms/form_submissions/form_submissions_config.php
+++ branches/5.2.x/core/units/forms/form_submissions/form_submissions_config.php
@@ -89,8 +89,8 @@
'EditTabPresets' => Array (
'Default' => Array (
- Array ('title' => 'la_tab_General', 't' => 'submissions/submission_view', 'priority' => 1),
- Array ('title' => 'la_tab_Messages', 't' => 'submissions/submission_edit_logs', 'priority' => 2),
+ 'general' => Array ('title' => 'la_tab_General', 't' => 'submissions/submission_view', 'priority' => 1),
+ 'messages' => Array ('title' => 'la_tab_Messages', 't' => 'submissions/submission_edit_logs', 'priority' => 2),
),
),
Event Timeline
Log In to Comment