Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1403736
D558.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Wed, Feb 25, 9:09 AM
Size
1 KB
Mime Type
text/x-diff
Expires
Thu, Feb 26, 9:09 AM (18 h, 53 m)
Engine
blob
Format
Raw Data
Handle
899425
Attached To
D558: INP-1924 - Test Suite freezes when executed without an Internet Connection
D558.diff
View Options
Index: branches/5.2.x/core/tests/Unit/kernel/globalsTest.php
===================================================================
--- branches/5.2.x/core/tests/Unit/kernel/globalsTest.php
+++ branches/5.2.x/core/tests/Unit/kernel/globalsTest.php
@@ -28,9 +28,9 @@
protected function hasInternetConnectivity()
{
- // Use IP of the "www.google.com" hostname to avoid DNS query, that might fail.
+ // Use IP of the Cloudflare DNS hostname to avoid DNS query, that might fail.
$error_code = $error_message = null;
- $fp = @fsockopen('142.250.74.36', 443, $error_code, $error_message, 5);
+ $fp = @fsockopen('1.1.1.1', 443, $error_code, $error_message, 5);
if ( $fp ) {
fclose($fp);
Index: branches/5.2.x/core/tests/Unit/kernel/utility/DebuggerUtilTest.php
===================================================================
--- branches/5.2.x/core/tests/Unit/kernel/utility/DebuggerUtilTest.php
+++ branches/5.2.x/core/tests/Unit/kernel/utility/DebuggerUtilTest.php
@@ -24,9 +24,9 @@
protected function hasInternetConnectivity()
{
- // Use IP of the "www.google.com" hostname to avoid DNS query, that might fail.
+ // Use IP of the Cloudflare DNS hostname to avoid DNS query, that might fail.
$error_code = $error_message = null;
- $fp = @fsockopen('142.250.74.36', 443, $error_code, $error_message, 5);
+ $fp = @fsockopen('1.1.1.1', 443, $error_code, $error_message, 5);
if ( $fp ) {
fclose($fp);
Event Timeline
Log In to Comment