Differential D103

INP-1453 Allow using "AdminEditButton" tag several times for same item
ClosedPublic
Actions

Authored by glebs on Jul 31 2015, 2:04 AM.

Details

Reviewers

alex

Commits

rINP16260: Fixes INP-1453 - Multiple AdminEditButton for same item doesn't work properly

Test Plan

Test using inportal with advanced theme

Create new link in Website & Content → Structure & Data → Directory section
In themes/advanced/in-link/elements/links.elm.tpl add <inp2:AdminEditButton test="testvalue"/> just after <inp2:AdminEditButton/>
Goto Website & Content → Browse Website, navigate to Directory section and switch to Content Mode
Open Network tab in browser developer tools
Click on first Edit Item button near created link and check url with OnEdit event doesn't contains test=testvalue
Click on second Edit Item button near created link and check url with OnEdit event contains test=testvalue

Diff Detail

Repository

rINP In-Portal

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

glebs updated this revision to Diff 243.Jul 31 2015, 2:04 AM

glebs retitled this revision from to INP-1453 Multiple AdminEditButton for same item doesn't work properly.

glebs updated this object.

glebs edited the test plan for this revision. (Show Details)

glebs added 1 JIRA issue(s): INP-1453.

Herald added a reviewer: alex. · View Herald TranscriptJul 31 2015, 2:04 AM

glebs edited the test plan for this revision. (Show Details)Jul 31 2015, 2:05 AM

glebs edited edge metadata.

alex accepted this revision.Sep 18 2015, 7:03 AM

alex edited edge metadata.

This revision is now accepted and ready to land.Sep 18 2015, 7:03 AM

Closed by commit rINP16260: Fixes INP-1453 - Multiple AdminEditButton for same item doesn't work properly (authored by alex). · Explain WhySep 27 2015, 2:39 AM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 5:48 AM

alex added a project: Restricted Project.

alex retitled this revision from INP-1453 Multiple AdminEditButton for same item doesn't work properly to INP-1453 Allow using "AdminEditButton" tag several times for same item.Jul 16 2016, 7:13 AM

Revision Contents
Changeset List

			Path	Packages
M			branches/5.2.x/core/kernel/db/db_tag_processor.php (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	243	16206		Jul 31 2015, 2:04 AM	★	★
Diff 2	324	16259	Commit rINP16260	Sep 27 2015, 2:39 AM	★	★

Diff 324

View Options

branches/5.2.x/core/kernel/db/db_tag_processor.php

INP-1453 Allow using "AdminEditButton" tag several times for same itemClosedPublicActions