INP-1492 - Replace "%2$s" with current language in "kDBList::extractCalculatedFields" method
ClosedPublic
Actions

Authored by alex on Oct 3 2015, 5:39 AM.

Details

Reviewers

glebs

Commits

Test Plan

in PhpStorm:
1. comment out the di:OnAfterConfigRead event
2. change ItemName calculated field (of di unit) declaration into 'IF(p.Name IS NULL,c.l%2$s_Name,p.l%2$s_Name)'
in Admin Console:
1. go to E-commerce → Discounts & Certificates section
2. create discount, that has 1 product
3. confirm, that product name is displayed correctly on Items tab during discount editing
4. use Item Name column filter to search for letter present in product name
5. confirm, that product is displayed and no SQL error present in Debugger
6. use Item Name column filter to search for letter not present in product name
7. confirm, that product isn't displayed and no SQL error present in Debugger
8. remove grid search filter
in PhpStorm:
1. create the DiscountItemsEventHandler::SetCustomQuery method in which apply HAVING filter to the ItemName column (e.g. $object->addFilter('test_filter', 'ItemName LIKE ' . $this->Conn->qstr('z'), kDBList::HAVING_FILTER);)
2. confirm, that no SQL error happens and data is filtered as expected