Page MenuHomeIn-Portal Phabricator

INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control
ClosedPublic

Authored by glebs on Nov 13 2015, 2:12 AM.

Details

Test Plan

Part 1

  1. make clean install of In-Portal version 5.2.1
  2. update In-Portal files to latest 5.2.x version
  3. apply patch
  4. make In-Portal upgrade
  5. in /core/admin_templates/categories/categories_edit.tpl template change inp_edit_options to inp_edit_checkboxes for ParentId field
  6. open for editing any category and check that text after checkboxes in ParentId field doesn't wrap to next line, when it's long

Part 2

  1. make clean install of In-Portal version 5.2.x
  2. apply patch
  3. in /core/admin_templates/categories/categories_edit.tpl template change inp_edit_options to inp_edit_checkboxes for ParentId field
  4. open for editing any category and check that text after checkboxes in ParentId field doesn't wrap to next line, when it's long

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

glebs updated this revision to Diff 411.Nov 13 2015, 2:12 AM
glebs retitled this revision from to INP-1513 Fix wrong line wrapping in inp_edit_checkboxes.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1513.
alex requested changes to this revision.EditedNov 13 2015, 3:23 AM
alex edited edge metadata.

The test plan:

  • doesn't include steps for testing clean install/upgrade
  • doesn't work (I've tried to do as written in test plan and problem is still there)

The rINP15434 commit can be used as reference, when performing requested fixes.

Typical workflow, when making CSS-related changes:

  1. make a change to the /core/admin_templates/incs/style_template.css file
  2. go to /core/admin_templates/incs directory
  3. create patch using following command: svn diff style_template.css > x.patch
  4. open /core/install/upgrades.css file for editing (not in editor, that strips whitespaces on empty lines)
  5. add standard version comment (e.g. # ===== v 5.2.2 =====) if missing
  6. put contents of above created patch file after it and save changes
  7. copy over contents of styke_template.css file (except file comment) into the primary skin
  8. export primary skin record (e.g. via phpMyAdmin) as INSERT INTO statement
  9. replace existing INSERT INTO statement into Skins table in the /core/install/install_data.sql file (replace actual ID with DEFAULT keyword)
  10. perform clean install to confirm, that skin contains correct CSS
  11. perform install of previous In-Portal version and upgrade to current one to confirm, that skin was patched to include correct CSS
core/admin_templates/incs/style_template.css
552–555 ↗(On Diff #411)

Please use TABs for indentation.

core/install/upgrades.css
818 ↗(On Diff #411)

Don't save changes to PATCH files in the PhpStorm.


PhpStorm strips lines that contain whitespaces only from PATCH files on save and therefore other editor is recommended for editing them.

821 ↗(On Diff #411)

Please use 5.2.2-B1 version here.


Associated task is scheduled to be committed into 5.2.2-B1 version.

This revision now requires changes to proceed.Nov 13 2015, 3:23 AM
glebs updated this revision to Diff 422.Nov 19 2015, 2:28 AM
glebs edited edge metadata.

Made requested changes

glebs edited the test plan for this revision. (Show Details)Nov 19 2015, 2:30 AM
glebs edited edge metadata.
alex added a project: Restricted Project.Mar 10 2016, 5:24 AM
alex retitled this revision from INP-1513 Fix wrong line wrapping in inp_edit_checkboxes to INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control.Jul 16 2016, 7:03 AM
alex edited the test plan for this revision. (Show Details)Nov 19 2016, 8:59 AM
alex edited the test plan for this revision. (Show Details)
alex accepted this revision.Nov 19 2016, 12:38 PM
alex edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2016, 12:38 PM
This revision was automatically updated to reflect the committed changes.