Page MenuHomeIn-Portal Phabricator

INP-1526 - Don't call "kDBEventHandler::checkItemStatus" when ID doesn't come from Web Request
ClosedPublic

Authored by alex on Jan 20 2016, 6:12 AM.

Details

Test Plan

Overall goals:

  • each placed breakpoint must be reached
  • the kEvent::FLAG_ID_FROM_REQUEST flag must always be set, when ID comes from Web Request
  • when above flag is set the "checkItemStatus" method must be called (unless we're in app initialization)

in PhpStorm

Place breakpoint in every place, where kEvent::FLAG_ID_FROM_REQUEST flag is being set (these are getPassedID or methods called from within it).

in Admin Console

  1. go to ConfigurationWebsiteAdvanced section
  2. turn off Enable SEO-friendly URLs mode (MOD-REWRITE) setting
  3. save changes
  4. enable debug mode

Front-End (the "advanced" theme) breakpoint breakdown

  • "theme:getPassedID" method (via app init) - open homepage
  • "lang:getPassedID" method (via app init) - open homepage
  • "c:getPassedID" method (via "c_Meta" tag) - open homepage
  • "c:_getPassedStructureID" method's 1st breakpoint:
    • in the beginning of "content" block on "/in-link/designs/section.tpl" template add <inp2:st.current_Field name="Name"/> tag
    • go to Directory category
  • "c:_getPassedStructureID" method's 2md breakpoint:
    • go to .../index.php?t=x&m_cat_id=10 (x - any non-existing template, 10 - any existing category ID)
  • "kDBEventHandler::getPassedID" method 2st breakpoint - any Front-End page
  • "kDBEventHandler::getPassedID" method 3rd breakpoint - I have no idea
  • "kDBEventHandler::getPassedID" method 4th breakpoint - I have no idea
  • "u:getPassedID"
    • on the /platform/my_account/public_profile.tpl template remove RequireLogin tag
    • open the .../index.php?t=platform/my_account/public_profile&user_id=2 url (replace 2 with ID of existing active user, but not Administrator)

Admin Console breakpoint breakdown

  • "kDBEventHandler::getPassedID" method 1st breakpoint - login to the Admin Console

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 455.Jan 20 2016, 6:12 AM
alex retitled this revision from to INP-1526 - Don't call "kDBEventHandler::checkItemStatus" when ID doesn't come from Web Request.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1526.
alex edited the test plan for this revision. (Show Details)Jan 20 2016, 6:13 AM
alex edited edge metadata.
glebs accepted this revision.Feb 17 2016, 2:17 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2016, 2:17 AM
alex edited edge metadata.Mar 10 2016, 5:34 AM
alex added a project: Restricted Project.
This revision was automatically updated to reflect the committed changes.