Page MenuHomeIn-Portal Phabricator
Differential D219

INP-1540 - Actualize "toolbar_buttons" array in the Title Presets
Needs ReviewPublic
Actions

Authored by glebs on Apr 7 2016, 2:48 AM.

Details

Reviewers
alex
Test Plan
NOTE: All test in admin console using simple Admin Console Interface with debug mode enabled.
  1. Go to Configuration → Website → Permission Types and confirm there are 4 buttons on toolbar: Add, Edit, Delete and View.
  2. Open file admin/system_presets/simple/permission_types_permission-type.php in text editor and uncomment line 18 (started as 'permission_type_list' => ).
  3. Go to Configuration → Website → Permission Types and confirm all 4 buttons are hidden.
  4. Go to Website & Content → Promo Blocks and confirm there are 6 buttons on toolbar: Add, Edit, Delete, Approve, Decline and View.
  5. Open file admin/system_presets/simple/promo_block_groups_promo-block-group.php in text editor and uncomment line 18 (started as 'promo_block_group_list' => ).
  6. Go to Website & Content → Promo Blocks and confirm all 6 buttons are hidden.
  7. Go to Website & Content → Promo Blocks → Default Group and confirm there are 10 buttons on toolbar: Add, Edit, Delete, Set Sticky, Approve, Decline, Move Up, Move Down, Settings and View.
  8. Open file admin/system_presets/simple/promo_blocks_promo-block.php in text editor and uncomment lines 18-21 (started as 'promo_block_list' => at 18 and end as '),' at 21).
  9. Go to Website & Content → Promo Blocks → Default Group and confirm all 10 buttons are hidden.

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Preset files doesn't require our code convensions
SeverityLocationCodeMessage
Erroradmin/system_presets/simple/permission_types_permission-type.php:17PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Erroradmin/system_presets/simple/permission_types_permission-type.php:17PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Erroradmin/system_presets/simple/permission_types_permission-type.php:17PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectGeneric.WhiteSpace.ScopeIndent.Incorrect
Erroradmin/system_presets/simple/permission_types_permission-type.php:18PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Erroradmin/system_presets/simple/permission_types_permission-type.php:18PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingAfterCodingStandard.Commenting.InlineComment.SpacingAfter
Erroradmin/system_presets/simple/permission_types_permission-type.php:18PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Erroradmin/system_presets/simple/permission_types_permission-type.php:18PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectGeneric.WhiteSpace.ScopeIndent.Incorrect
Erroradmin/system_presets/simple/permission_types_permission-type.php:20PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Erroradmin/system_presets/simple/permission_types_permission-type.php:20PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Erroradmin/system_presets/simple/permission_types_permission-type.php:20PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectGeneric.WhiteSpace.ScopeIndent.Incorrect
Erroradmin/system_presets/simple/permission_types_permission-type.php:21PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Erroradmin/system_presets/simple/permission_types_permission-type.php:21PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Erroradmin/system_presets/simple/permission_types_permission-type.php:21PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectGeneric.WhiteSpace.ScopeIndent.Incorrect
Erroradmin/system_presets/simple/promo_block_groups_promo-block-group.php:18PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Erroradmin/system_presets/simple/promo_block_groups_promo-block-group.php:18PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingAfterCodingStandard.Commenting.InlineComment.SpacingAfter
Erroradmin/system_presets/simple/promo_block_groups_promo-block-group.php:18PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Erroradmin/system_presets/simple/promo_block_groups_promo-block-group.php:18PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectGeneric.WhiteSpace.ScopeIndent.Incorrect
Erroradmin/system_presets/simple/promo_block_groups_promo-block-group.php:21PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Erroradmin/system_presets/simple/promo_block_groups_promo-block-group.php:21PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Erroradmin/system_presets/simple/promo_block_groups_promo-block-group.php:21PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectGeneric.WhiteSpace.ScopeIndent.Incorrect
Erroradmin/system_presets/simple/promo_blocks_promo-block.php:17PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Erroradmin/system_presets/simple/promo_blocks_promo-block.php:17PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Erroradmin/system_presets/simple/promo_blocks_promo-block.php:17PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectGeneric.WhiteSpace.ScopeIndent.Incorrect
Erroradmin/system_presets/simple/promo_blocks_promo-block.php:18PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Erroradmin/system_presets/simple/promo_blocks_promo-block.php:18PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectGeneric.WhiteSpace.ScopeIndent.Incorrect
Unit
No Unit Test Coverage
Build Status
Buildable 379
Build 379: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 519.Apr 7 2016, 2:48 AM
glebs retitled this revision from to INP-1540 - Actualize "toolbar_buttons" array in the Title Presets.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1540.
glebs edited the test plan for this revision. (Show Details)Apr 7 2016, 6:10 AM
glebs edited edge metadata.

Revision Contents
Changeset List

Diff 519

View Options

admin/system_presets/simple/permission_types_permission-type.php

Loading...
View Options

admin/system_presets/simple/promo_block_groups_promo-block-group.php

Loading...
View Options

admin/system_presets/simple/promo_blocks_promo-block.php

Loading...
View Options

core/units/permission_types/permission_types_config.php

Loading...
View Options

core/units/promo_block_groups/promo_block_groups_config.php

Loading...
View Options

core/units/promo_blocks/promo_blocks_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server