Page MenuHomeIn-Portal Phabricator

INP-1564 Check duplicate SQL revisions across all defined revisions
ClosedPublic

Authored by glebs on Jun 2 2016, 2:34 AM.

Details

Test Plan
NOTE: Test on In-Portal with Custom module installed.

Part 1

  1. add these lines to /modules/custom/install/project_upgrades.sql file (empty line on top !)

# r2: Revision 2
SELECT UNIX_TIMESTAMP();

# r3: Revision 3
SELECT UNIX_TIMESTAMP();
  1. login to admin console as root
  2. go to ToolsSystem Tools section
  3. press Deploy button
  4. confirm you see message, that contains:
Upgrading Database ... 

# r1: Initial Project Task (#TASK_ID)

# r2: Revision 2
SELECT UNIX_TIMESTAMP() ... OK (1)

# r3: Revision 3
SELECT UNIX_TIMESTAMP() ... OK (1)

Part 2

  1. add these lines to /modules/custom/install/project_upgrades.sql file (empty line on top !)

# r2: Revision 2 (duplicated)
SELECT UNIX_TIMESTAMP();
  1. press Deploy button again
  2. confirm you see message
Verifying Database Revisions ... FAILED
Duplicate revision #2 found

Part 3

  1. replace these lines in /modules/custom/install/project_upgrades.sql file (empty line on top !)

# r2: Revision 2 (duplicated)
SELECT UNIX_TIMESTAMP();

by (empty line on top !)


# r4: Revision 4
SELECT UNIX_TIMESTAMP();

# r4: Revision 4 (duplicated)
SELECT UNIX_TIMESTAMP();
  1. press Deploy button again
  2. confirm you see message
Verifying Database Revisions ... FAILED
Duplicate revision #4 found

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

glebs updated this revision to Diff 531.Jun 2 2016, 2:34 AM
glebs retitled this revision from to INP-1564 Check duplicate SQL revisions across all defined revisions.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1564.
alex requested changes to this revision.Jun 2 2016, 3:00 AM
alex edited edge metadata.

Test plan doesn't have part with regression testing. We need to test 2 scenarios:

  • duplicate revision found among executed revisions
  • duplicate revision found among non-executed revisions
core/units/helpers/deployment_helper.php
405 ↗(On Diff #531)

Are you sure, that this comment still applies?

This revision now requires changes to proceed.Jun 2 2016, 3:00 AM
glebs updated this revision to Diff 532.Jun 7 2016, 2:42 AM
glebs edited edge metadata.

Remove outdated comment

alex requested changes to this revision.Jun 7 2016, 3:20 AM
alex edited edge metadata.

I don't see test plan update.

This revision now requires changes to proceed.Jun 7 2016, 3:20 AM
glebs edited the test plan for this revision. (Show Details)Jun 9 2016, 1:19 AM
glebs edited edge metadata.
glebs requested a review of this revision.Jun 9 2016, 2:11 AM
glebs edited edge metadata.
alex edited the test plan for this revision. (Show Details)Nov 19 2016, 7:39 AM
alex edited edge metadata.
alex edited the test plan for this revision. (Show Details)
alex accepted this revision.Nov 19 2016, 7:42 AM
alex edited the test plan for this revision. (Show Details)
alex edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2016, 7:43 AM
This revision was automatically updated to reflect the committed changes.