Page MenuHomeIn-Portal Phabricator

INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE
ClosedPublic

Authored by glebs on Nov 14 2014, 4:38 AM.

Details

Test Plan

Check all changed sections:

  • form (Website & ConfigForms)
  • formsubs (Website & ConfigFormsContact Us)
  • u (User ManagementUsers)
  • p, c-ebay, p-ebay (Website & ConfigProducts)
  • addr (User ManagementUsersEdit User -Addresses)
  • rep (E-commerceSales Report)
  • link-validation (DirectoryLink Validation)
  • l (Website & ConfigLinks)
  • n (Website & ConfigArticles)

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

glebs updated this revision to Diff 62.Nov 14 2014, 4:38 AM
glebs retitled this revision from to [INP-1369] Transform all hooks to u::OnAfterConfigRead event into hBEFORE.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added a reviewer: alex.
glebs added 1 JIRA issue(s): INP-1369.
glebs updated this revision to Diff 63.Nov 14 2014, 8:40 AM

Fix paths

alex edited edge metadata.Nov 23 2014, 3:14 AM

Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.

alex retitled this revision from [INP-1369] Transform all hooks to u::OnAfterConfigRead event into hBEFORE to INP-1369 - Transform all hooks to u::OnAfterConfigRead event into hBEFORE.Dec 7 2014, 3:37 PM
alex edited edge metadata.
alex set the repository for this revision to rINP In-Portal.
alex retitled this revision from INP-1369 - Transform all hooks to u::OnAfterConfigRead event into hBEFORE to INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.Feb 22 2015, 9:12 AM
alex requested changes to this revision.Feb 22 2015, 3:01 PM
alex edited edge metadata.

Example hook in modules/custom/units/sections/sections_config.php file, that is currently commented out, still uses hAFTER.

modules/in-auction/units/sections/sections_config.php
129 ↗(On Diff #63)

Please rename the OnAfterProductConfigRead event into OnModifyProductsConfig because currently used event name conflicts with hook definition (hook says that it runs before, but event name says that it's executed after).

140 ↗(On Diff #63)

Please rename the OnAfterCategoryConfigRead event into OnModifyCategoriesConfig because currently used event name conflicts with hook definition (hook says that it runs before, but event name says that it's executed after).

This revision now requires changes to proceed.Feb 22 2015, 3:01 PM
glebs edited the test plan for this revision. (Show Details)Mar 6 2015, 3:56 AM
glebs edited edge metadata.
glebs updated this revision to Diff 114.Mar 6 2015, 3:57 AM
glebs edited edge metadata.
glebs edited the test plan for this revision. (Show Details)

Rename hooks and fix example hook

alex accepted this revision.Mar 6 2015, 4:01 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 4:01 AM
This revision was automatically updated to reflect the committed changes.