Page MenuHomeIn-Portal Phabricator

INP-1589 - Actualize version/hash used in CKEditor PHP connector
Needs RevisionPublic

Authored by glebs on Jan 2 2017, 6:08 AM.


Test Plan
  1. Login to admin
  2. Go to Website & ContentBrowse Website and switch to Content Mode
  3. Open browser web-developer tools/console on network tab
  4. Click on one of Edit Content buttons
  5. Confirm that ckeditor.js in Network tab loads with parameter t equals to D6IE. Like ckeditor.js?t=D6IE

Diff Detail

rINP In-Portal
Lint OK
No Unit Test Coverage
Build Status
Buildable 637
Build 637: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 671.Jan 2 2017, 6:08 AM
glebs retitled this revision from to INP-1589 Actualize version/hash used in CKEditor PHP connector.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1589.
glebs added inline comments.Jan 2 2017, 6:09 AM

I've used timestamp value from ckeditor.js. It defined close to version value

alex requested changes to this revision.Jan 3 2017, 4:03 AM
alex edited edge metadata.

Existing code changes are fine, but here are few additions:

  1. add WysiwygEditorTimestamp system setting:
    • after: EnablePageContentRevisionControl
    • section: ConfigurationWebsiteAdvanced
    • sub-section: Admin Console Settings
    • control: textbox
    • default: empty
    • title (main translation of la_config_WysiwygEditorTimestamp phrase): WYSIWYG Editor Timestamp
    • hint (hint translation of la_config_WysiwygEditorTimestamp phrase): Change value to invalidate WYSIWYG editor assets, e.g. CSS, JS, Plugins.
  2. in fckFCKHelper::getEditor method if WysiwygEditorTimestamp system setting isn't empty set $editor->timestamp property into it's value
  3. update test plan to demonstrate, that user timestamp is used, when specified and default timestamp is used, when user timestamp is empty
This revision now requires changes to proceed.Jan 3 2017, 4:03 AM
alex retitled this revision from INP-1589 Actualize version/hash used in CKEditor PHP connector to INP-1589 - Actualize version/hash used in CKEditor PHP connector.Aug 3 2022, 4:41 AM