Page MenuHomeIn-Portal Phabricator

INP-1669 - Add local "mapper" variable to the "DropDownMapper.Init" method
Needs RevisionPublic

Authored by glebs on Feb 2 2017, 4:51 AM.

Details

Reviewers
alex
Test Plan

Will write later

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 678
Build 678: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 700.Feb 2 2017, 4:51 AM
glebs retitled this revision from to INP-1669 Uncaught ReferenceError: mapper is not defined in DropDownMapper.Init().
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1669.
alex added inline comments.Feb 2 2017, 11:53 AM
core/admin_templates/js/dropdown_mapper.js
13

This worked in other projects because:

  • there was only 1 instance of DropDownMapper class on the page
  • that class instance was assigned to global mapper variable
var mapper = new DropDownMapper( ...

In fact this is recommended workaround until this patch is merged.

I can't really tell if variable name was chosen to match local variables in class itself or people using the class are just lucky.

alex retitled this revision from INP-1669 Uncaught ReferenceError: mapper is not defined in DropDownMapper.Init() to INP-1669 Add local "mapper" variable to the "DropDownMapper.Init" method.Mar 29 2017, 1:58 AM
alex edited edge metadata.
alex added a project: Restricted Project.
alex requested changes to this revision.Apr 12 2017, 6:06 AM
alex edited edge metadata.

Please add corresponding discussion in Confluence.


The submission workflow wasn't respected.

This revision now requires changes to proceed.Apr 12 2017, 6:06 AM
alex retitled this revision from INP-1669 Add local "mapper" variable to the "DropDownMapper.Init" method to INP-1669 - Add local "mapper" variable to the "DropDownMapper.Init" method.Aug 3 2022, 4:40 AM