Page MenuHomeIn-Portal Phabricator

INP-1396 - Automatically validate submitted patches

Authored by alex on Dec 30 2014, 9:10 AM.


Test Plan
NOTE: Ensure latest Arcanist version is installed by running arc upgrade.
  1. run arc lint or arc lint --cl and see that no errors are displayed
  2. make some changes in Default or other changelist that would violate coding standards (e.g. inline comment starts with small letter)
  3. run arc lint or arc lint --cl and see that errors are displayed
  4. run arc diff or arc diff --cl, which should trigger arc lint internally and same errors/no errors should be displayed
  5. keep in mind, that only errors on changed lines in a file are displayed

Diff Detail

rINP In-Portal
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 86.Dec 30 2014, 9:10 AM
alex retitled this revision from to INP-1396 - Automatically validate submitted patches.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1396.
glebs accepted this revision.Dec 30 2014, 10:31 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:31 AM
This revision was automatically updated to reflect the committed changes.