Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • branches/5.2.x/core/kernel/utility/debugger.php

INP-1401 - Don't use "die" in Debugger
ClosedPublic

Authored by alex on Jan 16 2015, 3:53 AM.

Details

Test Plan

Perform each test (from below) in following setups (if something is enabled, then error must be logged !):

  • System Log enabled + Debug Mode enabled
  • System Log enabled + Debug Mode disabled
  • System Log disabled + Debug Mode enabled
  • System Log disabled + Debug Mode disabled
  1. system fatal error: non existing method call on existing object
    • add $this->nonExisting(); line to the kMainTagProcessor::GetEquals method
    • go to /admin url, but don't login
  2. user exception throwing
    • add throw new Exception('test e'); line to the kMainTagProcessor::GetEquals method
    • go to /admin url, but don't login
  3. user fatal error
    • add trigger_error('user err', E_USER_ERROR); line to the kMainTagProcessor::GetEquals method
    • go to /admin url, but don't login
  4. user notice (no auto-debugger popup, script continues to execute)
    • add trigger_error('user err', E_USER_NOTICE); line to the kMainTagProcessor::GetEquals method
    • go to /admin url, but don't login

In any of above cases (unless specially said otherwise):

  • the script execution must stop and only output collected prior to error should be displayed
  • if Debug Mode is enabled, then debugger must be displayed automatically and scroll to the bottom, where error is

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 93.Jan 16 2015, 3:53 AM
alex retitled this revision from to INP-1401 - Don't use "die" in Debugger.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1401.
alex added a comment.Jan 16 2015, 3:56 AM

This will also solve problem in D3, where with enabled debugger System Log never logs fatal error about non-existing object method call.

glebs accepted this revision.Mar 9 2015, 2:13 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 2:13 AM
This revision was automatically updated to reflect the committed changes.