Differential D42

INP-1408 - Perform search, when ENTER used in "grid_like_combo_filter" block (the AJAXDropdown)
ClosedPublic
Actions

Authored by alex on Feb 11 2015, 11:36 AM.

Details

Reviewers

glebs

Commits

rINP16153: Fixes INP-1408 - The "grid_like_combo_filter" doesn't trigger search on ENTER…

Test Plan

NOTE: The "grid_like_combo_filter" isn't currently used anywhere.

in any grid definition replace 'filter_block' => 'grid_like_filter' with 'filter_block' => 'grid_like_combo_filter'
check, that pressing ENTER in changed column filter will submit new search
check, that suggested auto-complete result selected via Up/Down arrows will be placed in filter on ENTER press

Diff Detail

Repository

rINP In-Portal

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 104.Feb 11 2015, 11:36 AM

alex retitled this revision from to INP-1408 - The "grid_like_combo_filter" doesn't trigger search on ENTER press.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1408.

Herald added a reviewer: glebs. · View Herald TranscriptFeb 11 2015, 11:36 AM

glebs accepted this revision.Mar 10 2015, 2:51 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Mar 10 2015, 2:51 AM

Closed by commit rINP16153: Fixes INP-1408 - The "grid_like_combo_filter" doesn't trigger search on ENTER… (authored by alex). · Explain WhyMar 21 2015, 9:10 AM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 6:44 AM

alex added a project: Restricted Project.

alex retitled this revision from INP-1408 - The "grid_like_combo_filter" doesn't trigger search on ENTER press to INP-1408 - The "grid_like_combo_filter" doesn't trigger search on ENTER press (the AjaxDropdown).Mar 27 2016, 6:52 AM

alex retitled this revision from INP-1408 - The "grid_like_combo_filter" doesn't trigger search on ENTER press (the AjaxDropdown) to INP-1408 - Perform search, when ENTER used in "grid_like_combo_filter" block (the AJAXDropdown).Jul 16 2016, 7:23 AM

Revision Contents
Changeset List

			Path	Packages
M			branches/5.2.x/core/admin_templates/js/ajax_dropdown.js (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	104	16128		Feb 11 2015, 11:36 AM	★	★
Diff 2	141	16152	Commit rINP16153	Mar 21 2015, 9:10 AM	★	★

Diff 141

View Options

branches/5.2.x/core/admin_templates/js/ajax_dropdown.js

INP-1408 - Perform search, when ENTER used in "grid_like_combo_filter" block (the AJAXDropdown)ClosedPublicActions