Differential D44

MINC-114 - Cleanup IDs of saved orders before adding/editing new orders
ClosedPublic
Actions

Authored by alex on Mar 2 2015, 11:13 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rMINC16137: Fixes MINC-114 - Cleanup IDs of saved orders before adding/editing new orders

Test Plan

place breakpoint in ord:OnSave event
create an order -> verify, that ReserveItems method is called for created order (before this fix the ID=0 was used)
edit an order -> verify, that ReserveItems method is called for edited order
create another order
edit both orders together -> verify, that ReserveItems method is called once for each order (before it would be called 3 times)

Diff Detail

Repository

rMINC Modules.In-Commerce

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 112.Mar 2 2015, 11:13 AM

alex retitled this revision from to MINC-114 - Cleanup IDs of saved orders before adding/editing new orders.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): MINC-114.

Herald added a reviewer: glebs. · View Herald TranscriptMar 2 2015, 11:13 AM

glebs accepted this revision.Mar 3 2015, 3:17 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2015, 3:17 AM

Closed by commit rMINC16137: Fixes MINC-114 - Cleanup IDs of saved orders before adding/editing new orders (authored by alex). · Explain WhyMar 21 2015, 5:59 AM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 6:45 AM

alex added a project: Restricted Project.

Revision Contents
Changeset List

Diff 130

branches/5.2.x/units/orders/orders_event_handler.php

Loading...