Page MenuHomeIn-Portal Phabricator
Differential D48

MINC-118 - Fix notices on Shipping/Billing tab of order in "To Ship" status
ClosedPublic
Actions

Authored by alex on Mar 11 2015, 1:39 PM.

Details

Reviewers
glebs
Commits
rMINC16151: Fixes MINC-118 - Notices on Shipping/Billing tab of order in "To Ship" status
Test Plan
  1. create order, that will contain tangible product
  2. place it (button on toolbar)
  3. confirm, that order is in "To Ship" status
  4. open order for editing
  5. confirm, that no warnings/notices are shown in debugger on Billing/Shipping tabs

Diff Detail

Repository
rMINC Modules.In-Commerce
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 119.Mar 11 2015, 1:39 PM
alex retitled this revision from to MINC-118 - Notices on Shipping/Billing tab of order in "To Ship" status.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): MINC-118.
alex added inline comments.Mar 11 2015, 1:40 PM
modules/in-commerce/admin_templates/orders/orders_edit_billing.tpl
158 ↗(On Diff #119)

This was removed, because VerificationResult doesn't exist anywhere.

glebs accepted this revision.Mar 12 2015, 3:13 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2015, 3:13 AM
Closed by commit rMINC16151: Fixes MINC-118 - Notices on Shipping/Billing tab of order in "To Ship" status (authored by alex). · Explain WhyMar 21 2015, 7:23 AM
This revision was automatically updated to reflect the committed changes.
alex retitled this revision from MINC-118 - Notices on Shipping/Billing tab of order in "To Ship" status to MINC-118 - Fix notices on Shipping/Billing tab of order in "To Ship" status.Jul 16 2016, 6:49 AM
alex edited edge metadata.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 111916128Mar 11 2015, 1:39 PM
★
★
Diff 213916149Commit rMINC16151Mar 21 2015, 7:23 AM
★
★

Diff 139

View Options

branches/5.2.x/admin_templates/orders/orders_edit_billing.tpl

Loading...
View Options

branches/5.2.x/admin_templates/orders/orders_edit_shipping.tpl

Loading...
View Options

branches/5.2.x/units/shipping/shipping_tag_processor.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server