Page MenuHomeIn-Portal Phabricator

INP-1438 - Don't validate form field value length, when it's empty
ClosedPublic

Authored by alex on Jul 9 2015, 12:18 PM.

Details

Test Plan
  1. pick any unit, that has string fields defined (e.g. manuf - Manufacturers)
  2. pick any string field (e.g. Name) and apply following modifications to it's options:
    • remove required option
    • set min_len option to 5
    • set max_len option
  3. try submitting the form without entering that field value
  4. confirm, that no validation error happened on that field
  5. enter ab value in the field and submit the form
  6. confirm, that validation on string length is performed

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 220.Jul 9 2015, 12:18 PM
alex retitled this revision from to INP-1438 - Form field value length assertion is done on empty value.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1438.
glebs accepted this revision.Sep 2 2015, 2:01 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Sep 2 2015, 2:01 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 5:54 AM
alex added a project: Restricted Project.
alex retitled this revision from INP-1438 - Form field value length assertion is done on empty value to INP-1438 - Don't validate form field value length, when it's empty.Jul 16 2016, 7:18 AM