Differential D90

INP-1442 - Don't modify opener stack, when performing concurrent page editing AJAX notifications
ClosedPublic
Actions

Authored by alex on Jul 24 2015, 2:45 PM.

Details

Reviewers

glebs

Commits

rINP16233: Fixes INP-1442 - Concurrent page editing AJAX notification shouldn't modify…

Test Plan

enable Enable Revision Control for Section Content setting under Configuration → Website → Advanced section
go to Website & Content → Browse Website
enter Content Mode (link in top frame)
open any content block for editing
wait 21 second
confirm, that:
- AJAX request to page-revision:OnGetInfo event has fired
- URL to that event contains m_opener with d value (in url it would look like -d-)
save content block
confirm, that you stayed within Content Mode and weren't redirected to Browse Mode

Diff Detail

Repository

rINP In-Portal

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 224.Jul 24 2015, 2:45 PM

alex retitled this revision from to INP-1442 - Concurrent page editing AJAX notification shouldn't modify opener stack.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1442.

Herald added a reviewer: glebs. · View Herald TranscriptJul 24 2015, 2:45 PM

glebs accepted this revision.Sep 2 2015, 5:29 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Sep 2 2015, 5:29 AM

Closed by commit rINP16233: Fixes INP-1442 - Concurrent page editing AJAX notification shouldn't modify… (authored by alex). · Explain WhySep 2 2015, 2:55 PM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 5:52 AM

alex added a project: Restricted Project.

alex retitled this revision from INP-1442 - Concurrent page editing AJAX notification shouldn't modify opener stack to INP-1442 - Don't modify opener stack, when performing concurrent page editing AJAX notifications.Jul 16 2016, 7:14 AM

Revision Contents
Changeset List

			Path	Packages
M			branches/5.2.x/core/admin_templates/js/template_manager.js (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	224	16200		Jul 24 2015, 2:45 PM	★	★
Diff 2	280	16232	Commit rINP16233	Sep 2 2015, 2:55 PM	★	★

Diff 280

View Options

branches/5.2.x/core/admin_templates/js/template_manager.js

INP-1442 - Don't modify opener stack, when performing concurrent page editing AJAX notificationsClosedPublicActions