Changeset View
Changeset View
Standalone View
Standalone View
core/install.php
Show First 20 Lines • Show All 285 Lines • ▼ Show 20 Line(s) | |||||
} | } | ||||
elseif ( !$this->GetVar('js_enabled') || !$this->GetVar('cookies_enabled') ) { | elseif ( !$this->GetVar('js_enabled') || !$this->GetVar('cookies_enabled') ) { | ||||
// js/cookies disabled | // js/cookies disabled | ||||
$this->errorMessage = '<br/>Installation can not continue until all required environment parameters are set correctly'; | $this->errorMessage = '<br/>Installation can not continue until all required environment parameters are set correctly'; | ||||
} | } | ||||
break; | break; | ||||
case 'check_paths': | case 'check_paths': | ||||
$writeable_base = $this->toolkit->systemConfig->get('WriteablePath', 'Misc'); | $writeable_base = $this->toolkit->systemConfig->get('WriteablePath', 'Misc'); | ||||
foreach ($this->writeableFolders as $folder_path) { | foreach ( $this->writeableFolders as $folder_path ) { | ||||
$file_path = FULL_PATH . str_replace('$1', $writeable_base, $folder_path); | $file_path = FULL_PATH . str_replace('$1', $writeable_base, $folder_path); | ||||
if (file_exists($file_path) && !is_writable($file_path)) { | if ( file_exists($file_path) && !is_writable($file_path) ) { | ||||
$this->errorMessage = '<br/>Installation can not continue until all required permissions are set correctly'; | $this->errorMessage = <<<'HTML' | ||||
<br/>Installation can not continue until all required permissions are set correctly | |||||
HTML; | |||||
break; | break; | ||||
} | } | ||||
} | } | ||||
alex: Thank you, but please revert these changes.
---
Random CS fixes to unrelated code does more… | |||||
if ( !$this->errorMessage ) { | |||||
alexUnsubmitted Not Done ReplyPlease also check, that DBType is mysql currently. The config is changed (even to same value) on each installator visit. alex: Please also check, that `DBType` is `mysql` currently.
---
The config is changed (even to… | |||||
$this->toolkit->systemConfig->set('DBType', 'Database', 'mysqli'); | |||||
$this->toolkit->systemConfig->save(); | |||||
} | |||||
break; | break; | ||||
case 'clean_db': | case 'clean_db': | ||||
// don't use Application, because all tables will be erased and it will crash | // don't use Application, because all tables will be erased and it will crash | ||||
$sql = 'SELECT Path | $sql = 'SELECT Path | ||||
FROM ' . TABLE_PREFIX . 'Modules'; | FROM ' . TABLE_PREFIX . 'Modules'; | ||||
$modules = $this->Conn->GetCol($sql); | $modules = $this->Conn->GetCol($sql); | ||||
▲ Show 20 Lines • Show All 1468 Lines • Show Last 20 Lines |
Thank you, but please revert these changes.
Random CS fixes to unrelated code does more harm than good.